mbox series

[v6,0/3] migration: compression optimization

Message ID 20180906070101.27280-1-xiaoguangrong@tencent.com (mailing list archive)
Headers show
Series migration: compression optimization | expand

Message

Xiao Guangrong Sept. 6, 2018, 7 a.m. UTC
From: Xiao Guangrong <xiaoguangrong@tencent.com>

Changelog in v6:

Thanks to Juan's review, in this version we
1) move flush compressed data to find_dirty_block() where it hits the end
   of memblock
2) use save_page_use_compression instead of migrate_use_compression in
   flush_compressed_data

Xiao Guangrong (3):
  migration: do not flush_compressed_data at the end of iteration
  migration: show the statistics of compression
  migration: use save_page_use_compression in flush_compressed_data

 hmp.c                 | 13 +++++++++++
 migration/migration.c | 12 ++++++++++
 migration/ram.c       | 63 +++++++++++++++++++++++++++++++++++++++++++--------
 migration/ram.h       |  1 +
 qapi/migration.json   | 26 ++++++++++++++++++++-
 5 files changed, 105 insertions(+), 10 deletions(-)

Comments

Juan Quintela Sept. 6, 2018, 11:03 a.m. UTC | #1
guangrong.xiao@gmail.com wrote:
> From: Xiao Guangrong <xiaoguangrong@tencent.com>
>
> Changelog in v6:
>
> Thanks to Juan's review, in this version we
> 1) move flush compressed data to find_dirty_block() where it hits the end
>    of memblock
> 2) use save_page_use_compression instead of migrate_use_compression in
>    flush_compressed_data
>
> Xiao Guangrong (3):
>   migration: do not flush_compressed_data at the end of iteration
>   migration: show the statistics of compression
>   migration: use save_page_use_compression in flush_compressed_data
>
>  hmp.c                 | 13 +++++++++++
>  migration/migration.c | 12 ++++++++++
>  migration/ram.c       | 63 +++++++++++++++++++++++++++++++++++++++++++--------
>  migration/ram.h       |  1 +
>  qapi/migration.json   | 26 ++++++++++++++++++++-
>  5 files changed, 105 insertions(+), 10 deletions(-)

queued
Xiao Guangrong Sept. 13, 2018, 7:45 a.m. UTC | #2
On 09/06/2018 07:03 PM, Juan Quintela wrote:
> guangrong.xiao@gmail.com wrote:
>> From: Xiao Guangrong <xiaoguangrong@tencent.com>
>>
>> Changelog in v6:
>>
>> Thanks to Juan's review, in this version we
>> 1) move flush compressed data to find_dirty_block() where it hits the end
>>     of memblock
>> 2) use save_page_use_compression instead of migrate_use_compression in
>>     flush_compressed_data
>>
>> Xiao Guangrong (3):
>>    migration: do not flush_compressed_data at the end of iteration
>>    migration: show the statistics of compression
>>    migration: use save_page_use_compression in flush_compressed_data
>>
>>   hmp.c                 | 13 +++++++++++
>>   migration/migration.c | 12 ++++++++++
>>   migration/ram.c       | 63 +++++++++++++++++++++++++++++++++++++++++++--------
>>   migration/ram.h       |  1 +
>>   qapi/migration.json   | 26 ++++++++++++++++++++-
>>   5 files changed, 105 insertions(+), 10 deletions(-)
> 
> queued
> 

Hi Juan,

Could i ask where is the place you queued these patches, i did not found
them on your git tree at
    https://github.com/juanquintela/qemu migration/next or migration.next

I am working on the next part of migration, it's more convenient to let
it be based on your place. :)

Thanks!
Juan Quintela Sept. 13, 2018, 1:26 p.m. UTC | #3
Xiao Guangrong <guangrong.xiao@gmail.com> wrote:
> On 09/06/2018 07:03 PM, Juan Quintela wrote:
>> guangrong.xiao@gmail.com wrote:
>>> From: Xiao Guangrong <xiaoguangrong@tencent.com>
>>>
>>> Changelog in v6:
>>>
>>> Thanks to Juan's review, in this version we
>>> 1) move flush compressed data to find_dirty_block() where it hits the end
>>>     of memblock
>>> 2) use save_page_use_compression instead of migrate_use_compression in
>>>     flush_compressed_data
>>>
>>> Xiao Guangrong (3):
>>>    migration: do not flush_compressed_data at the end of iteration
>>>    migration: show the statistics of compression
>>>    migration: use save_page_use_compression in flush_compressed_data
>>>
>>>   hmp.c                 | 13 +++++++++++
>>>   migration/migration.c | 12 ++++++++++
>>>   migration/ram.c       | 63 +++++++++++++++++++++++++++++++++++++++++++--------
>>>   migration/ram.h       |  1 +
>>>   qapi/migration.json   | 26 ++++++++++++++++++++-
>>>   5 files changed, 105 insertions(+), 10 deletions(-)
>>
>> queued
>>
>
> Hi Juan,
>
> Could i ask where is the place you queued these patches, i did not found
> them on your git tree at
>    https://github.com/juanquintela/qemu migration/next or migration.next
>
> I am working on the next part of migration, it's more convenient to let
> it be based on your place. :)

They are there now, I send the pull request already.  I am going to be
on vacation for the following four weeks.  Migration issues will be
handled by David.

Thanks, Juan.