[0/2] replication: drop extra sync

Message

Vladimir Sementsov-Ogievskiy Sept. 19, 2018, 12:43 p.m. UTC

Hi all!

We finally implemented fleecing scheme, create a test case for it (222)
and even made it safe (f8d59dfb40).

However, fleecing is used inside block-replication long ago, and to make
the scheme safe it uses direct interface to backup-job copy requests
synchronization, which can be dropped now.

Vladimir Sementsov-Ogievskiy (2):
  block/replication: drop extra synchronization
  block/backup: drop unused synchronization interface

 include/block/block_backup.h | 13 ------------
 block/backup.c               | 38 +++++++-----------------------------
 block/replication.c          | 24 +----------------------
 3 files changed, 8 insertions(+), 67 deletions(-)

Comments

Vladimir Sementsov-Ogievskiy Oct. 11, 2018, 3:40 p.m. UTC | #1

ping

19.09.2018 15:43, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We finally implemented fleecing scheme, create a test case for it (222)
> and even made it safe (f8d59dfb40).
>
> However, fleecing is used inside block-replication long ago, and to make
> the scheme safe it uses direct interface to backup-job copy requests
> synchronization, which can be dropped now.
>
> Vladimir Sementsov-Ogievskiy (2):
>    block/replication: drop extra synchronization
>    block/backup: drop unused synchronization interface
>
>   include/block/block_backup.h | 13 ------------
>   block/backup.c               | 38 +++++++-----------------------------
>   block/replication.c          | 24 +----------------------
>   3 files changed, 8 insertions(+), 67 deletions(-)
>

Vladimir Sementsov-Ogievskiy Oct. 31, 2018, 9:30 a.m. UTC | #2

ping2

Hi, it's a first step to backup refactoring and improving. Just get rid 
of this extra and unnatural synchronization.

19.09.2018 15:43, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We finally implemented fleecing scheme, create a test case for it (222)
> and even made it safe (f8d59dfb40).
>
> However, fleecing is used inside block-replication long ago, and to make
> the scheme safe it uses direct interface to backup-job copy requests
> synchronization, which can be dropped now.
>
> Vladimir Sementsov-Ogievskiy (2):
>    block/replication: drop extra synchronization
>    block/backup: drop unused synchronization interface
>
>   include/block/block_backup.h | 13 ------------
>   block/backup.c               | 38 +++++++-----------------------------
>   block/replication.c          | 24 +----------------------
>   3 files changed, 8 insertions(+), 67 deletions(-)
>

Kevin Wolf Nov. 6, 2018, 5:17 p.m. UTC | #3

Am 31.10.2018 um 10:30 hat Vladimir Sementsov-Ogievskiy geschrieben:
> ping2
> 
> Hi, it's a first step to backup refactoring and improving. Just get rid 
> of this extra and unnatural synchronization.

The replication maintainers don't seem to have an opinion about this, so
thanks, applied to block-next (for 3.2).

Kevin