From patchwork Fri Sep 21 22:28:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 10611091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5135C112B for ; Fri, 21 Sep 2018 22:30:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43B8B2D323 for ; Fri, 21 Sep 2018 22:30:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 378A12D33D; Fri, 21 Sep 2018 22:30:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EA54C2D323 for ; Fri, 21 Sep 2018 22:30:38 +0000 (UTC) Received: from localhost ([::1]:57627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Twc-0000ys-4m for patchwork-qemu-devel@patchwork.kernel.org; Fri, 21 Sep 2018 18:30:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Tv5-0008Cy-Lz for qemu-devel@nongnu.org; Fri, 21 Sep 2018 18:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Tv4-00059q-VN for qemu-devel@nongnu.org; Fri, 21 Sep 2018 18:29:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39134) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g3Tv0-0004vC-Ll; Fri, 21 Sep 2018 18:28:58 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39C6F30820CF; Fri, 21 Sep 2018 22:28:57 +0000 (UTC) Received: from probe.redhat.com (ovpn-121-77.rdu2.redhat.com [10.10.121.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D0821073033; Fri, 21 Sep 2018 22:28:50 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Fri, 21 Sep 2018 18:28:41 -0400 Message-Id: <20180921222847.1012-1-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 21 Sep 2018 22:28:57 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [RFC PATCH v2 0/6] dirty-bitmaps: fix QMP command permissions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , vsementsov@virtuozzo.com, Fam Zheng , Markus Armbruster , Max Reitz , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This builds on the previous standalone patch I sent and audits the permissions we check for other QMP operations on bitmaps. This should make it more consistent overall, but it's not complete and I'm heading out for a long weekend, but I wanted them on the list. I think I should reorder the patches at least, and I need to write some tests that I can submit upstream in a polished form. John Snow (6): dirty-bitmaps: allow merging to disabled bitmaps bitmaps: allow clear on disabled bitmaps bitmaps: prohibit merge on locked bitmaps bitmaps: add user_modifiable status checker bitmaps: prohibit enable/disable on locked/frozen bitmaps block/backup: prohibit backup from using in-use bitmaps block/dirty-bitmap.c | 9 ++++-- blockdev.c | 66 ++++++++++++++++++++------------------------ include/block/dirty-bitmap.h | 1 + 3 files changed, 38 insertions(+), 38 deletions(-)