From patchwork Fri Oct 26 08:16:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Michel X-Patchwork-Id: 10657101 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E686713A9 for ; Fri, 26 Oct 2018 08:43:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD59C2C581 for ; Fri, 26 Oct 2018 08:43:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C12E02C623; Fri, 26 Oct 2018 08:43:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2E6942C581 for ; Fri, 26 Oct 2018 08:43:15 +0000 (UTC) Received: from localhost ([::1]:58881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFxi6-0000CL-7Q for patchwork-qemu-devel@patchwork.kernel.org; Fri, 26 Oct 2018 04:43:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFxUK-0002m7-W5 for qemu-devel@nongnu.org; Fri, 26 Oct 2018 04:29:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFxJD-0004oU-J4 for qemu-devel@nongnu.org; Fri, 26 Oct 2018 04:17:33 -0400 Received: from greensocs.com ([193.104.36.180]:45293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFxJ7-0004hb-Us; Fri, 26 Oct 2018 04:17:26 -0400 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id 6545D441B46; Fri, 26 Oct 2018 10:17:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1540541832; bh=vMEupsw/0MfAu44ZgjU8MOtwa1h57n9aWIfiNBuTW24=; h=From:To:Cc:Subject:Date; b=CJdd3iS0RzRebztVrshTrYi9e162wKi8TExf6zNiMY9xlGKKDxUxV5JTnsLezJgCU 08CqGl6feG/+BEqViKv15y5KqH12jyc35uHDKT9ZzhMFGowNCPJGH9BNVfpeQpAGEO p774mGY2Ww+viLFkyq5sh3CuAlBnCZbbhPM/OaqY= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=Yo4rUDFb; dkim=pass (1024-bit key) header.d=greensocs.com header.b=Yo4rUDFb Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13VH1s3l-_rd; Fri, 26 Oct 2018 10:17:11 +0200 (CEST) Received: by greensocs.com (Postfix, from userid 998) id 9503F441B42; Fri, 26 Oct 2018 10:17:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1540541831; bh=vMEupsw/0MfAu44ZgjU8MOtwa1h57n9aWIfiNBuTW24=; h=From:To:Cc:Subject:Date; b=Yo4rUDFbeYXQ4byQ7ZUXnVywiZmJL8PyA+BAKyRU68YtVZVpXACmeyWQf9jSXlGme guI7aTZAGmQNL1/wsYfAXsmrj5vvRzNe8pHs0fUJkWYm8i1vuHUlSFhqXZNvMwXOtl Uhw78f8cV2E8c+o0ZBuMcEm6CUxqsFBogwyrtrBo= Received: from michell-laptop.home.lmichel.fr (lfbn-1-8165-82.w90-112.abo.wanadoo.fr [90.112.74.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luc.michel@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 29BB9441B41; Fri, 26 Oct 2018 10:17:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1540541831; bh=vMEupsw/0MfAu44ZgjU8MOtwa1h57n9aWIfiNBuTW24=; h=From:To:Cc:Subject:Date; b=Yo4rUDFbeYXQ4byQ7ZUXnVywiZmJL8PyA+BAKyRU68YtVZVpXACmeyWQf9jSXlGme guI7aTZAGmQNL1/wsYfAXsmrj5vvRzNe8pHs0fUJkWYm8i1vuHUlSFhqXZNvMwXOtl Uhw78f8cV2E8c+o0ZBuMcEm6CUxqsFBogwyrtrBo= From: Luc Michel To: qemu-devel@nongnu.org Date: Fri, 26 Oct 2018 10:16:37 +0200 Message-Id: <20181026081653.24602-1-luc.michel@greensocs.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH v3 00/16] gdbstub: support for the multiprocess extension X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , alistair@alistair23.me, mark.burton@greensocs.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , saipava@xilinx.com, edgari@xilinx.com, qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP changes since v2: - patch 1 introducing the cpu-cluster type. I didn't opt for an Interface, but I can add one if you think it's necessary. For now this class inherits from Device and has a cluster-id property, used by the GDB stub to compute a PID. - patch 2 removed GDB group related code as it has been replaced with CPU clusters - patch 2/8 moved GDBProcess target_xml field introduction into patch 8 [Philippe] - patch 3 gdb_get_cpu_pid() now search for CPU being a child of a cpu-cluster object. Use the cluster-id to compute the PID. - patch 4 gdb_get_process() does not rely on s->processes array indices anymore as PIDs can now be sparse. Instead, iterate over the array to find the process. - patch 3/4 removed Reviewed-by tags because of substantial changes. - patch 4/7 read_thread_id() hardening [Philippe] - patch 12 safer vAttach packet parsing [Phillipe] - patch 16 put APUs and RPUs in different clusters instead of GDB groups changes since v1: - rename qemu_get_thread_id() to gdb_fmt_thread_id() [Philippe] - check qemu_strtoul() return value for 'D' packets [Philippe] This series adds support for the multiprocess extension of the GDB remote protocol in the QEMU GDB stub. This extension is useful to split QEMU emulated CPUs in different processes from the point of view of the GDB client. It adds the possibility to debug different kind of processors (e.g. an AArch64 and an ARMv7 CPU) at the same time (it is not possible otherwise since GDB expects an SMP view at the thread granularity. CPUs are grouped using specially named QOM containers. CPUs that are children of such a container are grouped under the same GDB process. The last patch groups the CPUs of different model in the zynqmp machines into separate processes. To test this patchset, you can use the following commands: (Note that this requires a recent enough GDB, I think GDB 7.2 is OK. Also, it must be compiled to support both ARM and AArch64 architectures) Run QEMU: (-smp 6 in xlnx-zcu102 enables both cortex-a53 and cortex-r5 CPUs) qemu-system-aarch64 -M xlnx-zcu102 -gdb tcp::1234 -S -smp 6 Run the following commands in GDB: target extended :1234 add-inferior inferior 2 attach 2 info threads I want to thanks the Xilinx's QEMU team who sponsored this work for their collaboration and their prototype implementation. Luc Michel (16): hw/cpu: introduce CPU clusters gdbstub: introduce GDB processes gdbstub: add multiprocess support to '?' packets gdbstub: add multiprocess support to 'H' and 'T' packets gdbstub: add multiprocess support to vCont packets gdbstub: add multiprocess support to 'sC' packets gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo gdbstub: add multiprocess support to Xfer:features:read: gdbstub: add multiprocess support to gdb_vm_state_change() gdbstub: add multiprocess support to 'D' packets gdbstub: add support for extended mode packet gdbstub: add support for vAttach packets gdbstub: processes initialization on new peer connection gdbstub: gdb_set_stop_cpu: ignore request when process is not attached gdbstub: add multiprocess extension support arm/xlnx-zynqmp: put APUs and RPUs in separate GDB groups include/hw/arm/xlnx-zynqmp.h | 3 + include/hw/cpu/cluster.h | 38 +++ gdbstub.c | 628 ++++++++++++++++++++++++++++++----- hw/arm/xlnx-zynqmp.c | 23 +- hw/cpu/cluster.c | 49 +++ hw/cpu/Makefile.objs | 2 +- 6 files changed, 662 insertions(+), 81 deletions(-) create mode 100644 include/hw/cpu/cluster.h create mode 100644 hw/cpu/cluster.c