[v2,0/2] Cleanup and locality range check

Message

Stefan Berger Dec. 3, 2018, 5:01 p.m. UTC

This series of patches removes an unnecessary parameter from tpm_tis_abort()
and adds a locality range check to tpm_tis_prep_abort().

   Stefan


Stefan Berger (2):
  tpm: Remove unused locty parameter from tpm_tis_abort()
  tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid

 hw/tpm/tpm_tis.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

[e-mail] Dec. 4, 2018, 1:28 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/2] Cleanup and locality range check
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8e798c4 tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid
b3dfcdf tpm: Remove unused locty parameter from tpm_tis_abort()

=== OUTPUT BEGIN ===
Checking PATCH 1/2: tpm: Remove unused locty parameter from tpm_tis_abort()...
Checking PATCH 2/2: tpm: Make sure new locality passed to tpm_tis_prep_abort() is valid...
ERROR: braces {} are necessary for all arms of this statement
#26: FILE: hw/tpm/tpm_tis.c:266:
+    if (!TPM_TIS_IS_VALID_LOCTY(newlocty))
[...]

total: 1 errors, 0 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]