From patchwork Fri Dec 7 11:53:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 10718023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81BC113BF for ; Fri, 7 Dec 2018 11:55:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 715E22B232 for ; Fri, 7 Dec 2018 11:55:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65C5E2B237; Fri, 7 Dec 2018 11:55:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 01AE32AB06 for ; Fri, 7 Dec 2018 11:55:41 +0000 (UTC) Received: from localhost ([::1]:45567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVEjM-0008EC-Ln for patchwork-qemu-devel@patchwork.kernel.org; Fri, 07 Dec 2018 06:55:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVEhg-0006xS-R3 for qemu-devel@nongnu.org; Fri, 07 Dec 2018 06:53:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVEhg-0004a8-2Y for qemu-devel@nongnu.org; Fri, 07 Dec 2018 06:53:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gVEhb-0004VT-Oa; Fri, 07 Dec 2018 06:53:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB71930013BF; Fri, 7 Dec 2018 11:53:50 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-248.ams2.redhat.com [10.36.117.248]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F56A6E713; Fri, 7 Dec 2018 11:53:49 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Date: Fri, 7 Dec 2018 12:53:38 +0100 Message-Id: <20181207115343.6747-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 07 Dec 2018 11:53:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 0/5] vmdk: Implement blockdev-create X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP I picked up the patch series from Fam and rebased it to current master (which involved a major rework on the test case) and tried to address Markus' review comments for v2. I did not do any further review of the actual code, but it passes the tests, so I guess having it in tree is better than continuing to let it bitrot. v4: - Use "legacyESX" in QAPI instead of "legacyesx" (requires an additional exception from the QAPI rules, but the string is directly written into the VMDK file, and "legacyESX" is the spelling in the spec). The QemuOpts based parser stays case sensitive in v4. [Markus] - Documentation fixes [Markus] - Added tests for adapter types - Added patch 5 to forbid excess extents in blockdev-create [Markus] Fam Zheng (3): vmdk: Refactor vmdk_create_extent vmdk: Implement .bdrv_co_create callback iotests: Filter cid numbers in VMDK extent info Kevin Wolf (2): iotests: Add VMDK tests for blockdev-create vmdk: Reject excess extents in blockdev-create qapi/block-core.json | 71 +++++ qapi/qapi-schema.json | 16 +- block/vmdk.c | 532 ++++++++++++++++++++++--------- tests/qemu-iotests/237 | 237 ++++++++++++++ tests/qemu-iotests/237.out | 348 ++++++++++++++++++++ tests/qemu-iotests/common.filter | 1 + tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 1 + 8 files changed, 1049 insertions(+), 158 deletions(-) create mode 100755 tests/qemu-iotests/237 create mode 100644 tests/qemu-iotests/237.out