[0/2] mmap-alloc: fix hugetlbfs misaligned length in ppc64

Message

Murilo Opsfelder Araújo Jan. 30, 2019, 11:36 p.m. UTC

The first patch unfolds parts of qemu_ram_mmap() to make it clearer.
No changes in the function behaviour.

The second one fixes the alignment of the length given to munmap().

I am pretty sure there is room for improvement, so I would love to
hear your feedback.

Thank you!

Murilo Opsfelder Araujo (2):
  mmap-alloc: unfold qemu_ram_mmap()
  mmap-alloc: fix hugetlbfs misaligned length in ppc64

 exec.c                    |  4 +--
 include/qemu/mmap-alloc.h |  2 +-
 util/mmap-alloc.c         | 73 ++++++++++++++++++++++++++-------------
 util/oslib-posix.c        |  2 +-
 4 files changed, 53 insertions(+), 28 deletions(-)

--
2.20.1

Comments

David Gibson Feb. 4, 2019, 12:08 a.m. UTC | #1

On Wed, Jan 30, 2019 at 09:36:03PM -0200, Murilo Opsfelder Araujo wrote:
> The first patch unfolds parts of qemu_ram_mmap() to make it clearer.
> No changes in the function behaviour.
> 
> The second one fixes the alignment of the length given to munmap().
> 
> I am pretty sure there is room for improvement, so I would love to
> hear your feedback.
> 
> Thank you!

Applied to ppc-for-4.0.

> 
> Murilo Opsfelder Araujo (2):
>   mmap-alloc: unfold qemu_ram_mmap()
>   mmap-alloc: fix hugetlbfs misaligned length in ppc64
> 
>  exec.c                    |  4 +--
>  include/qemu/mmap-alloc.h |  2 +-
>  util/mmap-alloc.c         | 73 ++++++++++++++++++++++++++-------------
>  util/oslib-posix.c        |  2 +-
>  4 files changed, 53 insertions(+), 28 deletions(-)
>

Murilo Opsfelder Araújo Feb. 4, 2019, 2:27 p.m. UTC | #2

On Mon, Feb 04, 2019 at 11:08:05AM +1100, David Gibson wrote:
> On Wed, Jan 30, 2019 at 09:36:03PM -0200, Murilo Opsfelder Araujo wrote:
> > The first patch unfolds parts of qemu_ram_mmap() to make it clearer.
> > No changes in the function behaviour.
> >
> > The second one fixes the alignment of the length given to munmap().
> >
> > I am pretty sure there is room for improvement, so I would love to
> > hear your feedback.
> >
> > Thank you!
>
> Applied to ppc-for-4.0.

Thank you all for reviewing and testing it.

I did appreciate!

--
Murilo