From patchwork Wed Feb 27 11:08:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 10831565 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 728E317EF for ; Wed, 27 Feb 2019 11:10:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53AD62CE61 for ; Wed, 27 Feb 2019 11:10:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 488512CE68; Wed, 27 Feb 2019 11:10:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EEBB22CE61 for ; Wed, 27 Feb 2019 11:10:40 +0000 (UTC) Received: from localhost ([127.0.0.1]:42116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyx6l-0001JJ-OM for patchwork-qemu-devel@patchwork.kernel.org; Wed, 27 Feb 2019 06:10:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyx5L-00006M-Nm for qemu-devel@nongnu.org; Wed, 27 Feb 2019 06:09:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyx5E-0002YP-BN for qemu-devel@nongnu.org; Wed, 27 Feb 2019 06:09:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58982) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyx59-0002U6-Pl for qemu-devel@nongnu.org; Wed, 27 Feb 2019 06:09:01 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2AA7820E9 for ; Wed, 27 Feb 2019 11:08:56 +0000 (UTC) Received: from localhost.localdomain (ovpn-117-2.ams2.redhat.com [10.36.117.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5EA917A94; Wed, 27 Feb 2019 11:08:52 +0000 (UTC) From: Juan Quintela To: qemu-devel@nongnu.org Date: Wed, 27 Feb 2019 12:08:04 +0100 Message-Id: <20190227110812.2185-1-quintela@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 27 Feb 2019 11:08:56 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 0/8] migration: Mark multifd not experimental X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Juan Quintela , Markus Armbruster , "Dr. David Alan Gilbert" , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP v3: - answer all comments from Dave - updates to latest upstream. v2: - Measure packet size in bytes/not pages - Change the defalut value from 64KB to 512KB - rename used field to pages_used - rename size field to pages_alloc - Create nnext_packet_size field Will be used on compression series later. - Be flexible about what packet sizes we allow. Please review, In v1: - Change page_count default to 128. 16 was really small, and it makes much less contention on mutexes to just have bigger packets. - Drop multifd-page_count parameter This parameter was useful for testing, but in all my testing 128 is good enough, no need to have an extra knob. Libvirt don't want to expose this parameter because it is difficult to explain. - Drop experimental "x-" from multifd Code is stable, nothing big is happening here. - Multifd test And a test for multifd, this test has already been on other patch series. But now it uses the names without "-x". Please review. Juan Quintela (8): multifd: Only send pages when packet are not empty multifd: Rename "size" member to pages_alloc multifd: Create new next_packet_size field multifd: Drop x-multifd-page-count parameter multifd: Be flexible about packet size multifd: Change default packet size multifd: Drop x- tests: Add migration multifd test hmp.c | 17 +++------ migration/migration.c | 56 +++++++----------------------- migration/migration.h | 1 - migration/ram.c | 79 ++++++++++++++++++++++++++++++------------ migration/trace-events | 4 +-- qapi/migration.json | 45 +++++++++--------------- tests/migration-test.c | 48 +++++++++++++++++++++++++ 7 files changed, 142 insertions(+), 108 deletions(-)