[RFCv2,0/2] tests/tcg: Vector instruction tests for target/s390x

Message

David Hildenbrand Feb. 27, 2019, 9:15 p.m. UTC

As I currently work on vector instruction support for s390x/tcg, for now
I wrote my tests for kvm-unit-tests, but tests/tcg seems to be a better fit.
The only tricky part is testing interrupt handling, but that also seems to
be possible using some signal hackery.

This is only one test to discuss if the approach make sense. These patches
only work when applied on top of:
    https://github.com/davidhildenbrand/qemu/tree/vx

Before I go ahead and implement more tests, let's clarify if this is the
way to go first.

RFC -> RFCv2:
- Dropped "tests/tcg: Allow targets to set the optimization level"
-- Handle it directly from the Makefile
- Add a test for VECTOR GATHER ELEMENT
- Rework signal handling to work with more than one signal occurrence. Also
  simplify setting the signal handlers a bit.

David Hildenbrand (2):
  tests/tcg: target/s390x: Test VECTOR GATHER ELEMENT
  tests/tcg: target/s390x: Test VECTOR LOAD GR FROM VR ELEMENT

 tests/tcg/s390x/Makefile.target     |  7 +++
 tests/tcg/s390x/helper.h            | 28 +++++++++++
 tests/tcg/s390x/signal-helper.inc.c | 46 ++++++++++++++++++
 tests/tcg/s390x/vge.c               | 75 +++++++++++++++++++++++++++++
 tests/tcg/s390x/vlgv.c              | 37 ++++++++++++++
 5 files changed, 193 insertions(+)
 create mode 100644 tests/tcg/s390x/helper.h
 create mode 100644 tests/tcg/s390x/signal-helper.inc.c
 create mode 100644 tests/tcg/s390x/vge.c
 create mode 100644 tests/tcg/s390x/vlgv.c

Comments

[e-mail] Feb. 27, 2019, 9:23 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH RFCv2 0/2] tests/tcg: Vector instruction tests for target/s390x
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
455444cf7e tests/tcg: target/s390x: Test VECTOR LOAD GR FROM VR ELEMENT
2fb17c4fd7 tests/tcg: target/s390x: Test VECTOR GATHER ELEMENT

=== OUTPUT BEGIN ===
1/2 Checking commit 2fb17c4fd731 (tests/tcg: target/s390x: Test VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

ERROR: use sigaction to establish signal handlers; signal is not portable
#106: FILE: tests/tcg/s390x/signal-helper.inc.c:36:
+    if (signal(SIGILL, handle_sigill) == SIG_ERR) {     \

total: 1 errors, 1 warnings, 152 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 455444cf7e30 (tests/tcg: target/s390x: Test VECTOR LOAD GR FROM VR ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 56 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]