[v2,00/12] pc: Support firmware configuration with -blockdev

Message

Markus Armbruster March 7, 2019, 5:23 p.m. UTC

Based-on: <[e-mail]>

v2:
* PATCH 05,06: New [Philippe]
* PATCH 07: Old PATCH 5 rebased onto new patches, with new comment
  [Philippe]
* PATCH 08+10: New, factored out of old PATCH 6 [by Philippe]
* PATCH 09: New [by Philippe]
* PATCH 11: Remainder of old PATCH 6, with FIXME resolved, literal
  4096 de-duplicated [László], extraneous error check deleted
  [László], and comment typos fixed
* PATCH 12: New

Markus Armbruster (9):
  qdev: Fix latent bug with compat_props and onboard devices
  qom: Move compat_props machinery from qdev to QOM
  vl: Fix latent bug with -global and onboard devices
  sysbus: Fix latent bug with onboard devices
  vl: Improve legibility of BlockdevOptions queue
  vl: Factor configure_blockdev() out of main()
  vl: Create block backends before setting machine properties
  pc: Support firmware configuration with -blockdev
  docs/interop/firmware.json: Prefer -machine to if=pflash

Philippe Mathieu-Daudé (3):
  pflash_cfi01: Add pflash_cfi01_get_blk() helper
  pc_sysfw: Remove unused PcSysFwDevice
  pc_sysfw: Pass PCMachineState to pc_system_firmware_init()

 accel/accel.c              |   1 +
 docs/interop/firmware.json |  21 +++-
 hw/block/pflash_cfi01.c    |   5 +
 hw/core/qdev.c             |  21 +---
 hw/core/sysbus.c           |   3 -
 hw/i386/pc.c               |   4 +-
 hw/i386/pc_sysfw.c         | 249 ++++++++++++++++++++++++-------------
 include/hw/block/flash.h   |   1 +
 include/hw/i386/pc.h       |   6 +-
 include/hw/qdev-core.h     |   2 -
 include/qom/object.h       |   3 +
 qom/object.c               |  39 ++++++
 vl.c                       | 122 +++++++++---------
 13 files changed, 301 insertions(+), 176 deletions(-)

Comments

[e-mail] March 7, 2019, 5:49 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
c1aaf3673d docs/interop/firmware.json: Prefer -machine to if=pflash
19a2070dbe pc: Support firmware configuration with -blockdev
b5c7b84c81 pc_sysfw: Pass PCMachineState to pc_system_firmware_init()
e1c257c048 pc_sysfw: Remove unused PcSysFwDevice
fcb857ab88 pflash_cfi01: Add pflash_cfi01_get_blk() helper
1a2edd22c2 vl: Create block backends before setting machine properties
45c492a1cd vl: Factor configure_blockdev() out of main()
a21a1d9db1 vl: Improve legibility of BlockdevOptions queue
e708802553 sysbus: Fix latent bug with onboard devices
dc3441282a vl: Fix latent bug with -global and onboard devices
2fe2cce7c2 qom: Move compat_props machinery from qdev to QOM
7b82947341 qdev: Fix latent bug with compat_props and onboard devices

=== OUTPUT BEGIN ===
1/12 Checking commit 7b829473415e (qdev: Fix latent bug with compat_props and onboard devices)
2/12 Checking commit 2fe2cce7c264 (qom: Move compat_props machinery from qdev to QOM)
3/12 Checking commit dc3441282af9 (vl: Fix latent bug with -global and onboard devices)
4/12 Checking commit e7088025536e (sysbus: Fix latent bug with onboard devices)
5/12 Checking commit a21a1d9db1b5 (vl: Improve legibility of BlockdevOptions queue)
6/12 Checking commit 45c492a1cde3 (vl: Factor configure_blockdev() out of main())
WARNING: Block comments use a leading /* on a separate line
#25: FILE: vl.c:1207:
+    /* If the currently selected machine wishes to override the units-per-bus

WARNING: Block comments use a trailing */ on a separate line
#26: FILE: vl.c:1208:
+     * property of its default HBA interface type, do so now. */

total: 0 errors, 2 warnings, 83 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit 1a2edd22c227 (vl: Create block backends before setting machine properties)
8/12 Checking commit fcb857ab88c7 (pflash_cfi01: Add pflash_cfi01_get_blk() helper)
9/12 Checking commit e1c257c04899 (pc_sysfw: Remove unused PcSysFwDevice)
10/12 Checking commit b5c7b84c8184 (pc_sysfw: Pass PCMachineState to pc_system_firmware_init())
11/12 Checking commit 19a2070dbe4a (pc: Support firmware configuration with -blockdev)
WARNING: line over 80 characters
#372: FILE: hw/i386/pc_sysfw.c:328:
+            error_report("pflash with kvm requires KVM readonly memory support");

total: 0 errors, 1 warnings, 315 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit c1aaf3673dbf (docs/interop/firmware.json: Prefer -machine to if=pflash)
ERROR: trailing whitespace
#49: FILE: docs/interop/firmware.json:239:
+#                  $

total: 1 errors, 0 warnings, 33 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] March 7, 2019, 6:29 p.m. UTC | #2

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
e159d1ed0d docs/interop/firmware.json: Prefer -machine to if=pflash
7b348eb438 pc: Support firmware configuration with -blockdev
2781f626cf pc_sysfw: Pass PCMachineState to pc_system_firmware_init()
5ed81089c8 pc_sysfw: Remove unused PcSysFwDevice
06dfc824b9 pflash_cfi01: Add pflash_cfi01_get_blk() helper
ac5ff6df76 vl: Create block backends before setting machine properties
4fd41657da vl: Factor configure_blockdev() out of main()
8e6aa0c7e8 vl: Improve legibility of BlockdevOptions queue
54f785aef6 sysbus: Fix latent bug with onboard devices
a74b064b72 vl: Fix latent bug with -global and onboard devices
004bf6fd7a qom: Move compat_props machinery from qdev to QOM
5f4c93ede2 qdev: Fix latent bug with compat_props and onboard devices

=== OUTPUT BEGIN ===
1/12 Checking commit 5f4c93ede2e9 (qdev: Fix latent bug with compat_props and onboard devices)
2/12 Checking commit 004bf6fd7af8 (qom: Move compat_props machinery from qdev to QOM)
3/12 Checking commit a74b064b72d7 (vl: Fix latent bug with -global and onboard devices)
4/12 Checking commit 54f785aef6ac (sysbus: Fix latent bug with onboard devices)
5/12 Checking commit 8e6aa0c7e85c (vl: Improve legibility of BlockdevOptions queue)
6/12 Checking commit 4fd41657da38 (vl: Factor configure_blockdev() out of main())
WARNING: Block comments use a leading /* on a separate line
#25: FILE: vl.c:1207:
+    /* If the currently selected machine wishes to override the units-per-bus

WARNING: Block comments use a trailing */ on a separate line
#26: FILE: vl.c:1208:
+     * property of its default HBA interface type, do so now. */

total: 0 errors, 2 warnings, 83 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit ac5ff6df764f (vl: Create block backends before setting machine properties)
8/12 Checking commit 06dfc824b9ea (pflash_cfi01: Add pflash_cfi01_get_blk() helper)
9/12 Checking commit 5ed81089c86b (pc_sysfw: Remove unused PcSysFwDevice)
10/12 Checking commit 2781f626cf40 (pc_sysfw: Pass PCMachineState to pc_system_firmware_init())
11/12 Checking commit 7b348eb43865 (pc: Support firmware configuration with -blockdev)
WARNING: line over 80 characters
#372: FILE: hw/i386/pc_sysfw.c:328:
+            error_report("pflash with kvm requires KVM readonly memory support");

total: 0 errors, 1 warnings, 315 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit e159d1ed0de2 (docs/interop/firmware.json: Prefer -machine to if=pflash)
ERROR: trailing whitespace
#49: FILE: docs/interop/firmware.json:239:
+#                  $

total: 1 errors, 0 warnings, 33 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] March 7, 2019, 6:46 p.m. UTC | #3

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
6c5d25d47a docs/interop/firmware.json: Prefer -machine to if=pflash
6067eed70b pc: Support firmware configuration with -blockdev
12eb362604 pc_sysfw: Pass PCMachineState to pc_system_firmware_init()
0681a43d40 pc_sysfw: Remove unused PcSysFwDevice
48fd47a85e pflash_cfi01: Add pflash_cfi01_get_blk() helper
ed5dc8dcd3 vl: Create block backends before setting machine properties
257e2ea345 vl: Factor configure_blockdev() out of main()
72732fcc5b vl: Improve legibility of BlockdevOptions queue
fbc43b7cdc sysbus: Fix latent bug with onboard devices
f9b5a0c27e vl: Fix latent bug with -global and onboard devices
3c85d24fe2 qom: Move compat_props machinery from qdev to QOM
a2cd7f244b qdev: Fix latent bug with compat_props and onboard devices

=== OUTPUT BEGIN ===
1/12 Checking commit a2cd7f244b98 (qdev: Fix latent bug with compat_props and onboard devices)
2/12 Checking commit 3c85d24fe25c (qom: Move compat_props machinery from qdev to QOM)
3/12 Checking commit f9b5a0c27e89 (vl: Fix latent bug with -global and onboard devices)
4/12 Checking commit fbc43b7cdc64 (sysbus: Fix latent bug with onboard devices)
5/12 Checking commit 72732fcc5b55 (vl: Improve legibility of BlockdevOptions queue)
6/12 Checking commit 257e2ea345c7 (vl: Factor configure_blockdev() out of main())
WARNING: Block comments use a leading /* on a separate line
#26: FILE: vl.c:1207:
+    /* If the currently selected machine wishes to override the units-per-bus

WARNING: Block comments use a trailing */ on a separate line
#27: FILE: vl.c:1208:
+     * property of its default HBA interface type, do so now. */

total: 0 errors, 2 warnings, 83 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit ed5dc8dcd393 (vl: Create block backends before setting machine properties)
8/12 Checking commit 48fd47a85ef9 (pflash_cfi01: Add pflash_cfi01_get_blk() helper)
9/12 Checking commit 0681a43d40ab (pc_sysfw: Remove unused PcSysFwDevice)
10/12 Checking commit 12eb3626047c (pc_sysfw: Pass PCMachineState to pc_system_firmware_init())
11/12 Checking commit 6067eed70b5c (pc: Support firmware configuration with -blockdev)
WARNING: line over 80 characters
#372: FILE: hw/i386/pc_sysfw.c:328:
+            error_report("pflash with kvm requires KVM readonly memory support");

total: 0 errors, 1 warnings, 315 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit 6c5d25d47a92 (docs/interop/firmware.json: Prefer -machine to if=pflash)
ERROR: trailing whitespace
#49: FILE: docs/interop/firmware.json:239:
+#                  $

total: 1 errors, 0 warnings, 33 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] March 8, 2019, 8:17 a.m. UTC | #4

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
b8003b82de docs/interop/firmware.json: Prefer -machine to if=pflash
4694b306ec pc: Support firmware configuration with -blockdev
93bc292290 pc_sysfw: Pass PCMachineState to pc_system_firmware_init()
c3d5fb15cd pc_sysfw: Remove unused PcSysFwDevice
3787c376e2 pflash_cfi01: Add pflash_cfi01_get_blk() helper
4fbc3cfda2 vl: Create block backends before setting machine properties
63a9dfee66 vl: Factor configure_blockdev() out of main()
5578280abb vl: Improve legibility of BlockdevOptions queue
0fddf3eb0e sysbus: Fix latent bug with onboard devices
915ec2186e vl: Fix latent bug with -global and onboard devices
a6cf369849 qom: Move compat_props machinery from qdev to QOM
facb673f93 qdev: Fix latent bug with compat_props and onboard devices

=== OUTPUT BEGIN ===
1/12 Checking commit facb673f9389 (qdev: Fix latent bug with compat_props and onboard devices)
2/12 Checking commit a6cf3698492d (qom: Move compat_props machinery from qdev to QOM)
3/12 Checking commit 915ec2186e86 (vl: Fix latent bug with -global and onboard devices)
4/12 Checking commit 0fddf3eb0e35 (sysbus: Fix latent bug with onboard devices)
5/12 Checking commit 5578280abbef (vl: Improve legibility of BlockdevOptions queue)
6/12 Checking commit 63a9dfee6675 (vl: Factor configure_blockdev() out of main())
WARNING: Block comments use a leading /* on a separate line
#26: FILE: vl.c:1207:
+    /* If the currently selected machine wishes to override the units-per-bus

WARNING: Block comments use a trailing */ on a separate line
#27: FILE: vl.c:1208:
+     * property of its default HBA interface type, do so now. */

total: 0 errors, 2 warnings, 83 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit 4fbc3cfda201 (vl: Create block backends before setting machine properties)
8/12 Checking commit 3787c376e2ce (pflash_cfi01: Add pflash_cfi01_get_blk() helper)
9/12 Checking commit c3d5fb15cd25 (pc_sysfw: Remove unused PcSysFwDevice)
10/12 Checking commit 93bc29229007 (pc_sysfw: Pass PCMachineState to pc_system_firmware_init())
11/12 Checking commit 4694b306ec66 (pc: Support firmware configuration with -blockdev)
WARNING: line over 80 characters
#372: FILE: hw/i386/pc_sysfw.c:328:
+            error_report("pflash with kvm requires KVM readonly memory support");

total: 0 errors, 1 warnings, 315 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit b8003b82deab (docs/interop/firmware.json: Prefer -machine to if=pflash)
ERROR: trailing whitespace
#49: FILE: docs/interop/firmware.json:239:
+#                  $

total: 1 errors, 0 warnings, 33 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] March 8, 2019, 8:26 a.m. UTC | #5

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v2 00/12] pc: Support firmware configuration with -blockdev

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
3ea929de65 docs/interop/firmware.json: Prefer -machine to if=pflash
b2f120dc53 pc: Support firmware configuration with -blockdev
e20c52727e pc_sysfw: Pass PCMachineState to pc_system_firmware_init()
d51f290e9e pc_sysfw: Remove unused PcSysFwDevice
96565445f8 pflash_cfi01: Add pflash_cfi01_get_blk() helper
bb44a08024 vl: Create block backends before setting machine properties
3806557e1f vl: Factor configure_blockdev() out of main()
984f18284e vl: Improve legibility of BlockdevOptions queue
ee5d063c25 sysbus: Fix latent bug with onboard devices
1e5f89d716 vl: Fix latent bug with -global and onboard devices
19954ff0fa qom: Move compat_props machinery from qdev to QOM
27f1c4f184 qdev: Fix latent bug with compat_props and onboard devices

=== OUTPUT BEGIN ===
1/12 Checking commit 27f1c4f18410 (qdev: Fix latent bug with compat_props and onboard devices)
2/12 Checking commit 19954ff0fa94 (qom: Move compat_props machinery from qdev to QOM)
3/12 Checking commit 1e5f89d716e8 (vl: Fix latent bug with -global and onboard devices)
4/12 Checking commit ee5d063c25a6 (sysbus: Fix latent bug with onboard devices)
5/12 Checking commit 984f18284e05 (vl: Improve legibility of BlockdevOptions queue)
6/12 Checking commit 3806557e1f00 (vl: Factor configure_blockdev() out of main())
WARNING: Block comments use a leading /* on a separate line
#26: FILE: vl.c:1207:
+    /* If the currently selected machine wishes to override the units-per-bus

WARNING: Block comments use a trailing */ on a separate line
#27: FILE: vl.c:1208:
+     * property of its default HBA interface type, do so now. */

total: 0 errors, 2 warnings, 83 lines checked

Patch 6/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/12 Checking commit bb44a0802451 (vl: Create block backends before setting machine properties)
8/12 Checking commit 96565445f821 (pflash_cfi01: Add pflash_cfi01_get_blk() helper)
9/12 Checking commit d51f290e9e75 (pc_sysfw: Remove unused PcSysFwDevice)
10/12 Checking commit e20c52727e5d (pc_sysfw: Pass PCMachineState to pc_system_firmware_init())
11/12 Checking commit b2f120dc5319 (pc: Support firmware configuration with -blockdev)
WARNING: line over 80 characters
#373: FILE: hw/i386/pc_sysfw.c:328:
+            error_report("pflash with kvm requires KVM readonly memory support");

total: 0 errors, 1 warnings, 315 lines checked

Patch 11/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/12 Checking commit 3ea929de6531 (docs/interop/firmware.json: Prefer -machine to if=pflash)
ERROR: trailing whitespace
#49: FILE: docs/interop/firmware.json:239:
+#                  $

total: 1 errors, 0 warnings, 33 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] March 9, 2019, 12:56 a.m. UTC | #6

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      hw/char/nrf51_uart.o
  CC      hw/char/parallel.o
/tmp/qemu-test/src/hw/block/pflash_cfi02.c: In function 'pflash_cfi02_unrealize':
/tmp/qemu-test/src/hw/block/pflash_cfi02.c:698:5: error: unknown type name 'pflash_t'; did you mean 'fpos_t'?
     pflash_t *pfl = CFI_PFLASH02(dev);
     ^~~~~~~~
     fpos_t
/tmp/qemu-test/src/hw/block/pflash_cfi02.c:698:21: error: implicit declaration of function 'CFI_PFLASH02'; did you mean 'HW_FLASH_H'? [-Werror=implicit-function-declaration]
     pflash_t *pfl = CFI_PFLASH02(dev);
                     ^~~~~~~~~~~~
                     HW_FLASH_H
/tmp/qemu-test/src/hw/block/pflash_cfi02.c:698:21: error: nested extern declaration of 'CFI_PFLASH02' [-Werror=nested-externs]
/tmp/qemu-test/src/hw/block/pflash_cfi02.c:698:21: error: initialization of 'int *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
/tmp/qemu-test/src/hw/block/pflash_cfi02.c:699:19: error: request for member 'timer' in something not a structure or union
     timer_del(&pfl->timer);
                   ^~
cc1: all warnings being treated as errors


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]