Message ID | 20190314131049.23175-1-marcandre.lureau@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | slirp: clarify license of slirp as BSD-3 | expand |
On 3/14/19 8:19 AM, Samuel Thibault wrote: > Hello, > > Should this go through my tree, or perhaps it can be directly pushed to > master by Peter since it's no-code-only-copyright changes? I think this definitely qualifies as 4.0 material. However, while it does not affect compilation, it DOES have legal ramification; I'd feel a lot better about having R-b on every patch, that we had a second (or third) set of eyes double-check that the right SPDX identifier is used everywhere. I don't have time to complete that audit today, so I'm hoping someone else will step in and help. (This is complicated by the fact that the email alone does not show the existing license; it may be easier to apply the patch locally, and then use git diff tuned to give a 20 or 30 line context instead of the usual default of 3, to make it easier to check for SPDX match to existing licenses on each file being modified) And thanks, Marc-André, for bearing with my nit-pickiness on this series. I hope you agree with my insistence that we get this right, so that we don't expose ourselves to legal troubles down the road. I like the split in this series, even if I have not had time to finish an audit that the changes in 3-6 are correct.
On 3/14/19 8:10 AM, Marc-André Lureau wrote: > Hi, > > In order to make slirp a standalone project, the project must have a > clear license, and be compatible with the GPL or LGPL. > > Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the > advertising clause from the slirp license"), slirp is BSD-3. But new > files have been added under slirp/ with QEMU GPL license since then. > > v3: > - add preliminary "slirp: update COPYRIGHT to use full 3-Clause BSD > License" > - split "slirp: clarify license of slirp files using SPDX" patch, > - fix SPDX for files with MIT license header > - add r-b tags, wording/spelling changes > > v2: > - split the initial patch to add BSD-3 header & then SPDX lines > - do not modify existing copyright headers without copyright holder > authorization > - drop the weak/ambiguous notice to the COPYRIGHT file > - added a RFC patch to remove Kelly Price from the maintainer duties > > Marc-André Lureau (8): > slirp: update COPYRIGHT to use full 3-Clause BSD License > slirp: relicense GPL files to BSD-3 > slirp: clarify license of slirp files using SPDX > slirp: clarify license of slirp files using SPDX > slirp: clarify license of slirp files using SPDX > slirp: clarify license of slirp files using SPDX Minor nit: This is four patches with identical subject, which makes backports harder. If you have a reason to respin, titling them something like: slirp: clarify license of slirp files using SPDX: explicit BSD slirp: clarify license of slirp files using SPDX: explicit MIT slirp: clarify license of slirp files using SPDX: implicit via COPYING slirp: clarify license of slirp files using SPDX: implicit via unstated may help.
Eric Blake, le jeu. 14 mars 2019 08:44:06 -0500, a ecrit: > However, while it does not affect compilation, it DOES have legal > ramification; I'd feel a lot better about having R-b on every patch, Sure, I was just asking for the git commit path :) I don't think it's useful to make it go through my tree. Samuel