[0/3] Fixes for PulseAudio driver

Message

Martin Schrodt March 14, 2019, 1:38 p.m. UTC

This series scratches small itches with the pa audio driver.

First patch is probably a bug introduced in last weeks -audiodev
merge. The configured buffer length was ignored by the code, and
a constant value was used instead.

Second patch makes the latency configurable: The 10ms constant value
did not work on my machine (caused both guest and host audio to 
malfunction), so I made it configurable, and set a 
default of 15ms, which is fine here.

Third patch fixes a long time problem with microphone input having 
half a minute (not kidding) delay. 

Is there a chance this still gets included in 4.0? If that's the case
I'd make a post on Reddit's VFIO section to find some testers, to see
if the defaults work.

Martin Schrodt (3):
  fix: buffer_length is ignored
  make latency configurable
  fix input lag

 audio/paaudio.c | 45 +++++++++++++++++++++++++++++++--------------
 qapi/audio.json |  5 ++++-
 2 files changed, 35 insertions(+), 15 deletions(-)

Comments

[e-mail] March 14, 2019, 4:12 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH 0/3] Fixes for PulseAudio driver

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/[e-mail] -> patchew/[e-mail]
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
error: The last gc run reported the following. Please correct the root cause
and remove gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.

Switched to a new branch 'test'
b7827a72a1 fix input lag
106b8421eb make latency configurable
7031adbc77 fix: buffer_length is ignored

=== OUTPUT BEGIN ===
1/3 Checking commit 7031adbc7770 (fix: buffer_length is ignored)
WARNING: line over 80 characters
#19: FILE: audio/paaudio.c:580:
+        qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, ppdo->buffer_length);

WARNING: line over 80 characters
#28: FILE: audio/paaudio.c:640:
+        qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, ppdo->buffer_length);

ERROR: line over 90 characters
#37: FILE: audio/paaudio.c:812:
+static int qpa_validate_per_direction_opts (Audiodev *dev, AudiodevPaPerDirectionOptions *pdo)

ERROR: space prohibited between function name and open parenthesis '('
#37: FILE: audio/paaudio.c:812:
+static int qpa_validate_per_direction_opts (Audiodev *dev, AudiodevPaPerDirectionOptions *pdo)

total: 2 errors, 2 warnings, 45 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit 106b8421eb44 (make latency configurable)
ERROR: space prohibited between function name and open parenthesis '('
#41: FILE: audio/paaudio.c:548:
+    ba.tlength = pa_usec_to_bytes (ppdo->latency, &ss);

total: 1 errors, 0 warnings, 58 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit b7827a72a1d6 (fix input lag)
ERROR: space prohibited between function name and open parenthesis '('
#26: FILE: audio/paaudio.c:614:
+    ba.fragsize = pa_usec_to_bytes (ppdo->latency, &ss);

total: 1 errors, 0 warnings, 26 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]