[V4,0/3] Fixes for PulseAudio driver

Message

Martin Schrodt March 15, 2019, 8:46 a.m. UTC

Version 2 of the series added proper commit messages 
and fixed a typo.

Version 3 fixes coding style problems

Version 4 reintroduces the check, whether PA support adjusting
latency, and sets the default buffer_length to the constant value
that was present beforehand (works well, and testing revealed that 
having a longer buffer does not hurt, so it's propably better to 
not make it artificially short when the user chooses shorter 
timer periods)

Martin Schrodt (3):
  audio/paaudio: fix ignored buffer_length setting
  audio/paaudio: prolong and make latency configurable
  audio/paaudio: fix microphone input being unusable

 audio/paaudio.c | 44 ++++++++++++++++++++++++++++++++++----------
 qapi/audio.json |  6 +++++-
 2 files changed, 39 insertions(+), 11 deletions(-)

Comments

Gerd Hoffmann March 18, 2019, 12:07 p.m. UTC | #1

On Fri, Mar 15, 2019 at 09:46:50AM +0100, Martin Schrodt wrote:
> Version 2 of the series added proper commit messages 
> and fixed a typo.
> 
> Version 3 fixes coding style problems
> 
> Version 4 reintroduces the check, whether PA support adjusting
> latency, and sets the default buffer_length to the constant value
> that was present beforehand (works well, and testing revealed that 
> having a longer buffer does not hurt, so it's propably better to 
> not make it artificially short when the user chooses shorter 
> timer periods)
> 
> Martin Schrodt (3):
>   audio/paaudio: fix ignored buffer_length setting
>   audio/paaudio: prolong and make latency configurable
>   audio/paaudio: fix microphone input being unusable

Added to audio queue.

thanks,
  Gerd