[v2,0/3] qemu-img: removing created when img_create fails

Message

Daniel Henrique Barboza March 22, 2019, 5:52 p.m. UTC

This is a patch series that follows up the patch [1] after
the review from Daniel P. Berrange.

The new interface is being implemented only by the LUKS driver
because this is the error condition I'm trying to fix. My first
idea when coding it was to implement this interface in all drivers
that deals with local files, but I thought it would be overkill -
at least for this second spin.


[1] https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05899.html


Daniel Henrique Barboza (3):
  block: introducing 'bdrv_co_delete_file' interface
  block.c: adding bdrv_delete_file
  qemu-img.c: clean up created file on img_create failure

 block.c                   | 117 ++++++++++++++++++++++++++++++++++++++
 block/crypto.c            |   2 +
 include/block/block.h     |   6 ++
 include/block/block_int.h |   6 ++
 qemu-img.c                |  29 +++++++++-
 5 files changed, 159 insertions(+), 1 deletion(-)

Comments

[e-mail] March 22, 2019, 7:02 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      aarch64-softmmu/tcg/tcg-op.o
  CC      aarch64-softmmu/tcg/tcg-op-vec.o
/tmp/qemu-test/src/qemu-img.c: In function 'img_create':
/tmp/qemu-test/src/qemu-img.c:568:13: error: 'filename' may be used uninitialized in this function [-Werror=maybe-uninitialized]
             error_reportf_err(local_err, "%s: ", filename);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

Daniel Henrique Barboza March 22, 2019, 9:49 p.m. UTC | #2

On 3/22/19 4:02 PM, [e-mail] wrote:
> Patchew URL: https://patchew.org/QEMU/[e-mail]/
>
>
>
> Hi,
>
> This series failed the docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1
> === TEST SCRIPT END ===
>
>    CC      aarch64-softmmu/tcg/tcg-op.o
>    CC      aarch64-softmmu/tcg/tcg-op-vec.o
> /tmp/qemu-test/src/qemu-img.c: In function 'img_create':
> /tmp/qemu-test/src/qemu-img.c:568:13: error: 'filename' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>               error_reportf_err(local_err, "%s: ", filename);
>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Not sure why it complained about this. Travis didn't care ....


How can I reproduce this docker use test? I have a Fedora29 box with 
Docker and
issuing "make docker-test-mingw(...)" as mentioned above doesn't work.


Thanks,


dhb

>
> The full log is available at
> http://patchew.org/logs/[e-mail]/testing.docker-mingw@fedora/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to [e-mail]

Wainer dos Santos Moschetta March 25, 2019, 2:02 p.m. UTC | #3

On 03/22/2019 06:49 PM, Daniel Henrique Barboza wrote:
>
>
> On 3/22/19 4:02 PM, [e-mail] wrote:
>> Patchew URL: 
>> https://patchew.org/QEMU/[e-mail]/
>>
>>
>>
>> Hi,
>>
>> This series failed the docker-mingw@fedora build test. Please find 
>> the testing commands and
>> their output below. If you have Docker installed, you can probably 
>> reproduce it
>> locally.
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>> time make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1
>> === TEST SCRIPT END ===
>>
>>    CC      aarch64-softmmu/tcg/tcg-op.o
>>    CC      aarch64-softmmu/tcg/tcg-op-vec.o
>> /tmp/qemu-test/src/qemu-img.c: In function 'img_create':
>> /tmp/qemu-test/src/qemu-img.c:568:13: error: 'filename' may be used 
>> uninitialized in this function [-Werror=maybe-uninitialized]
>>               error_reportf_err(local_err, "%s: ", filename);
>>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> cc1: all warnings being treated as errors
>
> Not sure why it complained about this. Travis didn't care ....
>
>
> How can I reproduce this docker use test? I have a Fedora29 box with 
> Docker and
> issuing "make docker-test-mingw(...)" as mentioned above doesn't work.


I could reproduce the above error on my Fedora 29 x86_64 machine. From 
the build dir, run as:

make docker-test-mingw@fedora SHOW_ENV=1 J=14 NETWORK=1

Compile QEMU sources with default configs also fails.

- Wainer

>
>
>
> Thanks,
>
>
> dhb
>
>>
>> The full log is available at
>> http://patchew.org/logs/[e-mail]/testing.docker-mingw@fedora/?type=message. 
>>
>> ---
>> Email generated automatically by Patchew [https://patchew.org/].
>> Please send your feedback to [e-mail]
>
>