[for-4.0,0/2] file-posix: query-qemu-features for auto-read-only

Message

Kevin Wolf March 28, 2019, 6:28 p.m. UTC

auto-read-only=on changed its behaviour in file-posix for the 4.0
release. This change cannot be detected through the usual mechanisms
like schema introspection.

I took Stefan's patch 'qmp: add query-qemu-capabilities', removed the
feature that he originally wanted this for and addressed the review
comments. The introduction of the file-posix-dynamic-auto-read-only
feature is a separate patch.

Stefan, I kept you as the author of the first patch and also your
Signed-off-by. Is this okay with you or would you prefer a change?

Kevin Wolf (1):
  Add file-posix-dynamic-auto-read-only feature

Stefan Hajnoczi (1):
  qmp: Add query-qemu-features

 qapi/misc.json | 28 ++++++++++++++++++++++++++++
 qmp.c          | 11 +++++++++++
 2 files changed, 39 insertions(+)

Comments

Stefan Hajnoczi April 5, 2019, 10:32 a.m. UTC | #1

On Thu, Mar 28, 2019 at 07:28:08PM +0100, Kevin Wolf wrote:
> auto-read-only=on changed its behaviour in file-posix for the 4.0
> release. This change cannot be detected through the usual mechanisms
> like schema introspection.
> 
> I took Stefan's patch 'qmp: add query-qemu-capabilities', removed the
> feature that he originally wanted this for and addressed the review
> comments. The introduction of the file-posix-dynamic-auto-read-only
> feature is a separate patch.
> 
> Stefan, I kept you as the author of the first patch and also your
> Signed-off-by. Is this okay with you or would you prefer a change?

Sorry I was unresponsive.  I'm fine with the authorship and
Signed-off-by: but won't be offended if either or both are removed when
the patch is reworked (my code is trivial).

Stefan

Kevin Wolf April 5, 2019, 12:46 p.m. UTC | #2

Am 05.04.2019 um 12:32 hat Stefan Hajnoczi geschrieben:
> On Thu, Mar 28, 2019 at 07:28:08PM +0100, Kevin Wolf wrote:
> > auto-read-only=on changed its behaviour in file-posix for the 4.0
> > release. This change cannot be detected through the usual mechanisms
> > like schema introspection.
> > 
> > I took Stefan's patch 'qmp: add query-qemu-capabilities', removed the
> > feature that he originally wanted this for and addressed the review
> > comments. The introduction of the file-posix-dynamic-auto-read-only
> > feature is a separate patch.
> > 
> > Stefan, I kept you as the author of the first patch and also your
> > Signed-off-by. Is this okay with you or would you prefer a change?
> 
> Sorry I was unresponsive.  I'm fine with the authorship and
> Signed-off-by: but won't be offended if either or both are removed when
> the patch is reworked (my code is trivial).

The plan is now that we integrate features in the QAPI schema (attached
to struct definitions), so they will be available with the normal schema
introspection. Obviously, this will be a completely new patch series
that isn't based on this patch any more.

Kevin