mbox series

[v2,0/4] Extract build_mcfg

Message ID 20190415070307.13668-1-richardw.yang@linux.intel.com (mailing list archive)
Headers show
Series Extract build_mcfg | expand

Message

Wei Yang April 15, 2019, 7:03 a.m. UTC
This patch set tries to generalize MCFG table build process.

Wei Yang (4):
  hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start
  i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members
  hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg()
  hw/acpi: Extract build_mcfg to pci.c

 default-configs/arm-softmmu.mak  |  1 +
 default-configs/i386-softmmu.mak |  1 +
 hw/acpi/Kconfig                  |  4 +++
 hw/acpi/Makefile.objs            |  1 +
 hw/acpi/pci.c                    | 46 ++++++++++++++++++++++++++++++++
 hw/arm/virt-acpi-build.c         | 31 ++++++---------------
 hw/i386/acpi-build.c             | 30 ++++-----------------
 include/hw/acpi/aml-build.h      |  5 ++++
 include/hw/acpi/pci.h            |  5 ++++
 9 files changed, 76 insertions(+), 48 deletions(-)
 create mode 100644 hw/acpi/pci.c
 create mode 100644 include/hw/acpi/pci.h

Comments

Igor Mammedov April 15, 2019, 2:20 p.m. UTC | #1
On Mon, 15 Apr 2019 15:03:03 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:

> This patch set tries to generalize MCFG table build process.

1.
series should reference not merged  dependency if any exists.
in this case "[PATCH for-4.1] q35: acpi: do not create dummy MCFG table"
or as alternative include and repost that patch as part of the series.

if you'd do the later then add your SoB last when you are reposting it.

2. series is not finished without converting build_mcfg() to
   build_append_int_noprefix() API


> Wei Yang (4):
>   hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start
>   i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members
>   hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg()
>   hw/acpi: Extract build_mcfg to pci.c
> 
>  default-configs/arm-softmmu.mak  |  1 +
>  default-configs/i386-softmmu.mak |  1 +
>  hw/acpi/Kconfig                  |  4 +++
>  hw/acpi/Makefile.objs            |  1 +
>  hw/acpi/pci.c                    | 46 ++++++++++++++++++++++++++++++++
>  hw/arm/virt-acpi-build.c         | 31 ++++++---------------
>  hw/i386/acpi-build.c             | 30 ++++-----------------
>  include/hw/acpi/aml-build.h      |  5 ++++
>  include/hw/acpi/pci.h            |  5 ++++
>  9 files changed, 76 insertions(+), 48 deletions(-)
>  create mode 100644 hw/acpi/pci.c
>  create mode 100644 include/hw/acpi/pci.h
>