[v4,0/3] hw: edu: some fixes

Message

Li Qiang May 10, 2019, 4:43 p.m. UTC

Recently I am considering write a driver for edu device.
After reading the spec, I found these three small issue.
Two first two related the MMIO access and the third is
related the DMA operation.

Change since v2:
Fix an error in patch 2
Fix some commit message and title.

Change since v1:
Fix format compile error

Li Qiang (3):
  edu: mmio: allow 64-bit access
  edu: mmio: allow 64-bit access in read dispatch
  edu: uses uint64_t in dma operation

 hw/misc/edu.c | 32 +++++++++++++++++++++++---------
 1 file changed, 23 insertions(+), 9 deletions(-)

Comments

Peter Xu May 10, 2019, 11:53 p.m. UTC | #1

On Fri, May 10, 2019 at 09:43:46AM -0700, Li Qiang wrote:
> Recently I am considering write a driver for edu device.

I don't know why you wanted to write it, but there's one (though I
don't even remember whether it's working or not)...

https://github.com/xzpeter/clibs/blob/master/gpl/linux_kernel/edu_device_driver/edu.c

Regards,

Li Qiang May 11, 2019, 12:40 a.m. UTC | #2

Peter Xu <[e-mail]> 于2019年5月11日周六 上午7:53写道：

> On Fri, May 10, 2019 at 09:43:46AM -0700, Li Qiang wrote:
> > Recently I am considering write a driver for edu device.
>
> I don't know why you wanted to write it, but there's one (though I
> don't even remember whether it's working or not)...
>
>
This is a simple device, once I used it to debug and  make clear some
hardware-related stuff of PCI device,
such as PCI interrupt routing, interrupt linking device, interrupt raise
and the process of injecting.
I think if there is a driver, I can do this inspection more easily.



>
> https://github.com/xzpeter/clibs/blob/master/gpl/linux_kernel/edu_device_driver/edu.c
>
>

Great!

Thanks,
Li Qiang



> Regards,
>
> --
> Peter Xu
>

Li Qiang May 21, 2019, 1:30 p.m. UTC | #3

Ping....

Paolo, could you merge these to your misc tree?

Thanks,
Li Qiang

Li Qiang <[e-mail]> 于2019年5月11日周六 上午12:44写道：

> Recently I am considering write a driver for edu device.
> After reading the spec, I found these three small issue.
> Two first two related the MMIO access and the third is
> related the DMA operation.
>
> Change since v2:
> Fix an error in patch 2
> Fix some commit message and title.
>
> Change since v1:
> Fix format compile error
>
> Li Qiang (3):
>   edu: mmio: allow 64-bit access
>   edu: mmio: allow 64-bit access in read dispatch
>   edu: uses uint64_t in dma operation
>
>  hw/misc/edu.c | 32 +++++++++++++++++++++++---------
>  1 file changed, 23 insertions(+), 9 deletions(-)
>
> --
> 2.17.1
>
>
>

Paolo Bonzini May 22, 2019, 8:29 a.m. UTC | #4

On 21/05/19 15:30, Li Qiang wrote:
> Ping....
> 
> Paolo, could you merge these to your misc tree?

Queued now, thanks.

Paolo

> Thanks,
> Li Qiang
> 
> Li Qiang <[e-mail] <mailto:[e-mail]>> 于2019年5月11日周六 上
> 午12:44写道：
> 
>     Recently I am considering write a driver for edu device.
>     After reading the spec, I found these three small issue.
>     Two first two related the MMIO access and the third is
>     related the DMA operation.
> 
>     Change since v2:
>     Fix an error in patch 2
>     Fix some commit message and title.
> 
>     Change since v1:
>     Fix format compile error
> 
>     Li Qiang (3):
>       edu: mmio: allow 64-bit access
>       edu: mmio: allow 64-bit access in read dispatch
>       edu: uses uint64_t in dma operation
> 
>      hw/misc/edu.c | 32 +++++++++++++++++++++++---------
>      1 file changed, 23 insertions(+), 9 deletions(-)
> 
>     -- 
>     2.17.1
> 
>