[0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation.

Message

Gerd Hoffmann May 22, 2019, 9:23 a.m. UTC

Gerd Hoffmann (5):
  usb-hub: tweak feature names
  usb-hub: make number of ports runtime-configurable
  usb-hub: add helpers to update port state
  usb-hub: add usb_hub_port_update()
  usb-hub: emulate per port power switching

 hw/usb/dev-hub.c | 221 +++++++++++++++++++++++++++++++++--------------
 1 file changed, 154 insertions(+), 67 deletions(-)

Comments

[e-mail] May 22, 2019, 9:53 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation.
Type: series
Message-id: [e-mail]

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
ca1f600 usb-hub: emulate per port power switching
7ca7d0c usb-hub: add usb_hub_port_update()
f8d5edc usb-hub: add helpers to update port state
5671fd2 usb-hub: make number of ports runtime-configurable
654be68 usb-hub: tweak feature names

=== OUTPUT BEGIN ===
1/5 Checking commit 654be6887a12 (usb-hub: tweak feature names)
2/5 Checking commit 5671fd2cef1b (usb-hub: make number of ports runtime-configurable)
ERROR: space required before the open parenthesis '('
#125: FILE: hw/usb/dev-hub.c:493:
+            for(i = 0; i < s->num_ports; i++) {

total: 1 errors, 0 warnings, 154 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit f8d5edcfbf49 (usb-hub: add helpers to update port state)
4/5 Checking commit 7ca7d0cc1fab (usb-hub: add usb_hub_port_update())
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 47 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit ca1f600a391e (usb-hub: emulate per port power switching)
ERROR: spaces required around that '*' (ctx:VxV)
#145: FILE: hw/usb/dev-hub.c:658:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 0 warnings, 128 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]