| Message ID | 20190522162252.28568-1-shameerali.kolothum.thodi@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM virt: ACPI memory hotplug support | expand |
Hi Shameer, On 5/22/19 6:22 PM, Shameer Kolothum wrote: > This series is an attempt to provide device memory hotplug support > on ARM virt platform. This is based on Eric's recent works here[1] > and carries some of the pc-dimm related patches dropped from his > series. > > The kernel support for arm64 memory hot add was added recently by > Robin and hence the guest kernel should be => 5.0-rc1. > > NVDIM support is not included currently as we still have an unresolved > issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches > can be included, but not done for now, for keeping it simple. > > This makes use of GED device to sent hotplug ACPI events to the > Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and > Sebastien to add the hardware-reduced support to Nemu using GED > device[3]. (Please shout if I got the author/signed-off wrong for > those patches or missed any names). > > This is sanity tested on a HiSilicon ARM64 platform and appreciate > any further testing. I tested cold-plug and hot-plug of PCDIMM slots. I also tested system_powerdown and system_reset. The series has minor conflicts with master. Feel free to add my T-b on next version: Tested-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > > Thanks, > Shameer > > [1] https://patchwork.kernel.org/cover/10837565/ > [2] https://patchwork.kernel.org/cover/10783589/ > [3] https://github.com/intel/nemu/blob/topic/virt-x86/hw/acpi/ged.c > [4] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-May/651763.html > > v4 --> v5 > -Removed gsi/ged-irq routing in virt. > -Added Migration support. > -Dropped support for DT coldplug case based on the discussions > here[4] > -Added system_powerdown support through GED. > > v3 --> v4 > Addressed comments from Igor and Eric, > -Renamed "virt-acpi" to "acpi-ged". > -Changed ged device parent to TYPE_DEVICE. > -Introduced DT memory node property "hotpluggable" to resolve device > memory being treated as early boot memory issue(patch #7). > -Combined patches #3 and #9 from v3 into #3. > > v2 --> v3 > > Addressed comments from Igor and Eric, > -Made virt acpi device platform independent and moved > to hw/acpi/generic_event_device.c > -Moved ged specific code into hw/acpi/generic_event_device.c > -Introduced an opt-in feature "fdt" to resolve device-memory being > treated as early boot memory. > -Dropped patch #1 from v2. > > RFC --> v2 > > -Use GED device instead of GPIO for ACPI hotplug events. > -Removed NVDIMM support for now. > -Includes dropped patches from Eric's v9 series. > > Eric Auger (1): > hw/arm/virt: Add memory hotplug framework > > Samuel Ortiz (2): > hw/acpi: Do not create memory hotplug method when handler is not > defined > hw/acpi: Add ACPI Generic Event Device Support > > Shameer Kolothum (5): > hw/acpi: Make ACPI IO address space configurable > hw/arm/virt: Enable device memory cold/hot plug with ACPI boot > hw/arm/virt-acpi-build: Add PC-DIMM in SRAT > hw/acpi: Add system power down support to GED > hw/arm: Use GED for system_powerdown event > > hw/acpi/Kconfig | 4 + > hw/acpi/Makefile.objs | 1 + > hw/acpi/generic_event_device.c | 348 +++++++++++++++++++++++++ > hw/acpi/memory_hotplug.c | 35 +-- > hw/arm/Kconfig | 4 + > hw/arm/virt-acpi-build.c | 58 ++--- > hw/arm/virt.c | 88 ++++++- > hw/i386/acpi-build.c | 3 +- > include/hw/acpi/generic_event_device.h | 106 ++++++++ > include/hw/acpi/memory_hotplug.h | 9 +- > include/hw/arm/virt.h | 3 + > 11 files changed, 603 insertions(+), 56 deletions(-) > create mode 100644 hw/acpi/generic_event_device.c > create mode 100644 include/hw/acpi/generic_event_device.h >
On Tue, 18 Jun 2019 at 13:52, Auger Eric <eric.auger@redhat.com> wrote: > Feel free to add my T-b on next version: > Tested-by: Eric Auger <eric.auger@redhat.com> I'm not sure we should carry across Tested-by tags like that: any respin might accidentally introduce bugs that make it stop working... thanks -- PMM
Hi Peter, On 6/18/19 2:57 PM, Peter Maydell wrote: > I'm not sure we should carry across Tested-by tags like that: any > respin might accidentally introduce bugs that make it stop working... OK. No problem. I will test the next version then. Thanks Eric
Hi Eric, > -----Original Message----- > From: Auger Eric [mailto:eric.auger@redhat.com] > Sent: 18 June 2019 14:45 > To: Peter Maydell <peter.maydell@linaro.org> > Cc: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; > QEMU Developers <qemu-devel@nongnu.org>; qemu-arm > <qemu-arm@nongnu.org>; Igor Mammedov <imammedo@redhat.com>; > Shannon Zhao <shannon.zhaosl@gmail.com>; Samuel Ortiz > <sameo@linux.intel.com>; sebastien.boeuf@intel.com; xuwei (O) > <xuwei5@huawei.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel > <ard.biesheuvel@linaro.org>; Linuxarm <linuxarm@huawei.com> > Subject: Re: [PATCH v5 0/8] ARM virt: ACPI memory hotplug support > > Hi Peter, > On 6/18/19 2:57 PM, Peter Maydell wrote: > > I'm not sure we should carry across Tested-by tags like that: any > > respin might accidentally introduce bugs that make it stop working... > > OK. No problem. I will test the next version then. Thanks for testing and verifying. I will respin this soon. Cheers, Shameer
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the guest kernel should be => 5.0-rc1. NVDIM support is not included currently as we still have an unresolved issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches can be included, but not done for now, for keeping it simple. This makes use of GED device to sent hotplug ACPI events to the Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and Sebastien to add the hardware-reduced support to Nemu using GED device[3]. (Please shout if I got the author/signed-off wrong for those patches or missed any names). This is sanity tested on a HiSilicon ARM64 platform and appreciate any further testing. Thanks, Shameer [1] https://patchwork.kernel.org/cover/10837565/ [2] https://patchwork.kernel.org/cover/10783589/ [3] https://github.com/intel/nemu/blob/topic/virt-x86/hw/acpi/ged.c [4] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-May/651763.html v4 --> v5 -Removed gsi/ged-irq routing in virt. -Added Migration support. -Dropped support for DT coldplug case based on the discussions here[4] -Added system_powerdown support through GED. v3 --> v4 Addressed comments from Igor and Eric, -Renamed "virt-acpi" to "acpi-ged". -Changed ged device parent to TYPE_DEVICE. -Introduced DT memory node property "hotpluggable" to resolve device memory being treated as early boot memory issue(patch #7). -Combined patches #3 and #9 from v3 into #3. v2 --> v3 Addressed comments from Igor and Eric, -Made virt acpi device platform independent and moved to hw/acpi/generic_event_device.c -Moved ged specific code into hw/acpi/generic_event_device.c -Introduced an opt-in feature "fdt" to resolve device-memory being treated as early boot memory. -Dropped patch #1 from v2. RFC --> v2 -Use GED device instead of GPIO for ACPI hotplug events. -Removed NVDIMM support for now. -Includes dropped patches from Eric's v9 series. Eric Auger (1): hw/arm/virt: Add memory hotplug framework Samuel Ortiz (2): hw/acpi: Do not create memory hotplug method when handler is not defined hw/acpi: Add ACPI Generic Event Device Support Shameer Kolothum (5): hw/acpi: Make ACPI IO address space configurable hw/arm/virt: Enable device memory cold/hot plug with ACPI boot hw/arm/virt-acpi-build: Add PC-DIMM in SRAT hw/acpi: Add system power down support to GED hw/arm: Use GED for system_powerdown event hw/acpi/Kconfig | 4 + hw/acpi/Makefile.objs | 1 + hw/acpi/generic_event_device.c | 348 +++++++++++++++++++++++++ hw/acpi/memory_hotplug.c | 35 +-- hw/arm/Kconfig | 4 + hw/arm/virt-acpi-build.c | 58 ++--- hw/arm/virt.c | 88 ++++++- hw/i386/acpi-build.c | 3 +- include/hw/acpi/generic_event_device.h | 106 ++++++++ include/hw/acpi/memory_hotplug.h | 9 +- include/hw/arm/virt.h | 3 + 11 files changed, 603 insertions(+), 56 deletions(-) create mode 100644 hw/acpi/generic_event_device.c create mode 100644 include/hw/acpi/generic_event_device.h