| Message ID | 20190607091116.49044-1-ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add RX archtecture support | expand |
Patchew URL: https://patchew.org/QEMU/20190607091116.49044-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support
Message-id: 20190607091116.49044-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
7d17741 target/rx: Remove suffix in cpu class.
055eac1 target/rx: Dump bytes for each insn during disassembly
5889886 target/rx: Collect all bytes during disassembly
8d96e1b target/rx: Emit all disassembly in one prt()
ca74c35 target/rx: Use prt_ldmi for XCHG_mr disassembly
fa4556d target/rx: Replace operand with prt_ldmi in disassembler
f264e8b target/rx: Disassemble rx_index_addr into a string
d50d585 MAINTAINERS: Add RX
5cd47e7 Add rx-softmmu
621ef37 hw/rx: Honor -accel qtest
f12f4c1 tests: Add rx to machine-none-test.c
6d30cec target/rx: Fix cpu types and names
67e5be8 target/rx: Add RX to SysEmuTarget
e53a4a5 target/rx: Convert to CPUClass::tlb_fill
88286fa hw/registerfields.h: Add 8bit and 16bit register macros
a063aa8 qemu/bitops.h: Add extract8 and extract16
180659a hw/rx: RX Target hardware definition
b9a1904 hw/char: RX62N serial communication interface (SCI)
af4236a hw/timer: RX62N internal timer modules
f4333f3 hw/intc: RX62N interrupt controller (ICUa)
e019cb8 target/rx: RX disassembler
76a68b1 target/rx: CPU definition
1d6e5b8 target/rx: TCG helper
017f9e4 target/rx: TCG translation
=== OUTPUT BEGIN ===
1/24 Checking commit 017f9e4d6eff (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 1/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 1d6e5b8a6919 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 660 lines checked
Patch 2/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 76a68b18cd6e (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 599 lines checked
Patch 3/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit e019cb819a73 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 4/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit f4333f347c4d (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39:
new file mode 100644
total: 0 errors, 1 warnings, 442 lines checked
Patch 5/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/24 Checking commit af4236ab4b8b (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
new file mode 100644
total: 0 errors, 1 warnings, 839 lines checked
Patch 6/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit b9a190420fbd (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42:
new file mode 100644
total: 0 errors, 1 warnings, 398 lines checked
Patch 7/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/24 Checking commit 180659a9e467 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 460 lines checked
Patch 8/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/24 Checking commit a063aa8f9e24 (qemu/bitops.h: Add extract8 and extract16)
10/24 Checking commit 88286fa55544 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#25: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#29: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 10/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/24 Checking commit e53a4a599b28 (target/rx: Convert to CPUClass::tlb_fill)
12/24 Checking commit 67e5be80711d (target/rx: Add RX to SysEmuTarget)
13/24 Checking commit 6d30ceccc05f (target/rx: Fix cpu types and names)
14/24 Checking commit f12f4c14f4c8 (tests: Add rx to machine-none-test.c)
15/24 Checking commit 621ef3747ee7 (hw/rx: Honor -accel qtest)
16/24 Checking commit 5cd47e7ef3ac (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54:
new file mode 100644
total: 0 errors, 1 warnings, 45 lines checked
Patch 16/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit d50d585c90c3 (MAINTAINERS: Add RX)
18/24 Checking commit f264e8b4e13b (target/rx: Disassemble rx_index_addr into a string)
19/24 Checking commit fa4556d91128 (target/rx: Replace operand with prt_ldmi in disassembler)
20/24 Checking commit ca74c35ac73d (target/rx: Use prt_ldmi for XCHG_mr disassembly)
21/24 Checking commit 8d96e1b3b74d (target/rx: Emit all disassembly in one prt())
22/24 Checking commit 588988643d4e (target/rx: Collect all bytes during disassembly)
23/24 Checking commit 055eac109bec (target/rx: Dump bytes for each insn during disassembly)
24/24 Checking commit 7d17741430a6 (target/rx: Remove suffix in cpu class.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190607091116.49044-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190607091116.49044-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support
Message-id: 20190607091116.49044-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
0a86ff5 target/rx: Remove suffix in cpu class.
7c34b40 target/rx: Dump bytes for each insn during disassembly
945fdef target/rx: Collect all bytes during disassembly
9b70cf6 target/rx: Emit all disassembly in one prt()
2b90c06 target/rx: Use prt_ldmi for XCHG_mr disassembly
2b32bfa target/rx: Replace operand with prt_ldmi in disassembler
c1043d7 target/rx: Disassemble rx_index_addr into a string
fffdd29 MAINTAINERS: Add RX
0bbb796 Add rx-softmmu
d93ac92 hw/rx: Honor -accel qtest
fdae244 tests: Add rx to machine-none-test.c
28f5c67 target/rx: Fix cpu types and names
d6dc436 target/rx: Add RX to SysEmuTarget
afe7fba target/rx: Convert to CPUClass::tlb_fill
0a8257b hw/registerfields.h: Add 8bit and 16bit register macros
32020f6 qemu/bitops.h: Add extract8 and extract16
8bdcd32 hw/rx: RX Target hardware definition
129d81c hw/char: RX62N serial communication interface (SCI)
dab747e hw/timer: RX62N internal timer modules
bd0cd17 hw/intc: RX62N interrupt controller (ICUa)
77f42d4 target/rx: RX disassembler
05f2af5 target/rx: CPU definition
16eaad3 target/rx: TCG helper
566ca1e target/rx: TCG translation
=== OUTPUT BEGIN ===
1/24 Checking commit 566ca1e22f98 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 1/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 16eaad386caa (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 660 lines checked
Patch 2/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 05f2af51dfa8 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
total: 0 errors, 1 warnings, 599 lines checked
Patch 3/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit 77f42d4c2eb2 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 4/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit bd0cd177ac9d (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39:
new file mode 100644
total: 0 errors, 1 warnings, 442 lines checked
Patch 5/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/24 Checking commit dab747e06f0c (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49:
new file mode 100644
total: 0 errors, 1 warnings, 839 lines checked
Patch 6/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit 129d81c52450 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42:
new file mode 100644
total: 0 errors, 1 warnings, 398 lines checked
Patch 7/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/24 Checking commit 8bdcd3251fe6 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 460 lines checked
Patch 8/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/24 Checking commit 32020f6289d7 (qemu/bitops.h: Add extract8 and extract16)
10/24 Checking commit 0a8257b1853a (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#25: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#29: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 10/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/24 Checking commit afe7fba60d82 (target/rx: Convert to CPUClass::tlb_fill)
12/24 Checking commit d6dc436c6701 (target/rx: Add RX to SysEmuTarget)
13/24 Checking commit 28f5c6778a28 (target/rx: Fix cpu types and names)
14/24 Checking commit fdae244edeac (tests: Add rx to machine-none-test.c)
15/24 Checking commit d93ac92399b1 (hw/rx: Honor -accel qtest)
16/24 Checking commit 0bbb796e9dd3 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54:
new file mode 100644
total: 0 errors, 1 warnings, 45 lines checked
Patch 16/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit fffdd29b15ad (MAINTAINERS: Add RX)
18/24 Checking commit c1043d77d908 (target/rx: Disassemble rx_index_addr into a string)
19/24 Checking commit 2b32bfa218e0 (target/rx: Replace operand with prt_ldmi in disassembler)
20/24 Checking commit 2b90c0624c57 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
21/24 Checking commit 9b70cf645d36 (target/rx: Emit all disassembly in one prt())
22/24 Checking commit 945fdef6f8e0 (target/rx: Collect all bytes during disassembly)
23/24 Checking commit 7c34b40e76c6 (target/rx: Dump bytes for each insn during disassembly)
24/24 Checking commit 0a86ff5bb316 (target/rx: Remove suffix in cpu class.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190607091116.49044-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hi Yoshinori, On 6/7/19 11:10 AM, Yoshinori Sato wrote: > Hello. > This patch series is added Renesas RX target emulation. > > Changes v17. > Remove cpu class name suffix. I was a bit annoyed you did not collect my review effort from the previous series. It is time-saving for reviewers because you don't have to re-review the same code twice. > > My git repository is bellow. > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190607 > > Testing binaries bellow. > u-boot > Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz > > starting > $ gzip -d u-boot.bin.gz > $ qemu-system-rx -bios u-boot.bin > > linux and pico-root (only sash) > Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel) > https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree) > > starting > $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon" > > > Richard Henderson (11): > target/rx: Convert to CPUClass::tlb_fill > target/rx: Add RX to SysEmuTarget > target/rx: Fix cpu types and names > tests: Add rx to machine-none-test.c > hw/rx: Honor -accel qtest > target/rx: Disassemble rx_index_addr into a string > target/rx: Replace operand with prt_ldmi in disassembler > target/rx: Use prt_ldmi for XCHG_mr disassembly > target/rx: Emit all disassembly in one prt() > target/rx: Collect all bytes during disassembly > target/rx: Dump bytes for each insn during disassembly > > Yoshinori Sato (13): > target/rx: TCG translation > target/rx: TCG helper > target/rx: CPU definition > target/rx: RX disassembler > hw/intc: RX62N interrupt controller (ICUa) > hw/timer: RX62N internal timer modules > hw/char: RX62N serial communication interface (SCI) > hw/rx: RX Target hardware definition > qemu/bitops.h: Add extract8 and extract16 > hw/registerfields.h: Add 8bit and 16bit register macros > Add rx-softmmu > MAINTAINERS: Add RX > target/rx: Remove suffix in cpu class. I'd move the last patch directly after "target/rx: Fix cpu types and names". Actually I rebased it this way: [PATCH 01/24] target/rx: TCG translation [PATCH 02/24] target/rx: TCG helper [PATCH 03/24] target/rx: CPU definition [PATCH 04/24] target/rx: RX disassembler [PATCH 18/24] target/rx: Disassemble rx_index_addr into a string [PATCH 19/24] target/rx: Replace operand with prt_ldmi in disassembler [PATCH 20/24] target/rx: Use prt_ldmi for XCHG_mr disassembly [PATCH 21/24] target/rx: Emit all disassembly in one prt() [PATCH 22/24] target/rx: Collect all bytes during disassembly [PATCH 23/24] target/rx: Dump bytes for each insn during disassembly [PATCH 05/24] hw/intc: RX62N interrupt controller (ICUa) [PATCH 06/24] hw/timer: RX62N internal timer modules [PATCH 07/24] hw/char: RX62N serial communication interface (SCI) [PATCH 08/24] hw/rx: RX Target hardware definition [PATCH 09/24] qemu/bitops.h: Add extract8 and extract16 [PATCH 10/24] hw/registerfields.h: Add 8bit and 16bit register macros [PATCH 11/24] target/rx: Convert to CPUClass::tlb_fill [PATCH 13/24] target/rx: Fix cpu types and names [PATCH 24/24] target/rx: Remove suffix in cpu class. [PATCH 12/24] target/rx: Add RX to SysEmuTarget [PATCH 14/24] tests: Add rx to machine-none-test.c [PATCH 15/24] hw/rx: Honor -accel qtest [PATCH 16/24] Add rx-softmmu [PATCH 17/24] MAINTAINERS: Add RX On Linux + win32 running u-boot + Linux as suggested: Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Patchew URL: https://patchew.org/QEMU/20190607091116.49044-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v17 00/24] Add RX archtecture support
Type: series
Message-id: 20190607091116.49044-1-ysato@users.sourceforge.jp
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190607091116.49044-1-ysato@users.sourceforge.jp -> patchew/20190607091116.49044-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
8c36c53a15 target/rx: Remove suffix in cpu class.
7c74fad429 target/rx: Dump bytes for each insn during disassembly
ffd02de520 target/rx: Collect all bytes during disassembly
617040d53b target/rx: Emit all disassembly in one prt()
946b9561b5 target/rx: Use prt_ldmi for XCHG_mr disassembly
a45c45f2b0 target/rx: Replace operand with prt_ldmi in disassembler
41cc509a4f target/rx: Disassemble rx_index_addr into a string
d6082e85f9 MAINTAINERS: Add RX
14cf31b465 Add rx-softmmu
8d2c180952 hw/rx: Honor -accel qtest
db79258006 tests: Add rx to machine-none-test.c
7b3a8dc7d1 target/rx: Fix cpu types and names
3dc8909dc9 target/rx: Add RX to SysEmuTarget
faa146c401 target/rx: Convert to CPUClass::tlb_fill
d6fc0cbb25 hw/registerfields.h: Add 8bit and 16bit register macros
42fe1569a6 qemu/bitops.h: Add extract8 and extract16
76070155e0 hw/rx: RX Target hardware definition
c2487837c0 hw/char: RX62N serial communication interface (SCI)
477bb26880 hw/timer: RX62N internal timer modules
f3d47f3636 hw/intc: RX62N interrupt controller (ICUa)
3be294f121 target/rx: RX disassembler
43573a6282 target/rx: CPU definition
f712756a33 target/rx: TCG helper
e4c37ca6fd target/rx: TCG translation
=== OUTPUT BEGIN ===
1/24 Checking commit e4c37ca6fd60 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 1/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit f712756a3323 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
total: 0 errors, 1 warnings, 660 lines checked
Patch 2/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 43573a628243 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644
total: 0 errors, 1 warnings, 599 lines checked
Patch 3/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit 3be294f1215b (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 4/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit f3d47f36367d (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 442 lines checked
Patch 5/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/24 Checking commit 477bb26880d3 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 839 lines checked
Patch 6/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit c2487837c01b (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 398 lines checked
Patch 7/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/24 Checking commit 76070155e0c9 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 460 lines checked
Patch 8/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/24 Checking commit 42fe1569a60d (qemu/bitops.h: Add extract8 and extract16)
10/24 Checking commit d6fc0cbb25b9 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#26: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#30: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 10/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/24 Checking commit faa146c40157 (target/rx: Convert to CPUClass::tlb_fill)
12/24 Checking commit 3dc8909dc983 (target/rx: Add RX to SysEmuTarget)
13/24 Checking commit 7b3a8dc7d1f8 (target/rx: Fix cpu types and names)
14/24 Checking commit db7925800679 (tests: Add rx to machine-none-test.c)
15/24 Checking commit 8d2c18095229 (hw/rx: Honor -accel qtest)
16/24 Checking commit 14cf31b465a6 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54:
new file mode 100644
total: 0 errors, 1 warnings, 45 lines checked
Patch 16/24 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit d6082e85f9af (MAINTAINERS: Add RX)
18/24 Checking commit 41cc509a4f64 (target/rx: Disassemble rx_index_addr into a string)
19/24 Checking commit a45c45f2b013 (target/rx: Replace operand with prt_ldmi in disassembler)
20/24 Checking commit 946b9561b544 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
21/24 Checking commit 617040d53b58 (target/rx: Emit all disassembly in one prt())
22/24 Checking commit ffd02de520a5 (target/rx: Collect all bytes during disassembly)
23/24 Checking commit 7c74fad429b6 (target/rx: Dump bytes for each insn during disassembly)
24/24 Checking commit 8c36c53a15ff (target/rx: Remove suffix in cpu class.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190607091116.49044-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hello. This patch series is added Renesas RX target emulation. Changes v17. Remove cpu class name suffix. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190607 Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ gzip -d u-boot.bin.gz $ qemu-system-rx -bios u-boot.bin linux and pico-root (only sash) Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel) https://osdn.net/users/ysato/pf/qemu/dl/rx-qemu.dtb (DeviceTree) starting $ qemu-system-rx -kernel zImage -dtb rx-qemu.dtb -append "earlycon" Richard Henderson (11): target/rx: Convert to CPUClass::tlb_fill target/rx: Add RX to SysEmuTarget target/rx: Fix cpu types and names tests: Add rx to machine-none-test.c hw/rx: Honor -accel qtest target/rx: Disassemble rx_index_addr into a string target/rx: Replace operand with prt_ldmi in disassembler target/rx: Use prt_ldmi for XCHG_mr disassembly target/rx: Emit all disassembly in one prt() target/rx: Collect all bytes during disassembly target/rx: Dump bytes for each insn during disassembly Yoshinori Sato (13): target/rx: TCG translation target/rx: TCG helper target/rx: CPU definition target/rx: RX disassembler hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serial communication interface (SCI) hw/rx: RX Target hardware definition qemu/bitops.h: Add extract8 and extract16 hw/registerfields.h: Add 8bit and 16bit register macros Add rx-softmmu MAINTAINERS: Add RX target/rx: Remove suffix in cpu class. configure | 8 + default-configs/rx-softmmu.mak | 3 + qapi/common.json | 3 +- include/disas/dis-asm.h | 5 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 94 ++ include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu.h | 226 ++++ target/rx/helper.h | 31 + arch_init.c | 2 + hw/char/renesas_sci.c | 340 ++++++ hw/intc/rx_icu.c | 376 +++++++ hw/rx/rx-virt.c | 105 ++ hw/rx/rx62n.c | 246 ++++ hw/timer/renesas_cmt.c | 275 +++++ hw/timer/renesas_tmr.c | 455 ++++++++ target/rx/cpu.c | 241 ++++ target/rx/disas.c | 1446 ++++++++++++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 148 +++ target/rx/monitor.c | 38 + target/rx/op_helper.c | 470 ++++++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++++++++++++++++++ tests/machine-none-test.c | 1 + MAINTAINERS | 19 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 12 + target/rx/insns.decode | 621 ++++++++++ 42 files changed, 8011 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/monitor.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/insns.decode