Message ID | 20190614131724.33928-1-mrolnik@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | QEMU AVR 8 bit cores | expand |
Patchew URL: https://patchew.org/QEMU/20190614131724.33928-1-mrolnik@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v22 0/7] QEMU AVR 8 bit cores Type: series Message-id: 20190614131724.33928-1-mrolnik@gmail.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190614131724.33928-1-mrolnik@gmail.com -> patchew/20190614131724.33928-1-mrolnik@gmail.com Switched to a new branch 'test' 9105e1c184 target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file d41d59c5c8 target/avr: Add example board configuration 23be494cfe target/avr: Add limited support for USART and 16 bit timer peripherals 016f124f62 target/avr: Add instruction translation c32d5b797f target/avr: Add instruction decoding 50f51117b0 target/avr: Add instruction helpers cb3eb05bc2 target/avr: Add outward facing interfaces and core CPU logic === OUTPUT BEGIN === 1/7 Checking commit cb3eb05bc2bb (target/avr: Add outward facing interfaces and core CPU logic) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 1176 lines checked Patch 1/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/7 Checking commit 50f51117b021 (target/avr: Add instruction helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 383 lines checked Patch 2/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/7 Checking commit c32d5b797fcb (target/avr: Add instruction decoding) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 175 lines checked Patch 3/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/7 Checking commit 016f124f62c8 (target/avr: Add instruction translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 ERROR: line over 90 characters #56: FILE: target/avr/translate.c:38: + * This is for https://github.com/seharris/qemu-avr-tests/tree/master/instruction-tests tests total: 1 errors, 1 warnings, 2886 lines checked Patch 4/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/7 Checking commit 23be494cfe1b (target/avr: Add limited support for USART and 16 bit timer peripherals) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 1127 lines checked Patch 5/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/7 Checking commit d41d59c5c884 (target/avr: Add example board configuration) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 229 lines checked Patch 6/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/7 Checking commit 9105e1c184b3 (target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #66: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 7/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190614131724.33928-1-mrolnik@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Hi all, should I rebase and resend or these ones are still good? Regards, Michael On Fri, Jun 14, 2019 at 5:21 PM <no-reply@patchew.org> wrote: > Patchew URL: > https://patchew.org/QEMU/20190614131724.33928-1-mrolnik@gmail.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH v22 0/7] QEMU AVR 8 bit cores > Type: series > Message-id: 20190614131724.33928-1-mrolnik@gmail.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > From https://github.com/patchew-project/qemu > * [new tag] patchew/ > 20190614131724.33928-1-mrolnik@gmail.com -> patchew/ > 20190614131724.33928-1-mrolnik@gmail.com > Switched to a new branch 'test' > 9105e1c184 target/avr: Register AVR support with the rest of QEMU, the > build system, and the MAINTAINERS file > d41d59c5c8 target/avr: Add example board configuration > 23be494cfe target/avr: Add limited support for USART and 16 bit timer > peripherals > 016f124f62 target/avr: Add instruction translation > c32d5b797f target/avr: Add instruction decoding > 50f51117b0 target/avr: Add instruction helpers > cb3eb05bc2 target/avr: Add outward facing interfaces and core CPU logic > > === OUTPUT BEGIN === > 1/7 Checking commit cb3eb05bc2bb (target/avr: Add outward facing > interfaces and core CPU logic) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #17: > new file mode 100644 > > total: 0 errors, 1 warnings, 1176 lines checked > > Patch 1/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 2/7 Checking commit 50f51117b021 (target/avr: Add instruction helpers) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #16: > new file mode 100644 > > total: 0 errors, 1 warnings, 383 lines checked > > Patch 2/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 3/7 Checking commit c32d5b797fcb (target/avr: Add instruction decoding) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #15: > new file mode 100644 > > total: 0 errors, 1 warnings, 175 lines checked > > Patch 3/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 4/7 Checking commit 016f124f62c8 (target/avr: Add instruction translation) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #14: > new file mode 100644 > > ERROR: line over 90 characters > #56: FILE: target/avr/translate.c:38: > + * This is for > https://github.com/seharris/qemu-avr-tests/tree/master/instruction-tests > tests > > total: 1 errors, 1 warnings, 2886 lines checked > > Patch 4/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 5/7 Checking commit 23be494cfe1b (target/avr: Add limited support for > USART and 16 bit timer peripherals) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #37: > new file mode 100644 > > total: 0 errors, 1 warnings, 1127 lines checked > > Patch 5/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 6/7 Checking commit d41d59c5c884 (target/avr: Add example board > configuration) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #26: > new file mode 100644 > > total: 0 errors, 1 warnings, 229 lines checked > > Patch 6/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 7/7 Checking commit 9105e1c184b3 (target/avr: Register AVR support with > the rest of QEMU, the build system, and the MAINTAINERS file) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #66: > new file mode 100644 > > total: 0 errors, 1 warnings, 116 lines checked > > Patch 7/7 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > > http://patchew.org/logs/20190614131724.33928-1-mrolnik@gmail.com/testing.checkpatch/?type=message > . > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com