[0/3] tricore: Convert to translate_loop

Message

Bastian Koppelmann June 17, 2019, 2:35 p.m. UTC

Hi,

I finally came around to port TriCore to the "new" translate_loop
infrastructure. This is neccessary such that TriCore can be used in the upcoming
plugin API [1]. 

Cheers,
Bastian

[1] (https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg03165.html)


Bastian Koppelmann (3):
  target/tricore: Use DisasContextBase API
  target-tricore: Make env a member of DisasContext
  target/tricore: Use translate_loop

 target/tricore/translate.c | 527 +++++++++++++++++++------------------
 1 file changed, 272 insertions(+), 255 deletions(-)

Comments

[e-mail] June 17, 2019, 7:07 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: [e-mail]
Type: series
Subject: [Qemu-devel] [PATCH 0/3] tricore: Convert to translate_loop

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
3795cef target/tricore: Use translate_loop
d50dce9 target-tricore: Make env a member of DisasContext
6d30fd1 target/tricore: Use DisasContextBase API

=== OUTPUT BEGIN ===
1/3 Checking commit 6d30fd14d6c8 (target/tricore: Use DisasContextBase API)
2/3 Checking commit d50dce928c26 (target-tricore: Make env a member of DisasContext)
ERROR: spaces required around that '+' (ctx:VxV)
#660: FILE: target/tricore/translate.c:6586:
+        gen_dvinit_b(ctx, cpu_gpr_d[r3], cpu_gpr_d[r3+1], cpu_gpr_d[r1],
                                                      ^

ERROR: spaces required around that '+' (ctx:VxV)
#678: FILE: target/tricore/translate.c:6619:
+        gen_dvinit_h(ctx, cpu_gpr_d[r3], cpu_gpr_d[r3+1], cpu_gpr_d[r1],
                                                      ^

total: 2 errors, 0 warnings, 1154 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 3795cefb9ed0 (target/tricore: Use translate_loop)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]