mbox series

[v5,0/4] delete created files when block_crypto_co_create_opts_luks fails

Message ID 20190807142114.17569-1-danielhb413@gmail.com (mailing list archive)
Headers show
Series delete created files when block_crypto_co_create_opts_luks fails | expand

Message

Daniel Henrique Barboza Aug. 7, 2019, 2:21 p.m. UTC
Changes from previous version 4 [1], all suggested by Kevin
Wolf:

- changed bdrv_co_delete_file interface to receive a BlockDriverState
instead of a file name;
- delete created files even if pre-existent, since they'll be
truncated/corrupted if the process fails anyway

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg06435.html

Daniel Henrique Barboza (4):
  block: introducing 'bdrv_co_delete_file' interface
  block.c: adding bdrv_delete_file
  crypto.c: cleanup created file when block_crypto_co_create_opts_luks
    fails
  qemu-iotests: adding LUKS cleanup for non-UTF8 secret error

 block.c                    | 77 ++++++++++++++++++++++++++++++++++++++
 block/crypto.c             | 20 ++++++++++
 block/file-posix.c         | 28 ++++++++++++++
 include/block/block.h      |  1 +
 include/block/block_int.h  |  6 +++
 tests/qemu-iotests/257     | 67 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/257.out | 11 ++++++
 tests/qemu-iotests/group   |  1 +
 8 files changed, 211 insertions(+)
 create mode 100755 tests/qemu-iotests/257
 create mode 100644 tests/qemu-iotests/257.out