[v2,0/3] decodetree improvements

Message

Richard Henderson Aug. 18, 2019, 6:39 a.m. UTC

Changes from v1:
  * Drop unintended hunk from MultiField constructor.
  * Typo fixed in ParameterField documentation.

Blurb from v1:
  These are split out from my decodetree coversion of the AArch32
  base instruction sets.

  The first patch has been tidied per review from Peter.  I now
  diagnose nonsense fields containing no bits.  I eliminated the
  unused integer argument passed to the named function.  I improved
  the documentation.

  The second patch is new, a suggestion from Phillipe.  This then
  enables the third patch, tidying up the existing usage in riscv.


r~


Richard Henderson (3):
  decodetree: Allow !function with no input bits
  decodetree: Suppress redundant declaration warnings
  target/riscv: Remove redundant declaration pragmas

 target/riscv/translate.c          | 19 +--------
 docs/devel/decodetree.rst         |  8 +++-
 scripts/decodetree.py             | 71 ++++++++++++++++++++++++++-----
 tests/decode/err_field6.decode    |  5 +++
 tests/decode/succ_function.decode |  6 +++
 5 files changed, 79 insertions(+), 30 deletions(-)
 create mode 100644 tests/decode/err_field6.decode
 create mode 100644 tests/decode/succ_function.decode