From patchwork Wed Aug 21 14:21:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 11106999 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A200813A4 for ; Wed, 21 Aug 2019 14:23:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 835CF22D6D for ; Wed, 21 Aug 2019 14:23:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 835CF22D6D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:49008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0RWo-0005B6-Ef for patchwork-qemu-devel@patchwork.kernel.org; Wed, 21 Aug 2019 10:23:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34801) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0RVo-0003hI-7I for qemu-devel@nongnu.org; Wed, 21 Aug 2019 10:22:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0RVm-00089C-RB for qemu-devel@nongnu.org; Wed, 21 Aug 2019 10:22:55 -0400 Received: from esa1.mentor.iphmx.com ([68.232.129.153]:61425) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0RVm-00086g-Gk for qemu-devel@nongnu.org; Wed, 21 Aug 2019 10:22:54 -0400 IronPort-SDR: e8gQwmaXBQZc6SsldtmCq2PQP6dZYUMyD63G8UAsBR8yC4fRQ5jPaoH9b3heEZejuiidtUxZNS 74Aw10dsAMV0cYmrU1zMiYXnUp5KMBBWkDKaqmZ/hGlDLzEtYqnRKW1t7Y28CPBz4AzINEr3ub hu3F7vHrhGpSbWyWIEVzo7tceKLsXvT1vpykIqvpyF65BvGVs6YSlreCG36k6zbNaWsxfMrqFe oUglhn5F2UZYUM5HIE9yeMwr99MpukkUICHiJV0T2OOaj2kOlVOXzLtmD0DH616FR3YAQW6GcE 6iI= X-IronPort-AV: E=Sophos;i="5.64,412,1559548800"; d="scan'208";a="42443943" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 21 Aug 2019 06:22:49 -0800 IronPort-SDR: n/yvgwtbgGbwJPJz5HHa70ZzAVcvWcRdfj3Hdik8lido3BcjRy8Ss5QKZ69DdYG5/1xzE8VvDv wdytnxmXhwJSWj3B+nmeyTpbvUTY4u5suZUbe61SgJlKGnUzHZzOknfWaJg0uckAI+cGtSuG9K Ht99Zmc3TpD+fq2cIHWKigDwEjA9R79sb5W4vVpS/vNMT773oGSkMVolnlUOb88bJGeLsIC5PU 5kDDgtFPfrAe59DzuvRkK4F+OUeHVuus/00kBuui9+06GYD8s+ZrhwL8KAqXRB9PoqFiwc6USh iNM= From: Sandra Loosemore To: Date: Wed, 21 Aug 2019 08:21:49 -0600 Message-ID: <20190821142151.19995-1-sandra@codesourcery.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 68.232.129.153 Subject: [Qemu-devel] [PATCH 0/2] Fix bug in nios2 and m68k semihosting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Chris Wulff , Laurent Vivier Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" I noticed recently that the exit semihosting call on nios2 was ignoring its parameter and always returning status 0 instead. It turns out the handler was retrieving the value of the wrong register. Since the nios2 semihosting implementation was basically cut-and-pasted from that for m68k, I checked m68k also and it had the same bug. This set of patches fixes both of them. Sandra Loosemore (2): target/nios2: Fix bug in semihosted exit handling target/m68k: Fix bug in semihosted exit handling target/m68k/m68k-semi.c | 4 ++-- target/nios2/nios2-semi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)