Message ID | 20190913201349.24332-1-armbru@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | qapi: Schema language cleanups & doc improvements | expand |
Patchew URL: https://patchew.org/QEMU/20190913201349.24332-1-armbru@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 00/16] qapi: Schema language cleanups & doc improvements Message-id: 20190913201349.24332-1-armbru@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9491787 qapi: Tweak code to match docs/devel/qapi-code-gen.txt 6fb4a27 docs/devel/qapi-code-gen: Improve QAPI schema language doc a474494 docs/devel/qapi-code-gen: Rewrite introduction to schema 6640272 docs/devel/qapi-code-gen: Rewrite compatibility considerations d3cec78 docs/devel/qapi-code-gen: Reorder sections for readability b48aba3 qapi: Adjust frontend errors to say enum value, not member 70ce619 qapi: Permit omitting all flat union branches 4ecd688 qapi: Permit alternates with just one branch 6fb8f9e qapi: Permit 'boxed' with empty type c5e9097 qapi: Drop support for escape sequences other than \\ 113836f qapi: Restrict strings to printable ASCII fe760f3 tests/qapi-schema: Demonstrate bad reporting of funny characters 776df7c docs/devel/qapi-code-gen: Minor specification fixes 181a438 qapi: Drop support for boxed alternate arguments 57f9740 qapi: Drop check_type()'s redundant parameter @allow_optional 7975c5d scripts/git.orderfile: Match QAPI schema more precisely === OUTPUT BEGIN === 1/16 Checking commit 7975c5d69cca (scripts/git.orderfile: Match QAPI schema more precisely) 2/16 Checking commit 57f9740b5d6c (qapi: Drop check_type()'s redundant parameter @allow_optional) 3/16 Checking commit 181a4384e8b8 (qapi: Drop support for boxed alternate arguments) 4/16 Checking commit 776df7cd45c6 (docs/devel/qapi-code-gen: Minor specification fixes) 5/16 Checking commit fe760f39461c (tests/qapi-schema: Demonstrate bad reporting of funny characters) 6/16 Checking commit 113836f31dd5 (qapi: Restrict strings to printable ASCII) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #109: new file mode 100644 ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #126: FILE: tests/qapi-schema/string-code-point-127.json:2: +{ 'command': '⌦' } ^ ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #152: FILE: tests/qapi-schema/string-code-point-31.json:2: +{ 'command': '␟' } ^ total: 2 errors, 1 warnings, 76 lines checked Patch 6/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/16 Checking commit c5e90975c8c5 (qapi: Drop support for escape sequences other than \\) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #74: deleted file mode 100644 total: 0 errors, 1 warnings, 53 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 6fb8f9e7baa7 (qapi: Permit 'boxed' with empty type) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #130: deleted file mode 100644 total: 0 errors, 1 warnings, 129 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 4ecd688cd6a1 (qapi: Permit alternates with just one branch) 10/16 Checking commit 70ce619cf6af (qapi: Permit omitting all flat union branches) 11/16 Checking commit b48aba3a338c (qapi: Adjust frontend errors to say enum value, not member) 12/16 Checking commit d3cec7869722 (docs/devel/qapi-code-gen: Reorder sections for readability) 13/16 Checking commit 66402729d139 (docs/devel/qapi-code-gen: Rewrite compatibility considerations) 14/16 Checking commit a474494a010b (docs/devel/qapi-code-gen: Rewrite introduction to schema) 15/16 Checking commit 6fb4a273e1f6 (docs/devel/qapi-code-gen: Improve QAPI schema language doc) 16/16 Checking commit 9491787d3689 (qapi: Tweak code to match docs/devel/qapi-code-gen.txt) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190913201349.24332-1-armbru@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 9/13/19 3:13 PM, Markus Armbruster wrote: > v3: > * PATCH 05 > - Typo fixed [Eric] > * PATCH 06+07 > - Additional comments [Eric] > * PATCH 11 > - Replace one more QAPISchemaMember by QAPISchemaEnumMember > * PATCH 13+15 > - Doc phrasing tweaks [Eric] > * PATCH 14+15 > - Belatedly update for v2's restriction to printable ASCII [Eric] > - Correct claim "order of top-level expression doesn't matter" [Eric] > * PATCH 15 > - Fix EBNF for PRAGMA [Eric] Peter Krempa's proposal to add features to commands (for introspecting Kevin's recent savevm fix) slightly conflicts with this. https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03586.html
Eric Blake <eblake@redhat.com> writes: > On 9/13/19 3:13 PM, Markus Armbruster wrote: >> v3: >> * PATCH 05 >> - Typo fixed [Eric] >> * PATCH 06+07 >> - Additional comments [Eric] >> * PATCH 11 >> - Replace one more QAPISchemaMember by QAPISchemaEnumMember >> * PATCH 13+15 >> - Doc phrasing tweaks [Eric] >> * PATCH 14+15 >> - Belatedly update for v2's restriction to printable ASCII [Eric] >> - Correct claim "order of top-level expression doesn't matter" [Eric] >> * PATCH 15 >> - Fix EBNF for PRAGMA [Eric] > > Peter Krempa's proposal to add features to commands (for introspecting > Kevin's recent savevm fix) slightly conflicts with this. > > https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03586.html I'm pretty sure it'll conflict plenty more with the not-yet-posted-to-avoid-scaring-off-reviewers part of my work. We'll work it out :)
Queued with two small tweaks as per Eric's review: a commit message typo fix in PATCH 10, and an additional paragraph on invisible schema changes in PATCH 13.