mbox series

[0/3] migration/postcopy: replace have_listen_thread check with PostcopyState check

Message ID 20191006000249.29926-1-richardw.yang@linux.intel.com (mailing list archive)
Headers show
Series migration/postcopy: replace have_listen_thread check with PostcopyState check | expand

Message

Wei Yang Oct. 6, 2019, 12:02 a.m. UTC
have_listen_thread is used to be a indication of whether postcopy thread is
running. Since we use PostcopyState to record state and the postcopy thread
only runs when postcopy_is_running(), we can leverage the PostcopyState to
replace the meaning of have_listen_thread.

To do so, two preparation cleanup is included.

Wei Yang (3):
  migration/postcopy: mis->have_listen_thread check will never be
    touched
  migration/postcopy: postpone setting PostcopyState to END
  migration/postcopy: replace have_listen_thread check with
    PostcopyState check

 migration/migration.h    |  1 -
 migration/postcopy-ram.c |  2 --
 migration/ram.c          |  2 +-
 migration/ram.h          |  1 +
 migration/savevm.c       | 11 +++--------
 5 files changed, 5 insertions(+), 12 deletions(-)

Comments

Dr. David Alan Gilbert Oct. 11, 2019, 1:58 p.m. UTC | #1
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> have_listen_thread is used to be a indication of whether postcopy thread is
> running. Since we use PostcopyState to record state and the postcopy thread
> only runs when postcopy_is_running(), we can leverage the PostcopyState to
> replace the meaning of have_listen_thread.
> 
> To do so, two preparation cleanup is included.

1,2 queued (2 with fixup for original postcopy_state_set)

> 
> Wei Yang (3):
>   migration/postcopy: mis->have_listen_thread check will never be
>     touched
>   migration/postcopy: postpone setting PostcopyState to END
>   migration/postcopy: replace have_listen_thread check with
>     PostcopyState check
> 
>  migration/migration.h    |  1 -
>  migration/postcopy-ram.c |  2 --
>  migration/ram.c          |  2 +-
>  migration/ram.h          |  1 +
>  migration/savevm.c       | 11 +++--------
>  5 files changed, 5 insertions(+), 12 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK