From patchwork Fri Oct 11 20:55:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 11186373 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5116D17EE for ; Fri, 11 Oct 2019 20:57:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3184F2067B for ; Fri, 11 Oct 2019 20:57:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3184F2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:56916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJ1yN-0007hA-5T for patchwork-qemu-devel@patchwork.kernel.org; Fri, 11 Oct 2019 16:57:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51708) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJ1xR-0006Uq-S6 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 16:56:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJ1xQ-0001NZ-TT for qemu-devel@nongnu.org; Fri, 11 Oct 2019 16:56:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54024) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iJ1xO-0001Ml-8k; Fri, 11 Oct 2019 16:56:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 81CA530624D0; Fri, 11 Oct 2019 20:56:13 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.118.111]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60E8E60A97; Fri, 11 Oct 2019 20:56:12 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PATCH 0/4] qemu-img/io/nbd: Support help options for --object Date: Fri, 11 Oct 2019 22:55:47 +0200 Message-Id: <20191011205551.32149-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 11 Oct 2019 20:56:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" This series fixes that the tools don't consider help options for --object and just treat them as regular object properties. For example: $ ./qemu-io --object secret,help qemu-io: Parameter 'id' is missing With these patches, we get the expected behaviour like in the system emulator. Kevin Wolf (4): vl: Split off user_creatable_print_help() qemu-io: Support help options for --object qemu-img: Support help options for --object qemu-nbd: Support help options for --object include/qom/object_interfaces.h | 12 +++++++ qemu-img.c | 34 +++++++++++------- qemu-io.c | 9 ++++- qemu-nbd.c | 9 ++++- qom/object_interfaces.c | 61 +++++++++++++++++++++++++++++++++ vl.c | 52 +--------------------------- 6 files changed, 111 insertions(+), 66 deletions(-)