From patchwork Mon Oct 14 11:51:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 11188421 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A638A14E5 for ; Mon, 14 Oct 2019 11:57:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 861E7207FF for ; Mon, 14 Oct 2019 11:57:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 861E7207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:48308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJyz0-00053u-Nl for patchwork-qemu-devel@patchwork.kernel.org; Mon, 14 Oct 2019 07:57:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52486) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJysy-0008BK-80 for qemu-devel@nongnu.org; Mon, 14 Oct 2019 07:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJysx-0005mb-4Z for qemu-devel@nongnu.org; Mon, 14 Oct 2019 07:51:36 -0400 Received: from relay.sw.ru ([185.231.240.75]:57688) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iJyst-0005eW-Op; Mon, 14 Oct 2019 07:51:31 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iJyso-0002Oa-SQ; Mon, 14 Oct 2019 14:51:27 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap Date: Mon, 14 Oct 2019 14:51:24 +0300 Message-Id: <20191014115126.15360-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Hi all! Here is a fix for persistent bitmaps managing: we must check existent but not yet stored bitmaps for qcow2-related constraints, like maximum number of bitmaps in qcow2 image. v2: 01: change assertion to error-return at function start Be free to add Reported-by: aihua liang Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1712636 if it's appropriate 02: new test Ohh, it takes about 4 minutes. Be free to drop it, as I doubt that it worth to have. The case is simple, we may live without a test. Vladimir Sementsov-Ogievskiy (2): qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap iotests: add 269 to check maximum of bitmaps in qcow2 block/qcow2-bitmap.c | 41 +++++++++++++++------------------ tests/qemu-iotests/269 | 47 ++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/269.out | 3 +++ tests/qemu-iotests/group | 1 + 4 files changed, 69 insertions(+), 23 deletions(-) create mode 100755 tests/qemu-iotests/269 create mode 100644 tests/qemu-iotests/269.out