[v2,0/2] s390x/cpumodel: Introduce dynamic feature group

Message

David Hildenbrand Nov. 25, 2019, 5:20 p.m. UTC

This thread was previously called:
    s390x/cpumodel: Introduce "best" model variants

There was recently a discussion regarding CPU model versions. That concept
does not fit s390x where we have a lot of feature variability. I
proposed an alternative approach in [1], which might work for x86 as well
(but I am not sure if x86 still can or wants to switch to that), and
requires only little changes in upper layers.

[1] and patch #2 contains more information on the motivation for this. It
allows, for example, to specify/expand "best feature set possible on this
accelerator, hw and, firmware"

"
    Get the best possible feature set (e.g., excluding deprecated features)
    for a CPU definition in the configuration
        -cpu z14,all-features=off,recommended-features=on

    Get the maximum possible feature set (e.g., including deprecated
    features) for a CPU definition in the configuration ("everything that
    could be enabled"):
        -cpu z14,all-features=off,available-features=on

    Get all valid features for a CPU definition:
        -cpu z14,all-features=on
"

v1 -> v2:
- Use dynamic feature groups instead of new models

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg07222.html

Cc: Daniel P. Berrangé <[e-mail]>
Cc: Markus Armbruster <[e-mail]>
Cc: Jiri Denemark <[e-mail]>
Cc: Eduardo Habkost <[e-mail]>
Cc: Michael Mueller <[e-mail]>
Cc: Peter Maydell <[e-mail]>

David Hildenbrand (2):
  s390x/cpumodel: Factor out CPU feature dependencies
  s390x/cpumodel: Introduce dynamic feature groups

 target/s390x/cpu_features.c |  29 +++++
 target/s390x/cpu_features.h |  14 +++
 target/s390x/cpu_models.c   | 242 +++++++++++++++++++++++++++---------
 3 files changed, 228 insertions(+), 57 deletions(-)

Comments

[e-mail] Nov. 25, 2019, 11:20 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/2] s390x/cpumodel: Introduce dynamic feature group
Type: series
Message-id: [e-mail]

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
abb1bba s390x/cpumodel: Introduce dynamic feature groups
f8b362f s390x/cpumodel: Factor out CPU feature dependencies

=== OUTPUT BEGIN ===
1/2 Checking commit f8b362f40451 (s390x/cpumodel: Factor out CPU feature dependencies)
2/2 Checking commit abb1bba82287 (s390x/cpumodel: Introduce dynamic feature groups)
WARNING: line over 80 characters
#82: FILE: target/s390x/cpu_features.c:186:
+    DYN_FEAT_GROUP_INIT("all-features", ALL, "Features valid for a CPU definition"),

ERROR: line over 90 characters
#84: FILE: target/s390x/cpu_features.c:188:
+    DYN_FEAT_GROUP_INIT("recommended-features", RECOMMENDED, "Available, recommended features supported by the accelerator in the current host for a CPU definition"),

ERROR: line over 90 characters
#86: FILE: target/s390x/cpu_features.c:190:
+    DYN_FEAT_GROUP_INIT("available-features", AVAILABLE, "Available features supported by the accelerator in the current host for a CPU definition"),

total: 2 errors, 1 warnings, 209 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]