| Message ID | 20191227134101.244496-1-wainersm@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | python/qemu: qmp: Fix, delint and improvements | expand |
On 12/27/19 2:40 PM, Wainer dos Santos Moschetta wrote: > I started fixing an issue on exception handling which in some places > currently use the deprecated (in Python 3.3) `socket.error`. Then I > ended up delinting the module code and making some improvements. > > Git: > - Tree: https://github.com/wainersm/qemu > - Branch: python_qmp_sockets_error > > CI: > - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/629772066 > Failure not related with this series. Even QEMU master branch is > failing to build when `--without-default-devices --disable-user`. > > Wainer dos Santos Moschetta (5): > python/qemu: qmp: Replace socket.error with OSError > python/qemu: Delint the qmp module > python/qemu: qmp: Make accept()'s timeout configurable > python/qemu: qmp: Make QEMUMonitorProtocol a context manager > python/qemu: qmp: Remove unnused attributes > > python/qemu/qmp.py | 91 +++++++++++++++++++++++++++++++++------------- > 1 file changed, 65 insertions(+), 26 deletions(-) > Thanks, applied patches 1, 2 and 5 to my python-next tree: https://gitlab.com/philmd/qemu/commits/python-next
On 1/30/20 8:41 PM, Philippe Mathieu-Daudé wrote: > On 12/27/19 2:40 PM, Wainer dos Santos Moschetta wrote: >> I started fixing an issue on exception handling which in some places >> currently use the deprecated (in Python 3.3) `socket.error`. Then I >> ended up delinting the module code and making some improvements. >> >> Git: >> - Tree: https://github.com/wainersm/qemu >> - Branch: python_qmp_sockets_error >> >> CI: >> - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/629772066 >> Failure not related with this series. Even QEMU master branch is >> failing to build when `--without-default-devices --disable-user`. >> >> Wainer dos Santos Moschetta (5): >> python/qemu: qmp: Replace socket.error with OSError >> python/qemu: Delint the qmp module >> python/qemu: qmp: Make accept()'s timeout configurable >> python/qemu: qmp: Make QEMUMonitorProtocol a context manager >> python/qemu: qmp: Remove unnused attributes >> >> python/qemu/qmp.py | 91 +++++++++++++++++++++++++++++++++------------- >> 1 file changed, 65 insertions(+), 26 deletions(-) >> > > Thanks, applied patches 1, 2 and 5 to my python-next tree: > https://gitlab.com/philmd/qemu/commits/python-next > > Great, I was going to ask you that. Patches 3 and 4 are likely to need a respin. Thanks Philippe!