[0/2] aspeed/scu: Implement chip id register

Message

Joel Stanley Jan. 21, 2020, 1:33 a.m. UTC

This implements the chip id register in the SCU for the ast2500 and
ast2600. The first patch is a cleanup to separate out ast2400 and
ast2500 functionality.

Joel Stanley (2):
  aspeed/scu: Create separate write callbacks
  aspeed/scu: Implement chip ID register

 hw/misc/aspeed_scu.c | 93 +++++++++++++++++++++++++++++++++-----------
 1 file changed, 70 insertions(+), 23 deletions(-)

Comments

Cédric Le Goater Jan. 21, 2020, 7:23 a.m. UTC | #1

On 1/21/20 2:33 AM, Joel Stanley wrote:
> This implements the chip id register in the SCU for the ast2500 and
> ast2600. The first patch is a cleanup to separate out ast2400 and
> ast2500 functionality.

These patches apply cleanly on top of :

	[v3,0/5] aspeed: extensions and fixes 
	http://patchwork.ozlabs.org/cover/1222667/

Thanks,

C.

> 
> Joel Stanley (2):
>   aspeed/scu: Create separate write callbacks
>   aspeed/scu: Implement chip ID register
> 
>  hw/misc/aspeed_scu.c | 93 +++++++++++++++++++++++++++++++++-----------
>  1 file changed, 70 insertions(+), 23 deletions(-)
>

Cédric Le Goater Feb. 17, 2020, 9:29 a.m. UTC | #2

On 1/21/20 2:33 AM, Joel Stanley wrote:
> This implements the chip id register in the SCU for the ast2500 and
> ast2600. The first patch is a cleanup to separate out ast2400 and
> ast2500 functionality.
> 
> Joel Stanley (2):
>   aspeed/scu: Create separate write callbacks
>   aspeed/scu: Implement chip ID register
> 
>  hw/misc/aspeed_scu.c | 93 +++++++++++++++++++++++++++++++++-----------
>  1 file changed, 70 insertions(+), 23 deletions(-)
> 

Hello Peter,

I see you have merged patches more recent than this series. Do you
plan to take them later on ? They apply correctly on mainline.

Thanks,

C.

Peter Maydell Feb. 17, 2020, 10:24 a.m. UTC | #3

On Mon, 17 Feb 2020 at 09:29, Cédric Le Goater <[e-mail]> wrote:
>
> On 1/21/20 2:33 AM, Joel Stanley wrote:
> > This implements the chip id register in the SCU for the ast2500 and
> > ast2600. The first patch is a cleanup to separate out ast2400 and
> > ast2500 functionality.
> >
> > Joel Stanley (2):
> >   aspeed/scu: Create separate write callbacks
> >   aspeed/scu: Implement chip ID register
> >
> >  hw/misc/aspeed_scu.c | 93 +++++++++++++++++++++++++++++++++-----------
> >  1 file changed, 70 insertions(+), 23 deletions(-)
> >
>
> Hello Peter,
>
> I see you have merged patches more recent than this series. Do you
> plan to take them later on ? They apply correctly on mainline.

Sorry, these didn't get onto my to-review queue for some reason;
I've just put them into target-arm.next.

thanks
-- PMM