[v1,0/5] plugins/next

Message

Alex Bennée Feb. 7, 2020, 3:01 p.m. UTC

Hi,

A few bits and pieces for plugin cleanup. The most major thing in this
series is tweaking the riscv decoder to only load the instruction
bytes it needs.

Alex Bennée (3):
  docs/devel: document query handle lifetimes
  target/riscv: progressively load the instruction during decode
  tests/plugins: make howvec clean-up after itself.

Chen Qun (1):
  tests/plugin: prevent uninitialized warning

Emilio G. Cota (1):
  plugins/core: add missing break in cb_to_tcg_flags

 docs/devel/tcg-plugins.rst | 13 +++++++++++--
 plugins/core.c             |  1 +
 target/riscv/translate.c   | 39 +++++++++++++++++++-------------------
 tests/plugin/bb.c          |  6 +++---
 tests/plugin/howvec.c      | 12 +++++++++++-
 tests/plugin/insn.c        |  3 +--
 6 files changed, 47 insertions(+), 27 deletions(-)

Comments

[e-mail] Feb. 7, 2020, 8:55 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH  v1 0/5] plugins/next
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
41b2c3d tests/plugins: make howvec clean-up after itself.
107cac9 target/riscv: progressively load the instruction during decode
f4d9c2a tests/plugin: prevent uninitialized warning
f0c6141 plugins/core: add missing break in cb_to_tcg_flags
1b7fce4 docs/devel: document query handle lifetimes

=== OUTPUT BEGIN ===
1/5 Checking commit 1b7fce4dfde8 (docs/devel: document query handle lifetimes)
2/5 Checking commit f0c614169421 (plugins/core: add missing break in cb_to_tcg_flags)
3/5 Checking commit f4d9c2a8daaa (tests/plugin: prevent uninitialized warning)
4/5 Checking commit 107cac90cc74 (target/riscv: progressively load the instruction during decode)
ERROR: line over 90 characters
#110: FILE: target/riscv/translate.c:726:
+        opcode32 = deposit32(opcode32, 16, 16, translator_lduw(env, ctx->base.pc_next + 2));

total: 1 errors, 0 warnings, 103 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 41b2c3dc8d77 (tests/plugins: make howvec clean-up after itself.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 7, 2020, 9:27 p.m. UTC | #2

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

-...........................................................................................
+........................................................................E..................
+======================================================================
+ERROR: test_pause (__main__.TestSingleDriveUnalignedLength)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+  File "041", line 106, in test_pause
---
 Ran 91 tests
 
-OK
+FAILED (errors=1)
  TEST    iotest-qcow2: 042
  TEST    iotest-qcow2: 043
  TEST    iotest-qcow2: 046
---
  TEST    iotest-qcow2: 283
Failures: 041
Failed 1 of 116 iotests
make: *** [check-tests/check-block.sh] Error 1
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 664, in <module>
    sys.exit(main())
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=44d027b6d11441338b7aff5d8515d6f2', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-82gd494d/src/docker-src.2020-02-07-16.16.22.27117:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=44d027b6d11441338b7aff5d8515d6f2
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-82gd494d/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    11m31.386s
user    0m8.696s


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]