mbox series

[v2,0/2] delete virtio queues in vhost-user-blk-unrealize

Message ID 20200224041336.30790-1-pannengyuan@huawei.com (mailing list archive)
Headers show
Series delete virtio queues in vhost-user-blk-unrealize | expand

Message

Pan Nengyuan Feb. 24, 2020, 4:13 a.m. UTC
From: Pan Nengyuan <pannengyuan@huawei.com>

This series patch fix memleaks when detaching vhost-user-blk device.
1. use old virtio_del_queue to fix memleaks, it's easier for stable branches to merge.
   As the discussion in https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02903.html

2. convert virtio_del_queue to the new one(virtio_delete_queue).

v2->v1: rename vqs to vhost_vqs to avoid confusing with virtqs (suggented by Stefan Hajnoczi)

Pan Nengyuan (2):
  vhost-user-blk: delete virtioqueues in unrealize to fix memleaks
  vhost-use-blk: convert to new virtio_delete_queue

 hw/block/vhost-user-blk.c          | 23 +++++++++++++++++------
 include/hw/virtio/vhost-user-blk.h |  3 ++-
 2 files changed, 19 insertions(+), 7 deletions(-)

Comments

Stefan Hajnoczi Feb. 24, 2020, 11:36 a.m. UTC | #1
On Mon, Feb 24, 2020 at 12:13:34PM +0800, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
> 
> This series patch fix memleaks when detaching vhost-user-blk device.
> 1. use old virtio_del_queue to fix memleaks, it's easier for stable branches to merge.
>    As the discussion in https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02903.html
> 
> 2. convert virtio_del_queue to the new one(virtio_delete_queue).
> 
> v2->v1: rename vqs to vhost_vqs to avoid confusing with virtqs (suggented by Stefan Hajnoczi)
> 
> Pan Nengyuan (2):
>   vhost-user-blk: delete virtioqueues in unrealize to fix memleaks
>   vhost-use-blk: convert to new virtio_delete_queue
> 
>  hw/block/vhost-user-blk.c          | 23 +++++++++++++++++------
>  include/hw/virtio/vhost-user-blk.h |  3 ++-
>  2 files changed, 19 insertions(+), 7 deletions(-)
> 
> -- 
> 2.18.2
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>