[v3,00/16] : hw/i386/vmport: Bug fixes and improvements

Message

Liran Alon March 12, 2020, 4:54 p.m. UTC

Hi,

This series aims to fix several bugs in VMPort and improve it by supporting
more VMPort commands and make command results more configurable to
user via QEMU command-line.

This functionality was proven to be useful to run various VMware VMs
when attempting to run them as-is on top of QEMU/KVM.

For more details, see commit messages.

Regards,
-Liran

v1->v2:
* Fix coding convention [Patchew Bot & MST].
* Create new header file for vmport.h [MST].
* Move KVM_APIC_BUS_FREQUENCY from linux-headers/asm-x86/kvm.h
  auto-generated header [MST]
* Elaborate more that vmx-version refers to the VMware userspace
  VMM in commit message. [MST]
* Use le32_to_cpu() on BIOS_UUID vmport command. [MST]
* Introduce VMPort compatability version property to maintain migration
  compatibility. [MST]

v2->v3:
- Repalce VMPort compatability version property with multiple boolean
  compatability properties. [MST]
- Prefix "vmx-*" properties with "vmware-vmx-*" to avoid confusion with
  Intel VT-x short name. Prefix suggested by MST. [MST]
- Remove VMX_Type enum and instead hard-code default vmware-vmx-type
  value and only reference open-vm-tools for rest of values. [MST]
- Add reference (link) to VMware open-vm-tools code. [MST]

Comments

Paolo Bonzini May 21, 2020, 4:15 p.m. UTC | #1

On 12/03/20 17:54, Liran Alon wrote:
> Hi,
> 
> This series aims to fix several bugs in VMPort and improve it by supporting
> more VMPort commands and make command results more configurable to
> user via QEMU command-line.
> 
> This functionality was proven to be useful to run various VMware VMs
> when attempting to run them as-is on top of QEMU/KVM.
> 
> For more details, see commit messages.
> 
> Regards,
> -Liran
> 
> v1->v2:
> * Fix coding convention [Patchew Bot & MST].
> * Create new header file for vmport.h [MST].
> * Move KVM_APIC_BUS_FREQUENCY from linux-headers/asm-x86/kvm.h
>   auto-generated header [MST]
> * Elaborate more that vmx-version refers to the VMware userspace
>   VMM in commit message. [MST]
> * Use le32_to_cpu() on BIOS_UUID vmport command. [MST]
> * Introduce VMPort compatability version property to maintain migration
>   compatibility. [MST]
> 
> v2->v3:
> - Repalce VMPort compatability version property with multiple boolean
>   compatability properties. [MST]
> - Prefix "vmx-*" properties with "vmware-vmx-*" to avoid confusion with
>   Intel VT-x short name. Prefix suggested by MST. [MST]
> - Remove VMX_Type enum and instead hard-code default vmware-vmx-type
>   value and only reference open-vm-tools for rest of values. [MST]
> - Add reference (link) to VMware open-vm-tools code. [MST]
> 

I actually agree with Liran on most comments, so I just dropped the
GETTIME and GETTIMEFULL functionality and queued everything else.

Thanks,

Paolo