From patchwork Fri Apr 3 07:13:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Auger X-Patchwork-Id: 11471965 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F20AE92A for ; Fri, 3 Apr 2020 07:14:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C853920787 for ; Fri, 3 Apr 2020 07:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gucKaM+E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C853920787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:51158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKGXH-0005NB-WE for patchwork-qemu-devel@patchwork.kernel.org; Fri, 03 Apr 2020 03:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36894) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKGWN-0003dN-7R for qemu-devel@nongnu.org; Fri, 03 Apr 2020 03:13:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKGWL-0003xK-UQ for qemu-devel@nongnu.org; Fri, 03 Apr 2020 03:13:43 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:43390 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKGWL-0003x2-RN for qemu-devel@nongnu.org; Fri, 03 Apr 2020 03:13:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585898021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ozI3eRo5MHiGvv1ljzippiG2WaPze3ybClTx3Rcz8Hg=; b=gucKaM+Evw1VCrklP5gh2n9N8BqJbQmPOi5pwoknz0WvydlLR5uVc4MUt1BNgROOD18wnn AvK107NLQ3bAw2/v7vgeFRdJdhkRSrWF1Wn3FqwhNU7uiMNvRgCKgfo94e0TUR4PTwd9sN Xaoq0WeQ2GWxQamFoVvJPCbS5m69GWU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-2Z4fimH_O9u0RX99QlL5cg-1; Fri, 03 Apr 2020 03:13:37 -0400 X-MC-Unique: 2Z4fimH_O9u0RX99QlL5cg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B85568017F3; Fri, 3 Apr 2020 07:13:35 +0000 (UTC) Received: from laptop.redhat.com (ovpn-112-58.ams2.redhat.com [10.36.112.58]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2716948; Fri, 3 Apr 2020 07:13:29 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [kvm-unit-tests PATCH v4 00/12] KVM: arm64: PMUv3 Event Counter Tests Date: Fri, 3 Apr 2020 09:13:14 +0200 Message-Id: <20200403071326.29932-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, andrew.murray@arm.com, drjones@redhat.com, alexandru.elisei@arm.com, andre.przywara@arm.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" This series implements tests exercising the PMUv3 event counters. It tests both the 32-bit and 64-bit versions. Overflow interrupts also are checked. Those tests only are written for arm64. It allowed to reveal some issues related to SW_INCR implementation (esp. related to 64-bit implementation), some problems related to 32-bit <-> 64-bit transitions and consistency of enabled states of odd and event counters. Fixes now are upstream. Drew kindly provided "arm64: Provide read/write_sysreg_s". All PMU tests can be launched with: ./run_tests.sh -g pmu Tests also can be launched individually. For example: ./arm-run arm/pmu.flat -append 'pmu-chained-sw-incr' With KVM: - On TX2, I have some random failures due to MEM_ACCESS event measured with a great disparity. This is not observed on other machines I have access to. The series can be found at: https://github.com/eauger/kut/tree/pmu_event_counters_v4 History: v3 -> v4: - Drew reported that some report messages were repeated. This version makes sure all messages are different. v2 -> v3: - Took into account numerous comments from Drew - Applied Andre's R-b when code has not changed too much - Don't check PMCR.IMP anymore - better handling of version - put simple SW_INCR tests for easier TCG testing v1 -> v2: - Took into account Andre's comments except I did not use cnbz in the mem_access_loop() and I did not use @loop directly. Those changes had side effects I cannot explain on the tests. Anyway I think this can be improved later on. - removed [kvm-unit-tests PATCH 09/10] arm/arm64: gic: Introduce setup_irq() helper RFC -> v1: - Use new report() proto - Style cleanup - do not warn about ARM spec recommendations - add a comment about PMCEID0/1 splits Andrew Jones (1): arm64: Provide read/write_sysreg_s Eric Auger (11): arm: pmu: Let pmu tests take a sub-test parameter arm: pmu: Don't check PMCR.IMP anymore arm: pmu: Add a pmu struct arm: pmu: Introduce defines for PMU versions arm: pmu: Check Required Event Support arm: pmu: Basic event counter Tests arm: pmu: Test SW_INCR event count arm: pmu: Test chained counters arm: pmu: test 32-bit <-> 64-bit transitions arm: gic: Introduce gic_irq_set_clr_enable() helper arm: pmu: Test overflow interrupts arm/pmu.c | 838 +++++++++++++++++++++++++++++++++++++++-- arm/unittests.cfg | 61 ++- lib/arm/asm/gic.h | 4 + lib/arm/gic.c | 31 ++ lib/arm64/asm/sysreg.h | 17 + lib/bitops.h | 3 + 6 files changed, 917 insertions(+), 37 deletions(-)