| Message ID | 20200408125816.955-1-miaoyubo@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | pci_expander_brdige:acpi:Support pxb-pcie for ARM | expand |
Patchew URL: https://patchew.org/QEMU/20200408125816.955-1-miaoyubo@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v6 0/8] pci_expander_brdige:acpi:Support pxb-pcie for ARM Message-id: 20200408125816.955-1-miaoyubo@huawei.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 6a2dfea unit-test: Add the binary file and clear diff.h 3b6a166 unit-test: Add testcase for pxb c5d159c unit-test: The files changed. e3dd89e acpi: Align the size to 128k 043f5fd acpi: Refactor the source of host bridge and build tables for pxb 22f4d5c acpi: Extract crs build form acpi_build.c 3c167be fw_cfg: Write the extra roots into the fw_cfg e277786 acpi: Extract two APIs from acpi_dsdt_add_pci === OUTPUT BEGIN === 1/8 Checking commit e27778652473 (acpi: Extract two APIs from acpi_dsdt_add_pci) 2/8 Checking commit 3c167be7ea51 (fw_cfg: Write the extra roots into the fw_cfg) 3/8 Checking commit 22f4d5c3eb1d (acpi: Extract crs build form acpi_build.c) 4/8 Checking commit 043f5fd30894 (acpi: Refactor the source of host bridge and build tables for pxb) 5/8 Checking commit e3dd89e213dc (acpi: Align the size to 128k) 6/8 Checking commit c5d159c8a6b1 (unit-test: The files changed.) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c found total: 2 errors, 0 warnings, 2 lines checked Patch 6/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/8 Checking commit 3b6a166e7ece (unit-test: Add testcase for pxb) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c found total: 2 errors, 0 warnings, 76 lines checked Patch 7/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/8 Checking commit 6a2dfea13ba3 (unit-test: Add the binary file and clear diff.h) ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/virt/DSDT.pxb and tests/qtest/bios-tables-test.c found WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100644 ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c found ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-tables-test-allowed-diff.h and tests/qtest/bios-tables-test.c found total: 3 errors, 1 warnings, 1 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200408125816.955-1-miaoyubo@huawei.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
From: miaoyubo <miaoyubo@huawei.com> Changes with v5 v5->v6: stat crs_range_insert in aml_build.h Changes with v4 v4->v5: Not using specific resources for PXB. Instead, the resources for pxb are composed of the bar space of the pci-bridge/pcie-root-port behined it and the config space of devices behind it. Only if the bios(uefi for arm) support multiple roots, configure space of devices behind pxbs could be obtained. The uefi work is updated for discussion by the following link: https://edk2.groups.io/g/devel/message/56901?p=,,,20,0,0,0::Created,,add+extra+roots+for+Arm,20,2,0,72723351 [PATCH] ArmVirtPkg/FdtPciHostBridgeLib: add extra roots for Arm. Currently pxb-pcie is not supported by arm, the reason for it is pxb-pcie is not described in DSDT table and only one main host bridge is described in acpi tables, which means it is not impossible to present different io numas for different devices. This series of patches make arm to support PXB-PCIE. Users can configure pxb-pcie with certain numa, Example command is: -device pxb-pcie,id=pci.7,bus_nr=128,numa_node=0,bus=pcie.0,addr=0x9 miaoyubo (8): acpi: Extract two APIs from acpi_dsdt_add_pci fw_cfg: Write the extra roots into the fw_cfg acpi: Extract crs build form acpi_build.c acpi: Refactor the source of host bridge and build tables for pxb acpi: Align the size to 128k unit-test: The files changed. unit-test: Add testcase for pxb unit-test: Add the binary file and clear diff.h hw/acpi/aml-build.c | 275 +++++++++++++++++++++++++++++++ hw/arm/virt-acpi-build.c | 251 ++++++++++++++++++++++------- hw/arm/virt.c | 23 +++ hw/i386/acpi-build.c | 285 --------------------------------- include/hw/acpi/aml-build.h | 25 +++ tests/data/acpi/virt/DSDT.pxb | Bin 0 -> 7802 bytes tests/qtest/bios-tables-test.c | 58 ++++++- 7 files changed, 566 insertions(+), 351 deletions(-) create mode 100644 tests/data/acpi/virt/DSDT.pxb