mbox series

[v4,0/6] s390x/vfio-ccw: Channel Path Handling [QEMU]

Message ID 20200505125757.98209-1-farman@linux.ibm.com (mailing list archive)
Headers show
Series s390x/vfio-ccw: Channel Path Handling [QEMU] | expand

Message

Eric Farman May 5, 2020, 12:57 p.m. UTC
Here is a new pass at the channel-path handling code for vfio-ccw,
to take advantage of the corresponding kernel patches posted here:

https://lore.kernel.org/kvm/20200505122745.53208-1-farman@linux.ibm.com/

I have all the main comments from v3 addressed, though I have a
couple of additional patches that do some further cleanups
(like, a generic callback for stsch) that weren't baked enough
to include here. They're working fine, but need some cleanups
(e.g., fixups vs standalone patches) before they're ready for
submission. Just wanted to have the basic QEMU code to go with
the new KVM series.

Changes are listed in git notes for the individual patches.

v3: https://lore.kernel.org/qemu-devel/20200417023440.70514-1-farman@linux.ibm.com/
v2: https://lore.kernel.org/qemu-devel/20200206214509.16434-1-farman@linux.ibm.com/
v1: https://lore.kernel.org/qemu-devel/20191115033437.37926-1-farman@linux.ibm.com/

Eric Farman (3):
  vfio-ccw: Refactor cleanup of regions
  vfio-ccw: Refactor ccw irq handler
  s390x/css: Refactor the css_queue_crw() routine

Farhan Ali (3):
  linux-headers: update
  vfio-ccw: Add support for the schib region
  vfio-ccw: Add support for the CRW region and IRQ

 hw/s390x/css.c                 |  57 ++++++---
 hw/s390x/s390-ccw.c            |  21 ++++
 hw/vfio/ccw.c                  | 208 +++++++++++++++++++++++++++++----
 include/hw/s390x/css.h         |   4 +-
 include/hw/s390x/s390-ccw.h    |   1 +
 linux-headers/linux/vfio.h     |   3 +
 linux-headers/linux/vfio_ccw.h |  18 +++
 target/s390x/ioinst.c          |   3 +-
 8 files changed, 274 insertions(+), 41 deletions(-)

Comments

Cornelia Huck May 6, 2020, 4:03 p.m. UTC | #1
On Tue,  5 May 2020 14:57:51 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> Here is a new pass at the channel-path handling code for vfio-ccw,
> to take advantage of the corresponding kernel patches posted here:
> 
> https://lore.kernel.org/kvm/20200505122745.53208-1-farman@linux.ibm.com/
> 
> I have all the main comments from v3 addressed, though I have a
> couple of additional patches that do some further cleanups
> (like, a generic callback for stsch) that weren't baked enough
> to include here. They're working fine, but need some cleanups
> (e.g., fixups vs standalone patches) before they're ready for
> submission. Just wanted to have the basic QEMU code to go with
> the new KVM series.

This also looks good to me now, cleanup on top sounds good.

Would not mind some further review here, either :) This would need to
wait for a proper header update before queuing to s390-next, anyway.
Cornelia Huck June 16, 2020, 5:01 p.m. UTC | #2
On Tue,  5 May 2020 14:57:51 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> Here is a new pass at the channel-path handling code for vfio-ccw,
> to take advantage of the corresponding kernel patches posted here:
> 
> https://lore.kernel.org/kvm/20200505122745.53208-1-farman@linux.ibm.com/
> 
> I have all the main comments from v3 addressed, though I have a
> couple of additional patches that do some further cleanups
> (like, a generic callback for stsch) that weren't baked enough
> to include here. They're working fine, but need some cleanups
> (e.g., fixups vs standalone patches) before they're ready for
> submission. Just wanted to have the basic QEMU code to go with
> the new KVM series.
> 
> Changes are listed in git notes for the individual patches.
> 
> v3: https://lore.kernel.org/qemu-devel/20200417023440.70514-1-farman@linux.ibm.com/
> v2: https://lore.kernel.org/qemu-devel/20200206214509.16434-1-farman@linux.ibm.com/
> v1: https://lore.kernel.org/qemu-devel/20191115033437.37926-1-farman@linux.ibm.com/
> 
> Eric Farman (3):
>   vfio-ccw: Refactor cleanup of regions
>   vfio-ccw: Refactor ccw irq handler
>   s390x/css: Refactor the css_queue_crw() routine
> 
> Farhan Ali (3):
>   linux-headers: update
>   vfio-ccw: Add support for the schib region
>   vfio-ccw: Add support for the CRW region and IRQ
> 
>  hw/s390x/css.c                 |  57 ++++++---
>  hw/s390x/s390-ccw.c            |  21 ++++
>  hw/vfio/ccw.c                  | 208 +++++++++++++++++++++++++++++----
>  include/hw/s390x/css.h         |   4 +-
>  include/hw/s390x/s390-ccw.h    |   1 +
>  linux-headers/linux/vfio.h     |   3 +
>  linux-headers/linux/vfio_ccw.h |  18 +++
>  target/s390x/ioinst.c          |   3 +-
>  8 files changed, 274 insertions(+), 41 deletions(-)
> 

Thanks, replaced patch 1 with a proper headers update against 5.8-rc1
and applied.