mbox series

[v6,00/20] nvme: small fixes, refactoring and cleanups

Message ID 20200514044611.734782-1-its@irrelevant.dk (mailing list archive)
Headers show
Series nvme: small fixes, refactoring and cleanups | expand

Message

Klaus Jensen May 14, 2020, 4:45 a.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>

Changes since v5
~~~~~~~~~~~~~~~~
* Prefixed all patches with "hw/block/nvme" to avoid confusion with the
  nvme block driver.

* Added patch two patches:

    hw/block/nvme: fix pin-based interrupt behavior
    hw/block/nvme: allow use of any valid msix vector

  These were previously posted separately, but I'm including them in this
  series since I didnt get any response on the separate series anyway.

* Fixed Maxim's email in the R-b on "hw/block/nvme: refactor
  nvme_addr_read"


Klaus Jensen (20):
  hw/block/nvme: fix pci doorbell size calculation
  hw/block/nvme: rename trace events to pci_nvme
  hw/block/nvme: remove superfluous breaks
  hw/block/nvme: move device parameters to separate struct
  hw/block/nvme: use constants in identify
  hw/block/nvme: refactor nvme_addr_read
  hw/block/nvme: fix pin-based interrupt behavior
  hw/block/nvme: allow use of any valid msix vector
  hw/block/nvme: add max_ioqpairs device parameter
  hw/block/nvme: remove redundant cmbloc/cmbsz members
  hw/block/nvme: factor out property/constraint checks
  hw/block/nvme: factor out device state setup
  hw/block/nvme: factor out block backend setup
  hw/block/nvme: add namespace helpers
  hw/block/nvme: factor out namespace setup
  hw/block/nvme: factor out pci setup
  hw/block/nvme: factor out cmb setup
  hw/block/nvme: factor out pmr setup
  hw/block/nvme: do cmb/pmr init as part of pci init
  hw/block/nvme: factor out controller identify setup

 hw/block/nvme.c       | 555 ++++++++++++++++++++++++------------------
 hw/block/nvme.h       |  33 ++-
 hw/block/trace-events | 180 +++++++-------
 include/block/nvme.h  |   8 +
 4 files changed, 438 insertions(+), 338 deletions(-)

Comments

Kevin Wolf June 2, 2020, 3:31 p.m. UTC | #1
Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Changes since v5
> ~~~~~~~~~~~~~~~~
> * Prefixed all patches with "hw/block/nvme" to avoid confusion with the
>   nvme block driver.
> 
> * Added patch two patches:
> 
>     hw/block/nvme: fix pin-based interrupt behavior
>     hw/block/nvme: allow use of any valid msix vector
> 
>   These were previously posted separately, but I'm including them in this
>   series since I didnt get any response on the separate series anyway.
> 
> * Fixed Maxim's email in the R-b on "hw/block/nvme: refactor
>   nvme_addr_read"

Thanks, applied to the block branch.

Kevin
Maxim Levitsky June 7, 2020, 12:51 p.m. UTC | #2
On Tue, 2020-06-02 at 17:31 +0200, Kevin Wolf wrote:
> Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben:
> > From: Klaus Jensen <k.jensen@samsung.com>
> > 
> > Changes since v5
> > ~~~~~~~~~~~~~~~~
> > * Prefixed all patches with "hw/block/nvme" to avoid confusion with the
> >   nvme block driver.
> > 
> > * Added patch two patches:
> > 
> >     hw/block/nvme: fix pin-based interrupt behavior
> >     hw/block/nvme: allow use of any valid msix vector
> > 
> >   These were previously posted separately, but I'm including them in this
> >   series since I didnt get any response on the separate series anyway.
> > 
> > * Fixed Maxim's email in the R-b on "hw/block/nvme: refactor
> >   nvme_addr_read"
> 
> Thanks, applied to the block branch.

Great to see that code merged!

Note that while I kind of didn't review some of
the latest patches mostly becasue I was doing other things,
I do plan to keep on reviewing following patches in this activety.

Best regards,
	Maxim Levitsky

> 
> Kevin
> 
>
Maxim Levitsky June 7, 2020, 1:08 p.m. UTC | #3
On Sun, 2020-06-07 at 15:51 +0300, Maxim Levitsky wrote:
> On Tue, 2020-06-02 at 17:31 +0200, Kevin Wolf wrote:
> > Am 14.05.2020 um 06:45 hat Klaus Jensen geschrieben:
> > > From: Klaus Jensen <k.jensen@samsung.com>
> > > 
> > > Changes since v5
> > > ~~~~~~~~~~~~~~~~
> > > * Prefixed all patches with "hw/block/nvme" to avoid confusion with the
> > >   nvme block driver.
> > > 
> > > * Added patch two patches:
> > > 
> > >     hw/block/nvme: fix pin-based interrupt behavior
> > >     hw/block/nvme: allow use of any valid msix vector
> > > 
> > >   These were previously posted separately, but I'm including them in this
> > >   series since I didnt get any response on the separate series anyway.
> > > 
> > > * Fixed Maxim's email in the R-b on "hw/block/nvme: refactor
> > >   nvme_addr_read"
> > 
> > Thanks, applied to the block branch.
> 
> Great to see that code merged!
> 
> Note that while I kind of didn't review some of
> the latest patches mostly becasue I was doing other things,
> I do plan to keep on reviewing following patches in this activety.

And I am really tired today, when I look at all of the spelling mistakes I make today :-)

Best regards,
	Maxim Levitsky

> 
> Best regards,
> 	Maxim Levitsky
> 
> > Kevin
> > 
> >