| Message ID | 20200514123729.156283-1-frankja@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | pc-bios: s390x: Cleanup part 1 | expand |
Patchew URL: https://patchew.org/QEMU/20200514123729.156283-1-frankja@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200514123729.156283-1-frankja@linux.ibm.com
Subject: [PATCH v2 0/9] pc-bios: s390x: Cleanup part 1
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
5049518 pc-bios: s390x: Make u32 ptr check explicit
10aee2e pc-bios: s390x: Replace 0x00 with 0x0 or 0
168421e pc-bios: s390x: Use ebcdic2ascii table
51051af pc-bios: s390x: Move panic() into header and add infinite loop
9cf4c1c pc-bios: s390x: Use PSW masks where possible
e886137 pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
b10800a pc-bios: s390x: Get rid of magic offsets into the lowcore
a105085 pc-bios: s390x: Consolidate timing functions into time.h
3a83ebd pc-bios: s390x: cio.c cleanup and compile fix
=== OUTPUT BEGIN ===
1/9 Checking commit 3a83ebd32644 (pc-bios: s390x: cio.c cleanup and compile fix)
ERROR: code indent should never use tabs
#66: FILE: pc-bios/s390-ccw/cio.c:319:
+ .pfch = 1,^I/* QEMU's cio implementation requires prefetch */$
ERROR: code indent should never use tabs
#67: FILE: pc-bios/s390-ccw/cio.c:320:
+ .c64 = 1,^I/* QEMU's cio implementation requires 64-bit idaws */$
ERROR: code indent should never use tabs
#68: FILE: pc-bios/s390-ccw/cio.c:321:
+ .lpm = 0xFF,^I/* All paths allowed */$
total: 3 errors, 0 warnings, 63 lines checked
Patch 1/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/9 Checking commit a105085b3794 (pc-bios: s390x: Consolidate timing functions into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#102:
new file mode 100644
total: 0 errors, 1 warnings, 167 lines checked
Patch 2/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/9 Checking commit b10800afbdc8 (pc-bios: s390x: Get rid of magic offsets into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#29: FILE: pc-bios/s390-ccw/cio.h:127:
+ __u16 cssid:8;
^
ERROR: spaces required around that ':' (ctx:VxV)
#30: FILE: pc-bios/s390-ccw/cio.h:128:
+ __u16 reserved:4;
^
ERROR: spaces required around that ':' (ctx:VxV)
#31: FILE: pc-bios/s390-ccw/cio.h:129:
+ __u16 m:1;
^
ERROR: spaces required around that ':' (ctx:VxV)
#32: FILE: pc-bios/s390-ccw/cio.h:130:
+ __u16 ssid:2;
^
ERROR: spaces required around that ':' (ctx:VxV)
#33: FILE: pc-bios/s390-ccw/cio.h:131:
+ __u16 one:1;
^
total: 5 errors, 0 warnings, 37 lines checked
Patch 3/9 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/9 Checking commit e886137b0e3c (pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant)
5/9 Checking commit 9cf4c1c4626a (pc-bios: s390x: Use PSW masks where possible)
6/9 Checking commit 51051afe9a9e (pc-bios: s390x: Move panic() into header and add infinite loop)
7/9 Checking commit 168421e3c66e (pc-bios: s390x: Use ebcdic2ascii table)
8/9 Checking commit 10aee2ea877c (pc-bios: s390x: Replace 0x00 with 0x0 or 0)
9/9 Checking commit 5049518e6552 (pc-bios: s390x: Make u32 ptr check explicit)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200514123729.156283-1-frankja@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Thu, 14 May 2020 08:37:20 -0400 Janosch Frank <frankja@linux.ibm.com> wrote: > The bios is in dire need for a cleanup as there are still a lot of > magic constants being used throughout as well as duplicated code. > > In the first part of this series we consolidate constants and > functions, as well as doing some minor cleanups and fixes. > > The patches are available here: > https://github.com/frankjaa/qemu/pull/new/cleanup_bios > > v2: > * Included cio fixup to get rid of compile errors... > * Minor cosmetic fixes found by review > > Janosch Frank (9): > pc-bios: s390x: cio.c cleanup and compile fix > pc-bios: s390x: Consolidate timing functions into time.h > pc-bios: s390x: Get rid of magic offsets into the lowcore > pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant > pc-bios: s390x: Use PSW masks where possible > pc-bios: s390x: Move panic() into header and add infinite loop > pc-bios: s390x: Use ebcdic2ascii table > pc-bios: s390x: Replace 0x00 with 0x0 or 0 > pc-bios: s390x: Make u32 ptr check explicit > > pc-bios/s390-ccw/bootmap.c | 4 +--- > pc-bios/s390-ccw/cio.c | 36 +++++++++++++++---------------- > pc-bios/s390-ccw/cio.h | 17 +++++++++------ > pc-bios/s390-ccw/dasd-ipl.c | 17 +++++++-------- > pc-bios/s390-ccw/helper.h | 2 +- > pc-bios/s390-ccw/jump2ipl.c | 10 ++++----- > pc-bios/s390-ccw/main.c | 15 +++---------- > pc-bios/s390-ccw/menu.c | 1 + > pc-bios/s390-ccw/netmain.c | 23 +++----------------- > pc-bios/s390-ccw/s390-arch.h | 4 +++- > pc-bios/s390-ccw/s390-ccw.h | 27 ++++++----------------- > pc-bios/s390-ccw/start.S | 5 +++-- > pc-bios/s390-ccw/time.h | 39 ++++++++++++++++++++++++++++++++++ > pc-bios/s390-ccw/virtio-net.c | 1 + > pc-bios/s390-ccw/virtio-scsi.c | 1 + > pc-bios/s390-ccw/virtio.c | 18 +++------------- > 16 files changed, 107 insertions(+), 113 deletions(-) > create mode 100644 pc-bios/s390-ccw/time.h > I assume Christian/Thomas will pick that one up once the last wrinkles have been ironed out?