| Message ID | 20200515150421.25479-1-kraxel@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | acpi: i386 tweaks | expand |
Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515150421.25479-1-kraxel@redhat.com Subject: [PATCH v6 00/16] acpi: i386 tweaks Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 50ccf98 acpi: q35: drop _SB.PCI0.ISA.LPCD opregion. 9df782c acpi: drop build_piix4_pm() 3dde274 acpi: drop serial/parallel enable bits from dsdt ba91b3c acpi: simplify build_isa_devices_aml() b3c142b acpi: factor out fw_cfg_add_acpi_dsdt() c323a33 acpi: move aml builder code for i8042 (kbd+mouse) device 3e7bae0 floppy: move cmos_get_fd_drive_type() from pc e9149b0 floppy: make isa_fdc_get_drive_max_chs static db4dee8 acpi: move aml builder code for floppy device 0260d46 acpi: move aml builder code for parallel device ddf467f acpi: parallel: don't use _STA method 64d08f8 acpi: move aml builder code for serial device 8104cb6 acpi: serial: don't use _STA method 6d7f2e7 acpi: rtc: use a single crs range fa494c5 acpi: move aml builder code for rtc device 7300b89 qtest: allow DSDT acpi table changes === OUTPUT BEGIN === 1/16 Checking commit 7300b8986cb8 (qtest: allow DSDT acpi table changes) 2/16 Checking commit fa494c572f21 (acpi: move aml builder code for rtc device) 3/16 Checking commit 6d7f2e7fcb02 (acpi: rtc: use a single crs range) 4/16 Checking commit 8104cb67898a (acpi: serial: don't use _STA method) 5/16 Checking commit 64d08f8cd884 (acpi: move aml builder code for serial device) 6/16 Checking commit ddf467f98a4a (acpi: parallel: don't use _STA method) 7/16 Checking commit 0260d46f99be (acpi: move aml builder code for parallel device) 8/16 Checking commit db4dee8bd791 (acpi: move aml builder code for floppy device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #245: new file mode 100644 total: 0 errors, 1 warnings, 221 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit e9149b0c087e (floppy: make isa_fdc_get_drive_max_chs static) 10/16 Checking commit 3e7bae0c4433 (floppy: move cmos_get_fd_drive_type() from pc) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 82 lines checked Patch 10/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/16 Checking commit c323a336b719 (acpi: move aml builder code for i8042 (kbd+mouse) device) 12/16 Checking commit b3c142be77e7 (acpi: factor out fw_cfg_add_acpi_dsdt()) 13/16 Checking commit ba91b3cd8ac4 (acpi: simplify build_isa_devices_aml()) 14/16 Checking commit 3dde274c7e73 (acpi: drop serial/parallel enable bits from dsdt) 15/16 Checking commit 9df782c3c334 (acpi: drop build_piix4_pm()) 16/16 Checking commit 50ccf983fc52 (acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200515150421.25479-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515150421.25479-1-kraxel@redhat.com Subject: [PATCH v6 00/16] acpi: i386 tweaks Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 69ff2b9 acpi: q35: drop _SB.PCI0.ISA.LPCD opregion. 0e608e1 acpi: drop build_piix4_pm() 79bb41f acpi: drop serial/parallel enable bits from dsdt 3d483e1 acpi: simplify build_isa_devices_aml() c9db35e acpi: factor out fw_cfg_add_acpi_dsdt() 4d0c5ba acpi: move aml builder code for i8042 (kbd+mouse) device db9a5fa floppy: move cmos_get_fd_drive_type() from pc 3d99a4d floppy: make isa_fdc_get_drive_max_chs static 50ec383 acpi: move aml builder code for floppy device ca585c0 acpi: move aml builder code for parallel device db438d0 acpi: parallel: don't use _STA method 6a5550d acpi: move aml builder code for serial device 585d308 acpi: serial: don't use _STA method 6390dcb acpi: rtc: use a single crs range 730eda7 acpi: move aml builder code for rtc device 0f58dfa qtest: allow DSDT acpi table changes === OUTPUT BEGIN === 1/16 Checking commit 0f58dfaf03d2 (qtest: allow DSDT acpi table changes) 2/16 Checking commit 730eda75f32f (acpi: move aml builder code for rtc device) 3/16 Checking commit 6390dcbc7606 (acpi: rtc: use a single crs range) 4/16 Checking commit 585d308b5a73 (acpi: serial: don't use _STA method) 5/16 Checking commit 6a5550d61069 (acpi: move aml builder code for serial device) 6/16 Checking commit db438d094684 (acpi: parallel: don't use _STA method) 7/16 Checking commit ca585c07c338 (acpi: move aml builder code for parallel device) 8/16 Checking commit 50ec383087f1 (acpi: move aml builder code for floppy device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #245: new file mode 100644 total: 0 errors, 1 warnings, 221 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 3d99a4dae716 (floppy: make isa_fdc_get_drive_max_chs static) 10/16 Checking commit db9a5fa00fa3 (floppy: move cmos_get_fd_drive_type() from pc) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 82 lines checked Patch 10/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/16 Checking commit 4d0c5bab6dae (acpi: move aml builder code for i8042 (kbd+mouse) device) 12/16 Checking commit c9db35eb2c73 (acpi: factor out fw_cfg_add_acpi_dsdt()) 13/16 Checking commit 3d483e1810c7 (acpi: simplify build_isa_devices_aml()) 14/16 Checking commit 79bb41f701f3 (acpi: drop serial/parallel enable bits from dsdt) 15/16 Checking commit 0e608e189800 (acpi: drop build_piix4_pm()) 16/16 Checking commit 69ff2b91c86b (acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200515150421.25479-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kraxel@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515150421.25479-1-kraxel@redhat.com Subject: [PATCH v6 00/16] acpi: i386 tweaks Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9adb28d acpi: q35: drop _SB.PCI0.ISA.LPCD opregion. 646a108 acpi: drop build_piix4_pm() 6324bba acpi: drop serial/parallel enable bits from dsdt 4a8ceb8 acpi: simplify build_isa_devices_aml() d8ccc6f acpi: factor out fw_cfg_add_acpi_dsdt() e0c5fc4 acpi: move aml builder code for i8042 (kbd+mouse) device 4eb0cc0 floppy: move cmos_get_fd_drive_type() from pc 71d56fa floppy: make isa_fdc_get_drive_max_chs static c895a16 acpi: move aml builder code for floppy device 41e32d4 acpi: move aml builder code for parallel device fe41881 acpi: parallel: don't use _STA method bcb5ae4 acpi: move aml builder code for serial device 49e11f9 acpi: serial: don't use _STA method 6e7ae5d acpi: rtc: use a single crs range e1b1294 acpi: move aml builder code for rtc device 10fc2d4 qtest: allow DSDT acpi table changes === OUTPUT BEGIN === 1/16 Checking commit 10fc2d45a6fa (qtest: allow DSDT acpi table changes) 2/16 Checking commit e1b1294da937 (acpi: move aml builder code for rtc device) 3/16 Checking commit 6e7ae5d0138b (acpi: rtc: use a single crs range) 4/16 Checking commit 49e11f9e91f4 (acpi: serial: don't use _STA method) 5/16 Checking commit bcb5ae4dd8b1 (acpi: move aml builder code for serial device) 6/16 Checking commit fe4188155acf (acpi: parallel: don't use _STA method) 7/16 Checking commit 41e32d4b35c3 (acpi: move aml builder code for parallel device) 8/16 Checking commit c895a1614849 (acpi: move aml builder code for floppy device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #245: new file mode 100644 total: 0 errors, 1 warnings, 221 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 71d56fa8b146 (floppy: make isa_fdc_get_drive_max_chs static) 10/16 Checking commit 4eb0cc051852 (floppy: move cmos_get_fd_drive_type() from pc) ERROR: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 82 lines checked Patch 10/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/16 Checking commit e0c5fc44de76 (acpi: move aml builder code for i8042 (kbd+mouse) device) 12/16 Checking commit d8ccc6f08dcd (acpi: factor out fw_cfg_add_acpi_dsdt()) 13/16 Checking commit 4a8ceb8d9dd9 (acpi: simplify build_isa_devices_aml()) 14/16 Checking commit 6324bbac2984 (acpi: drop serial/parallel enable bits from dsdt) 15/16 Checking commit 646a108f5ece (acpi: drop build_piix4_pm()) 16/16 Checking commit 9adb28d40ad3 (acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200515150421.25479-1-kraxel@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, May 15, 2020 at 05:04:05PM +0200, Gerd Hoffmann wrote: > First batch of microvm patches, some generic acpi stuff. > Split the acpi-build.c monster, specifically split the > pc and q35 and pci bits into a separate file which we > can skip building at some point in the future. > > v2 changes: leave acpi-build.c largely as-is, move useful > bits to other places to allow them being reused, specifically: > > * move isa device generator functions to individual isa devices. > * move fw_cfg generator function to fw_cfg.c > > v3 changes: fix rtc, support multiple lpt devices. > > v4 changes: > * drop merged patches. > * split rtc crs change to separata patch. > * added two cleanup patches. > * picked up ack & review tags. > > v5 changes: > * add comment for rtc crs update. > * add even more cleanup patches. > * picked up ack & review tags. > > v6 changes: > * floppy: move cmos_get_fd_drive_type. > * picked up ack & review tags. Ping. What is the status here? take care, Gerd
On Mon, Jun 08, 2020 at 03:22:45PM +0200, Gerd Hoffmann wrote: > On Fri, May 15, 2020 at 05:04:05PM +0200, Gerd Hoffmann wrote: > > First batch of microvm patches, some generic acpi stuff. > > Split the acpi-build.c monster, specifically split the > > pc and q35 and pci bits into a separate file which we > > can skip building at some point in the future. > > > > v2 changes: leave acpi-build.c largely as-is, move useful > > bits to other places to allow them being reused, specifically: > > > > * move isa device generator functions to individual isa devices. > > * move fw_cfg generator function to fw_cfg.c > > > > v3 changes: fix rtc, support multiple lpt devices. > > > > v4 changes: > > * drop merged patches. > > * split rtc crs change to separata patch. > > * added two cleanup patches. > > * picked up ack & review tags. > > > > v5 changes: > > * add comment for rtc crs update. > > * add even more cleanup patches. > > * picked up ack & review tags. > > > > v6 changes: > > * floppy: move cmos_get_fd_drive_type. > > * picked up ack & review tags. > > Ping. What is the status here? > > take care, > Gerd It's queued and will be in the next pull. Thanks a lot!
On Fri, May 15, 2020 at 05:04:05PM +0200, Gerd Hoffmann wrote: > First batch of microvm patches, some generic acpi stuff. > Split the acpi-build.c monster, specifically split the > pc and q35 and pci bits into a separate file which we > can skip building at some point in the future. Applied patch 1-7. Rest all look ok but couldn't apply since they seem to be on top of some other cleanups which are not upstream. Pls rebased and post and I'll apply. > v2 changes: leave acpi-build.c largely as-is, move useful > bits to other places to allow them being reused, specifically: > > * move isa device generator functions to individual isa devices. > * move fw_cfg generator function to fw_cfg.c > > v3 changes: fix rtc, support multiple lpt devices. > > v4 changes: > * drop merged patches. > * split rtc crs change to separata patch. > * added two cleanup patches. > * picked up ack & review tags. > > v5 changes: > * add comment for rtc crs update. > * add even more cleanup patches. > * picked up ack & review tags. > > v6 changes: > * floppy: move cmos_get_fd_drive_type. > * picked up ack & review tags. > > take care, > Gerd > > Gerd Hoffmann (16): > qtest: allow DSDT acpi table changes > acpi: move aml builder code for rtc device > acpi: rtc: use a single crs range > acpi: serial: don't use _STA method > acpi: move aml builder code for serial device > acpi: parallel: don't use _STA method > acpi: move aml builder code for parallel device > acpi: move aml builder code for floppy device > floppy: make isa_fdc_get_drive_max_chs static > floppy: move cmos_get_fd_drive_type() from pc > acpi: move aml builder code for i8042 (kbd+mouse) device > acpi: factor out fw_cfg_add_acpi_dsdt() > acpi: simplify build_isa_devices_aml() > acpi: drop serial/parallel enable bits from dsdt > acpi: drop build_piix4_pm() > acpi: q35: drop _SB.PCI0.ISA.LPCD opregion. > > hw/i386/fw_cfg.h | 1 + > include/hw/block/fdc.h | 3 +- > include/hw/i386/pc.h | 1 - > tests/qtest/bios-tables-test-allowed-diff.h | 17 ++ > hw/block/fdc.c | 111 ++++++- > hw/char/parallel.c | 22 ++ > hw/char/serial-isa.c | 22 ++ > hw/i386/acpi-build.c | 312 +------------------- > hw/i386/fw_cfg.c | 28 ++ > hw/i386/pc.c | 25 -- > hw/input/pckbd.c | 31 ++ > hw/rtc/mc146818rtc.c | 24 ++ > stubs/cmos.c | 7 + > stubs/Makefile.objs | 1 + > 14 files changed, 269 insertions(+), 336 deletions(-) > create mode 100644 stubs/cmos.c > > -- > 2.18.4
Hi, > Applied patch 1-7. Rest all look ok but couldn't apply > since they seem to be on top of some other cleanups > which are not upstream. Pls rebased and post and I'll apply. Other way around, it is based on older master and we've got conflicting patches merged upstream meanwhile. I'll rebase & repost. take care, Gerd