From patchwork Mon May 18 16:02:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudio Fontana X-Patchwork-Id: 11555649 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6E3A912 for ; Mon, 18 May 2020 16:05:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A02A420674 for ; Mon, 18 May 2020 16:05:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A02A420674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:58256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaiGx-0000u2-P9 for patchwork-qemu-devel@patchwork.kernel.org; Mon, 18 May 2020 12:05:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaiDt-0003iL-Ec for qemu-devel@nongnu.org; Mon, 18 May 2020 12:02:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:36664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaiDs-00031G-D2 for qemu-devel@nongnu.org; Mon, 18 May 2020 12:02:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 36E19AF7C; Mon, 18 May 2020 16:02:36 +0000 (UTC) From: Claudio Fontana To: David Gibson , Peter Maydell , Philippe Mathieu-Daude Subject: [PATCH v5 0/2] Makefile: libfdt: build only the strict necessary Date: Mon, 18 May 2020 18:02:25 +0200 Message-Id: <20200518160227.18767-1-cfontana@suse.de> X-Mailer: git-send-email 2.16.4 Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/18 01:30:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , Claudio Fontana , Alex Bennee , qemu-devel@nongnu.org, Laurent Vivier Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" v4 -> v5: * include the dtc submodule update commit in the 1/2 patch v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet) * changed the approach to leverage new upstream dtc Makefile, needs dtc submodule update to include upstream dtc commit 85e5d839847af54efab170f2b1331b2a6421e647. * LIBFDT_srcdir does not exist anymore in upstream dtc: it is also not used anymore. * LIBFDT_lib: need to avoid building libfdt.so at least for now, so pass as empty to avoid building the .so. This is to avoid breaking existing trees with objects already compiled without -fPIC. * clean: no need to make dtc clean target, every artifact is captured by global clean rule v2 -> v3: * changed into a 2 patch series; in the second patch we remove the old compatibility gunks that were meant for removal some time after 4.1. * renamed the libfdt PHONY rule to dtc/all, with the intent to make existing working trees forward and backward compatible across the change. v1 -> v2: * fix error generated when running UNCHECKED_GOALS without prior configure, for example during make docker-image-fedora. Without configure, DSOSUF is empty, and the module pattern rule in rules.mak that uses this variable can match too much; provide a default in the Makefile to avoid it. * only attempt to build the archive when there is a non-empty list of objects. This could be done in general for the %.a: pattern in rules.mak, but maybe there are valid reasons to build an empty .a? * removed some intermediate variables that did not add much value (LIBFDT_srcdir, LIBFDT_archive) Tested locally with 3 VPATH configurations (no-, VPATH, VPATH in src subdir), and with docker-image-fedora, docker-test-debug@fedora that failed before. Claudio Fontana (2): Makefile: libfdt: build only the strict necessary Makefile: remove old compatibility gunks Makefile | 32 ++++++++++++++++---------------- configure | 6 +----- rules.mak | 2 ++ 3 files changed, 19 insertions(+), 21 deletions(-)