mbox series

[for-5.1,v2,0/2] qemu-img convert: Fix abort with unaligned image size

Message ID 20200716142601.111237-1-kwolf@redhat.com (mailing list archive)
Headers show
Series qemu-img convert: Fix abort with unaligned image size | expand


Kevin Wolf July 16, 2020, 2:25 p.m. UTC
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1834646

Patch 1 fixes the assertion failure by failing gracefully when opening
an image whose size isn't aligned to the required request alignment.

Patch 2 relaxes the restrictions for NFS, which actually supports byte
alignment, but incorrectly gets a 4k request alignment in the file-posix
block driver.

- Don't fail opening unaligned images, but requesting WRITE permission
  without RESIZE. This keeps qcow2 images with unaligned metadata at EOF
  working. [Max]

Kevin Wolf (2):
  block: Require aligned image size to avoid assertion failure
  file-posix: Allow byte-aligned O_DIRECT with NFS

 block.c            | 16 ++++++++++++++++
 block/file-posix.c | 26 +++++++++++++++++++++++++-
 2 files changed, 41 insertions(+), 1 deletion(-)