mbox series

[v2,0/4] Add dtrace support on macOS

Message ID 20200717093517.73397-1-r.bolshakov@yadro.com (mailing list archive)
Headers show
Series Add dtrace support on macOS | expand

Message

Roman Bolshakov July 17, 2020, 9:35 a.m. UTC
Hi,

This is a small series that enables dtrace tracing backend on macOS.
Whether or not it should go to 5.1 is up to discretion of tracing
maintainers.

Thanks,
Roman

Changes since v1:
 - Fixed a typo ANSI C to C99, wrt to _Bool in the first patch.
 - Prevented a few [-Wpointer-sign] warnings by converting int8_t * to
   signed char * in static probe definitions.
 - Moved COLO packet dump under #ifdef DEBUG_COLO_PACKETS (Daniel).
 - Separated tracepoints in net/filter-rewriter.c to use matching
   is-enabled probe (Daniel).

Roman Bolshakov (4):
  scripts/tracetool: Fix dtrace generation for macOS
  scripts/tracetool: Use void pointer for vcpu
  build: Don't make object files for dtrace on macOS
  net/colo: Match is-enabled probe to tracepoint

 Makefile.objs                 |  2 ++
 net/colo-compare.c            | 42 ++++++++++++++++++-----------------
 net/filter-rewriter.c         | 10 +++++++--
 net/trace-events              |  2 --
 scripts/tracetool/format/d.py | 15 ++++++++++++-
 scripts/tracetool/vcpu.py     |  2 +-
 6 files changed, 47 insertions(+), 26 deletions(-)

Comments

Stefan Hajnoczi July 21, 2020, 12:36 p.m. UTC | #1
On Fri, Jul 17, 2020 at 12:35:13PM +0300, Roman Bolshakov wrote:
> Hi,
> 
> This is a small series that enables dtrace tracing backend on macOS.
> Whether or not it should go to 5.1 is up to discretion of tracing
> maintainers.

Thanks for the patches. I would like to apply them for QEMU 5.2.

I have reviewed patches 1-3 and will wait for discussion to finish on
patch 4.

Stefan
Stefan Hajnoczi Aug. 7, 2020, 1 p.m. UTC | #2
On Fri, Jul 17, 2020 at 12:35:13PM +0300, Roman Bolshakov wrote:
> Hi,
> 
> This is a small series that enables dtrace tracing backend on macOS.
> Whether or not it should go to 5.1 is up to discretion of tracing
> maintainers.
> 
> Thanks,
> Roman
> 
> Changes since v1:
>  - Fixed a typo ANSI C to C99, wrt to _Bool in the first patch.
>  - Prevented a few [-Wpointer-sign] warnings by converting int8_t * to
>    signed char * in static probe definitions.
>  - Moved COLO packet dump under #ifdef DEBUG_COLO_PACKETS (Daniel).
>  - Separated tracepoints in net/filter-rewriter.c to use matching
>    is-enabled probe (Daniel).
> 
> Roman Bolshakov (4):
>   scripts/tracetool: Fix dtrace generation for macOS
>   scripts/tracetool: Use void pointer for vcpu
>   build: Don't make object files for dtrace on macOS
>   net/colo: Match is-enabled probe to tracepoint
> 
>  Makefile.objs                 |  2 ++
>  net/colo-compare.c            | 42 ++++++++++++++++++-----------------
>  net/filter-rewriter.c         | 10 +++++++--
>  net/trace-events              |  2 --
>  scripts/tracetool/format/d.py | 15 ++++++++++++-
>  scripts/tracetool/vcpu.py     |  2 +-
>  6 files changed, 47 insertions(+), 26 deletions(-)
> 
> -- 
> 2.26.1
> 

Thanks, applied to my tracing-next tree:
https://github.com/stefanha/qemu/commits/tracing-next

Stefan