[0/2] Getting qemu building under msys2 properly

Message

Yonggang Luo Aug. 28, 2020, 4:22 p.m. UTC

Convert undefsym.sh to undefsym.py and replace $PWD with $build_dir

Yonggang Luo (2):
  meson: Convert undefsym.sh to undefsym.py
  configure: Fix include and linkage issue on msys2

 configure           | 28 +++++++++++++++-------
 meson.build         |  2 +-
 scripts/undefsym.py | 57 +++++++++++++++++++++++++++++++++++++++++++++
 scripts/undefsym.sh | 20 ----------------
 4 files changed, 77 insertions(+), 30 deletions(-)
 create mode 100644 scripts/undefsym.py
 delete mode 100755 scripts/undefsym.sh

Comments

Paolo Bonzini Aug. 28, 2020, 5:41 p.m. UTC | #1

On 28/08/20 18:22, Yonggang Luo wrote:
> Convert undefsym.sh to undefsym.py and replace $PWD with $build_dir
> 
> Yonggang Luo (2):
>   meson: Convert undefsym.sh to undefsym.py
>   configure: Fix include and linkage issue on msys2
> 
>  configure           | 28 +++++++++++++++-------
>  meson.build         |  2 +-
>  scripts/undefsym.py | 57 +++++++++++++++++++++++++++++++++++++++++++++
>  scripts/undefsym.sh | 20 ----------------
>  4 files changed, 77 insertions(+), 30 deletions(-)
>  create mode 100644 scripts/undefsym.py
>  delete mode 100755 scripts/undefsym.sh
> 

Thanks Yonggang, I'll queue the first patch.

I'll keep an eye on your patch but I prefer to first have the rest of
the build (tests and possibly pc-bios) moved to meson.build.  This way
most of the references to source and build paths from Make (where spaces
are problematic) should go away and it's easier to understand the effect
of the patch.

Paolo