mbox series

[v4,00/11] capstone + disassembler patches

Message ID 20200921174118.39352-1-richard.henderson@linaro.org (mailing list archive)
Headers show
Series capstone + disassembler patches | expand

Message

Richard Henderson Sept. 21, 2020, 5:41 p.m. UTC
Patches lacking review:

0002-capstone-Update-to-upstream-next-branch.patch
0003-capstone-Require-version-4.0-from-a-system-librar.patch
0007-disas-Cleanup-plugin_disas.patch
0009-disas-Split-out-capstone-code-to-disas-capstone.c.patch

Changes for v4:
  * Require v4.0 from the system library.
    Fixes an issue AJB found from v3.0.5 from ubuntu 18.

Changes for v3:
  * Fix default value for capstone in meson_options.txt.
  * Add "Submodules" separator in meson.build (paolo).
  * Remove form-feed characters in dis-asm.h (thuth).

Changes for v2:
  * Several configury changes in patch 1, along the lines
    of that suggested by Paolo, but not exactly the same.
  * Drop sparc capstone enablement (I suddenly have a memory
    of doing the same thing last year).


r~


Richard Henderson (11):
  capstone: Convert Makefile bits to meson bits
  capstone: Update to upstream "next" branch
  capstone: Require version 4.0 from a system library
  disas: Move host asm annotations to tb_gen_code
  disas: Clean up CPUDebug initialization
  disas: Use qemu/bswap.h for bfd endian loads
  disas: Cleanup plugin_disas
  disas: Configure capstone for aarch64 host without libvixl
  disas: Split out capstone code to disas/capstone.c
  disas: Enable capstone disassembly for s390x
  disas/capstone: Add skipdata hook for s390x

 configure                 |  64 +---
 Makefile                  |  16 -
 include/disas/dis-asm.h   | 104 +++---
 include/disas/disas.h     |   2 +-
 include/exec/log.h        |   4 +-
 accel/tcg/translate-all.c |  24 +-
 disas.c                   | 703 +++++++++-----------------------------
 disas/capstone.c          | 326 ++++++++++++++++++
 target/s390x/cpu.c        |   4 +
 tcg/tcg.c                 |   4 +-
 capstone                  |   2 +-
 disas/meson.build         |   1 +
 meson.build               | 124 ++++++-
 meson_options.txt         |   4 +
 14 files changed, 678 insertions(+), 704 deletions(-)
 create mode 100644 disas/capstone.c

Comments

no-reply@patchew.org Sept. 22, 2020, 12:50 a.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20200921174118.39352-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200921174118.39352-1-richard.henderson@linaro.org
Subject: [PATCH v4 00/11] capstone + disassembler patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3d764d3 disas/capstone: Add skipdata hook for s390x
04c1cfa disas: Enable capstone disassembly for s390x
93a2da5 disas: Split out capstone code to disas/capstone.c
d29736e disas: Configure capstone for aarch64 host without libvixl
f283959 disas: Cleanup plugin_disas
b3a548e disas: Use qemu/bswap.h for bfd endian loads
1b6e185 disas: Clean up CPUDebug initialization
3b1f6f9 disas: Move host asm annotations to tb_gen_code
856507e capstone: Require version 4.0 from a system library
a714c28 capstone: Update to upstream "next" branch
823a3e2 capstone: Convert Makefile bits to meson bits

=== OUTPUT BEGIN ===
1/11 Checking commit 823a3e2a9f3c (capstone: Convert Makefile bits to meson bits)
2/11 Checking commit a714c28917da (capstone: Update to upstream "next" branch)
3/11 Checking commit 856507eedce4 (capstone: Require version 4.0 from a system library)
4/11 Checking commit 3b1f6f9ca3a0 (disas: Move host asm annotations to tb_gen_code)
5/11 Checking commit 1b6e185eee3e (disas: Clean up CPUDebug initialization)
WARNING: Block comments use a trailing */ on a separate line
#73: FILE: disas.c:48:
+   an error return from {host,target}_read_memory.  */

ERROR: code indent should never use tabs
#91: FILE: disas.c:58:
+^I^I^I   "Address 0x%" PRIx64 " is out of bounds.\n",$

WARNING: architecture specific defines should be avoided
#203: FILE: disas.c:479:
+#if defined(_ILP32) || (__riscv_xlen == 32)

total: 1 errors, 2 warnings, 490 lines checked

Patch 5/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/11 Checking commit b3a548e1996e (disas: Use qemu/bswap.h for bfd endian loads)
7/11 Checking commit f2839591e583 (disas: Cleanup plugin_disas)
8/11 Checking commit d29736e11366 (disas: Configure capstone for aarch64 host without libvixl)
9/11 Checking commit 93a2da58d997 (disas: Split out capstone code to disas/capstone.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#309: 
new file mode 100644

total: 0 errors, 1 warnings, 604 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 04c1cfa18ca8 (disas: Enable capstone disassembly for s390x)
11/11 Checking commit 3d764d3d1e7b (disas/capstone: Add skipdata hook for s390x)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200921174118.39352-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com