mbox series

[v3,0/6] Add physical display dimensions to spice/virtio-gpu

Message ID 20200927145751.365446-1-marcandre.lureau@redhat.com (mailing list archive)
Headers show
Series Add physical display dimensions to spice/virtio-gpu | expand

Message

Marc-André Lureau Sept. 27, 2020, 2:57 p.m. UTC
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

This series improves the support for HiDPI displays with Spice.
The related spice series have already been merged.

v3:
 - simplify the handling of Spice monitor configuration (Frediano)
v2:
 - add a patch to "spice: remove the single monitor config logic" (Gerd)

Marc-André Lureau (6):
  edid: fix physical display size computation
  edid: use physical dimensions if available
  ui: add getter for UIInfo
  spice: remove the single monitor config logic
  spice: get monitors physical dimension
  virtio-gpu: set physical dimensions for EDID

 hw/display/edid-generate.c     | 36 +++++++++++++++++++++++-----------
 hw/display/virtio-gpu-base.c   |  2 ++
 hw/display/virtio-gpu.c        |  2 ++
 include/hw/display/edid.h      |  5 ++++-
 include/hw/virtio/virtio-gpu.h |  1 +
 include/ui/console.h           |  4 ++++
 qemu-edid.c                    | 11 +++++++++--
 ui/console.c                   |  7 +++++++
 ui/spice-display.c             | 35 ++++++++++++---------------------
 9 files changed, 66 insertions(+), 37 deletions(-)

Comments

no-reply@patchew.org Sept. 27, 2020, 3:43 p.m. UTC | #1
Patchew URL: https://patchew.org/QEMU/20200927145751.365446-1-marcandre.lureau@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

C linker for the host machine: cc ld.bfd 2.27-43
Host machine cpu family: x86_64
Host machine cpu: x86_64
../src/meson.build:10: WARNING: Module unstable-keyval has no backwards or forwards compatibility and might not exist in future releases.
Program sh found: YES
Program python3 found: YES (/usr/bin/python3)
Configuring ninjatool using configuration
---
  TEST    iotest-qcow2: 018
socket_accept failed: Resource temporarily unavailable
**
ERROR:../src/tests/qtest/libqtest.c:301:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0)
../src/tests/qtest/libqtest.c:166: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0)
ERROR qtest-x86_64: bios-tables-test - Bail out! ERROR:../src/tests/qtest/libqtest.c:301:qtest_init_without_qmp_handshake: assertion failed: (s->fd >= 0 && s->qmp_fd >= 0)
make: *** [run-test-138] Error 1
make: *** Waiting for unfinished jobs....
  TEST    iotest-qcow2: 019
  TEST    iotest-qcow2: 020
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--rm', '--label', 'com.qemu.instance.uuid=f6fe68779d704fd8a68205e395ce304f', '-u', '1001', '--security-opt', 'seccomp=unconfined', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-znj025fh/src/docker-src.2020-09-27-11.26.18.9424:/var/tmp/qemu:z,ro', 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=f6fe68779d704fd8a68205e395ce304f
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-znj025fh/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    17m9.398s
user    0m20.015s


The full log is available at
http://patchew.org/logs/20200927145751.365446-1-marcandre.lureau@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Gerd Hoffmann Sept. 29, 2020, 7:27 a.m. UTC | #2
On Sun, Sep 27, 2020 at 06:57:45PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> This series improves the support for HiDPI displays with Spice.
> The related spice series have already been merged.
> 
> v3:
>  - simplify the handling of Spice monitor configuration (Frediano)
> v2:
>  - add a patch to "spice: remove the single monitor config logic" (Gerd)

Series queued up now.

thanks,
  Gerd