| Message ID | 20201013143806.14321-1-cfontana@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | unbreak non-tcg builds | expand |
On 10/13/20 4:38 PM, Claudio Fontana wrote: > This series now unbreaks current non-tcg builds > (!CONFIG_TCG). > > tests Makefiles need to avoid relying on all non-native > archs binaries to be present, > > bios-tables-test needs to skip tests that are tcg-only, > > and notably the replay framework needs to consider that > it might not be functional (or its code present at all) > without TCG. > > Tested ok target x86_64-softmmu on x86_64 host with: > > ./configure --enable-tcg --disable-kvm > ./configure --enable-kvm --disable-tcg > ./configure --enable-tcg --enable-kvm If you want to avoid these configurations to bitrot, consider covering them by adding Gitlab jobs :)))
On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 10/13/20 4:38 PM, Claudio Fontana wrote: >> This series now unbreaks current non-tcg builds >> (!CONFIG_TCG). >> >> tests Makefiles need to avoid relying on all non-native >> archs binaries to be present, >> >> bios-tables-test needs to skip tests that are tcg-only, >> >> and notably the replay framework needs to consider that >> it might not be functional (or its code present at all) >> without TCG. >> >> Tested ok target x86_64-softmmu on x86_64 host with: >> >> ./configure --enable-tcg --disable-kvm >> ./configure --enable-kvm --disable-tcg >> ./configure --enable-tcg --enable-kvm > > If you want to avoid these configurations to bitrot, > consider covering them by adding Gitlab jobs :))) > > That would be, providing a patch to .travis.yml right? I guess -j parameter for make is automatically provided depending on infra resources? Something like the following? Ciao, C diff --git a/.travis.yml b/.travis.yml index 1054ec5d29..49ec615ed8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -320,6 +320,19 @@ jobs: - TEST_CMD="make check-tcg" - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg" + # Check modular accelerator builds. + - name: "modular accelerator builds (x86_64-softmmu, tcg only)" + env: + - CONFIG="--disable-kvm --enable-tcg --target-list=x86_64-softmmu" + - TEST_BUILD_CMD="make" + - TEST_CMD="make check" + + - name: "modular accelerator builds (x86_64-softmmu, kvm only)" + env: + - CONFIG="--enable-kvm --disable-tcg --target-list=x86_64-softmmu" + - TEST_BUILD_CMD="make" + - TEST_CMD="make check" + - name: "[aarch64] GCC check-tcg" arch: arm64 dist: focal
On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 10/13/20 4:38 PM, Claudio Fontana wrote: >> This series now unbreaks current non-tcg builds >> (!CONFIG_TCG). >> >> tests Makefiles need to avoid relying on all non-native >> archs binaries to be present, >> >> bios-tables-test needs to skip tests that are tcg-only, >> >> and notably the replay framework needs to consider that >> it might not be functional (or its code present at all) >> without TCG. >> >> Tested ok target x86_64-softmmu on x86_64 host with: >> >> ./configure --enable-tcg --disable-kvm >> ./configure --enable-kvm --disable-tcg >> ./configure --enable-tcg --enable-kvm > > If you want to avoid these configurations to bitrot, > consider covering them by adding Gitlab jobs :))) > > Hi Philippe and all, latest master now has all the fixes discussed in these series, thanks also to Paolo's help with sorting out the stubs. Already there is a new breakage though it seems, this time in qmp-cmd-test. So adding CI coverage seems necessary. In the .gitlab-ci.yml I see: build-tcg-disabled: [...] - ../configure --disable-tcg --audio-drv-list="" || { cat config.log meson-logs/meson-log.txt && exit 1; } So is this supposed to be covered already? I am confused also by the fact that it seems that suddently I see much "less" stuff in the gitlab CI, did I miss some infra discussion? Thanks, Claudio
On 10/26/20 4:28 PM, Claudio Fontana wrote: > On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote: >> On 10/13/20 4:38 PM, Claudio Fontana wrote: >>> This series now unbreaks current non-tcg builds >>> (!CONFIG_TCG). >>> >>> tests Makefiles need to avoid relying on all non-native >>> archs binaries to be present, >>> >>> bios-tables-test needs to skip tests that are tcg-only, >>> >>> and notably the replay framework needs to consider that >>> it might not be functional (or its code present at all) >>> without TCG. >>> >>> Tested ok target x86_64-softmmu on x86_64 host with: >>> >>> ./configure --enable-tcg --disable-kvm >>> ./configure --enable-kvm --disable-tcg >>> ./configure --enable-tcg --enable-kvm >> >> If you want to avoid these configurations to bitrot, >> consider covering them by adding Gitlab jobs :))) >> >> > > Hi Philippe and all, > > latest master now has all the fixes discussed in these series, thanks also to Paolo's help with sorting out the stubs. > > Already there is a new breakage though it seems, this time in qmp-cmd-test. Sorry, this is wrong. The changes are not in master yet, that's why stuff breaks (errors from replay qmp commands). > > So adding CI coverage seems necessary. > This is still probably a good idea. Ciao, C > In the .gitlab-ci.yml I see: > > build-tcg-disabled: > [...] > - ../configure --disable-tcg --audio-drv-list="" || { cat config.log meson-logs/meson-log.txt && exit 1; } > > So is this supposed to be covered already? > > I am confused also by the fact that it seems that suddently I see much "less" stuff in the gitlab CI, did I miss some infra discussion? > > Thanks, > > Claudio >
On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 10/13/20 4:38 PM, Claudio Fontana wrote: >> This series now unbreaks current non-tcg builds >> (!CONFIG_TCG). >> >> tests Makefiles need to avoid relying on all non-native >> archs binaries to be present, >> >> bios-tables-test needs to skip tests that are tcg-only, >> >> and notably the replay framework needs to consider that >> it might not be functional (or its code present at all) >> without TCG. >> >> Tested ok target x86_64-softmmu on x86_64 host with: >> >> ./configure --enable-tcg --disable-kvm >> ./configure --enable-kvm --disable-tcg >> ./configure --enable-tcg --enable-kvm > > If you want to avoid these configurations to bitrot, > consider covering them by adding Gitlab jobs :))) > Hello Philippe, happy new year, I am going back to look at the current code in master, slowly trying to get back a hold on things, and I remember some time ago you suggested to keep testing "tools" builds, with ./configure --disable-tcg --disable-kvm --enable-tools but the drawback of the "tools-only" build is that currently one cannot run make check on it. It fails with ERRORS in bios-tables-test and others. Is it supposed to actually work? Is there any make check work that can be done without any accelerator? I would assume so... Thanks, Claudio