mbox series

[PATCH-for-5.2,v2,00/25] block/nvme: Fix Aarch64 or big-endian hosts

Message ID 20201029093306.1063879-1-philmd@redhat.com (mailing list archive)
Headers show
Series block/nvme: Fix Aarch64 or big-endian hosts | expand

Message

Philippe Mathieu-Daudé Oct. 29, 2020, 9:32 a.m. UTC
Add a bit of tracing, clean around to finally fix few bugs.
In particular, restore NVMe on Aarch64 host.

Since v1:
- addressed Stefan and Eric review comments
- dropped unnecessary patches
- added BE fix reported by Keith

Patches missing review: #10, #24, #25

Supersedes: <20201027135547.374946-1-philmd@redhat.com>

Eric Auger (4):
  block/nvme: Change size and alignment of IDENTIFY response buffer
  block/nvme: Change size and alignment of queue
  block/nvme: Change size and alignment of prp_list_pages
  block/nvme: Align iov's va and size on host page size

Philippe Mathieu-Daudé (21):
  MAINTAINERS: Cover 'block/nvme.h' file
  block/nvme: Use hex format to display offset in trace events
  block/nvme: Report warning with warn_report()
  block/nvme: Trace controller capabilities
  block/nvme: Trace nvme_poll_queue() per queue
  block/nvme: Improve nvme_free_req_queue_wait() trace information
  block/nvme: Trace queue pair creation/deletion
  block/nvme: Move definitions before structure declarations
  block/nvme: Use unsigned integer for queue counter/size
  block/nvme: Make nvme_identify() return boolean indicating error
  block/nvme: Make nvme_init_queue() return boolean indicating error
  block/nvme: Introduce Completion Queue definitions
  block/nvme: Use definitions instead of magic values in add_io_queue()
  block/nvme: Correctly initialize Admin Queue Attributes
  block/nvme: Simplify ADMIN queue access
  block/nvme: Simplify nvme_cmd_sync()
  block/nvme: Set request_alignment at initialization
  block/nvme: Correct minimum device page size
  block/nvme: Fix use of write-only doorbells page on Aarch64 arch
  block/nvme: Fix nvme_submit_command() on big-endian host
  block/nvme: Simplify Completion Queue Command Identifier field use

 include/block/nvme.h |  18 ++--
 block/nvme.c         | 213 ++++++++++++++++++++++++-------------------
 MAINTAINERS          |   2 +
 block/trace-events   |  30 +++---
 4 files changed, 150 insertions(+), 113 deletions(-)

Comments

Stefan Hajnoczi Nov. 3, 2020, 5:14 p.m. UTC | #1
On Thu, Oct 29, 2020 at 10:32:41AM +0100, Philippe Mathieu-Daudé wrote:
> Add a bit of tracing, clean around to finally fix few bugs.
> In particular, restore NVMe on Aarch64 host.
> 
> Since v1:
> - addressed Stefan and Eric review comments
> - dropped unnecessary patches
> - added BE fix reported by Keith
> 
> Patches missing review: #10, #24, #25
> 
> Supersedes: <20201027135547.374946-1-philmd@redhat.com>
> 
> Eric Auger (4):
>   block/nvme: Change size and alignment of IDENTIFY response buffer
>   block/nvme: Change size and alignment of queue
>   block/nvme: Change size and alignment of prp_list_pages
>   block/nvme: Align iov's va and size on host page size
> 
> Philippe Mathieu-Daudé (21):
>   MAINTAINERS: Cover 'block/nvme.h' file
>   block/nvme: Use hex format to display offset in trace events
>   block/nvme: Report warning with warn_report()
>   block/nvme: Trace controller capabilities
>   block/nvme: Trace nvme_poll_queue() per queue
>   block/nvme: Improve nvme_free_req_queue_wait() trace information
>   block/nvme: Trace queue pair creation/deletion
>   block/nvme: Move definitions before structure declarations
>   block/nvme: Use unsigned integer for queue counter/size
>   block/nvme: Make nvme_identify() return boolean indicating error
>   block/nvme: Make nvme_init_queue() return boolean indicating error
>   block/nvme: Introduce Completion Queue definitions
>   block/nvme: Use definitions instead of magic values in add_io_queue()
>   block/nvme: Correctly initialize Admin Queue Attributes
>   block/nvme: Simplify ADMIN queue access
>   block/nvme: Simplify nvme_cmd_sync()
>   block/nvme: Set request_alignment at initialization
>   block/nvme: Correct minimum device page size
>   block/nvme: Fix use of write-only doorbells page on Aarch64 arch
>   block/nvme: Fix nvme_submit_command() on big-endian host
>   block/nvme: Simplify Completion Queue Command Identifier field use
> 
>  include/block/nvme.h |  18 ++--
>  block/nvme.c         | 213 ++++++++++++++++++++++++-------------------
>  MAINTAINERS          |   2 +
>  block/trace-events   |  30 +++---
>  4 files changed, 150 insertions(+), 113 deletions(-)
> 
> -- 
> 2.26.2
> 
> 

Thanks, applied the 5.2 patches to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan