Message ID | 20201109133931.979563-1-pbonzini@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | Deprecate or forbid crazy QemuOpts cases | expand |
Patchew URL: https://patchew.org/QEMU/20201109133931.979563-1-pbonzini@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20201109133931.979563-1-pbonzini@redhat.com Subject: [PATCH v2 for-5.2 0/6] Deprecate or forbid crazy QemuOpts cases Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201104172512.2381656-1-ehabkost@redhat.com -> patchew/20201104172512.2381656-1-ehabkost@redhat.com - [tag update] patchew/20201105171126.88014-1-richard.henderson@linaro.org -> patchew/20201105171126.88014-1-richard.henderson@linaro.org - [tag update] patchew/20201105221905.1350-1-dbuono@linux.vnet.ibm.com -> patchew/20201105221905.1350-1-dbuono@linux.vnet.ibm.com - [tag update] patchew/20201106124241.16950-1-vsementsov@virtuozzo.com -> patchew/20201106124241.16950-1-vsementsov@virtuozzo.com * [new tag] patchew/20201109133931.979563-1-pbonzini@redhat.com -> patchew/20201109133931.979563-1-pbonzini@redhat.com - [tag update] patchew/5FA41448.4040404@huawei.com -> patchew/5FA41448.4040404@huawei.com Switched to a new branch 'test' 50c88b8 qemu-option: warn for short-form boolean options 5ab2220 qemu-option: move help handling to get_opt_name_value fc2619d qemu-option: clean up id vs. list->merge_lists e17617f qemu-option: restrict qemu_opts_set to merge-lists QemuOpts 7739f06 qemu-option: pass QemuOptsList to opts_accepts_any c1676e5 qemu-option: simplify search for end of key === OUTPUT BEGIN === 1/6 Checking commit c1676e514286 (qemu-option: simplify search for end of key) 2/6 Checking commit 7739f060c567 (qemu-option: pass QemuOptsList to opts_accepts_any) 3/6 Checking commit e17617fd5081 (qemu-option: restrict qemu_opts_set to merge-lists QemuOpts) WARNING: line over 80 characters #32: FILE: include/qemu/option.h:122: +bool qemu_opts_set(QemuOptsList *list, const char *name, const char *value, Error **errp); WARNING: line over 80 characters #46: FILE: softmmu/vl.c:3110: + qemu_opts_set(qemu_find_opts("machine"), "kernel", optarg, &error_abort); WARNING: line over 80 characters #51: FILE: softmmu/vl.c:3113: + qemu_opts_set(qemu_find_opts("machine"), "initrd", optarg, &error_abort); WARNING: line over 80 characters #56: FILE: softmmu/vl.c:3116: + qemu_opts_set(qemu_find_opts("machine"), "append", optarg, &error_abort); WARNING: line over 80 characters #61: FILE: softmmu/vl.c:3119: + qemu_opts_set(qemu_find_opts("machine"), "dtb", optarg, &error_abort); ERROR: line over 90 characters #71: FILE: softmmu/vl.c:3229: + qemu_opts_set(qemu_find_opts("machine"), "firmware", optarg, &error_abort); WARNING: line over 80 characters #152: FILE: util/qemu-option.c:684: +bool qemu_opts_set(QemuOptsList *list, const char *name, const char *value, Error **errp) total: 1 errors, 6 warnings, 120 lines checked Patch 3/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/6 Checking commit fc2619d6e44c (qemu-option: clean up id vs. list->merge_lists) 5/6 Checking commit 5ab2220302ba (qemu-option: move help handling to get_opt_name_value) 6/6 Checking commit 50c88b8f7929 (qemu-option: warn for short-form boolean options) WARNING: line over 80 characters #81: FILE: util/qemu-option.c:803: + warn_report("short-form boolean option '%s%s' deprecated", prefix, *name); WARNING: line over 80 characters #100: FILE: util/qemu-option.c:834: + p = get_opt_name_value(p, firstname, warn_on_flag, help_wanted, &option, &value); total: 0 errors, 2 warnings, 127 lines checked Patch 6/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201109133931.979563-1-pbonzini@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com